Received-SPF: pass (google.com: domain of linux-kernel+bounces-156574-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Hariprasad Kelam <hkelam@marvell.com>
To: Ma Ke <make_ruc2021@163.com>, "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org"
	<kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "jtornosm@redhat.com" <jtornosm@redhat.com>,
        "andrew@lunn.ch"
	<andrew@lunn.ch>,
        "horms@kernel.org" <horms@kernel.org>,
        "hkallweit1@gmail.com" <hkallweit1@gmail.com>
CC: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH v2] net: usb: ax88179_178a: Add check for
 usbnet_get_endpoints()
Thread-Topic: [PATCH v2] net: usb: ax88179_178a: Add check for
 usbnet_get_endpoints()
Thread-Index: AQHaliRRcDo5OyEMNEajq5TWcjfJPw==
Date: Wed, 24 Apr 2024 08:49:28 +0000
Message-ID: 
 <PH0PR18MB44743F344613BBD8D3E8398FDE102@PH0PR18MB4474.namprd18.prod.outlook.com>
References: <20240424065634.1870027-1-make_ruc2021@163.com>
In-Reply-To: <20240424065634.1870027-1-make_ruc2021@163.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?c+OHRP+uE1h+jGoBxpdP+ks6IQgBLGX43Ren81vQ+PZI5miugD5JPNm+9AgR?=
 =?us-ascii?Q?sXdbOibqK/6Q308hXBdTifgyNDTo2O+/iwIxxDp99f7F0SFDTXpTow2CU0Uu?=
 =?us-ascii?Q?2+3X+WkuxtCQaSKJIFcqx+7lHXmT1BTQIBDixH/7MczyVDZR/cutxDSVJCid?=
 =?us-ascii?Q?4xkEoqnad1FHwHWVUOzxOw50n6Tf4QMP8kIaw9wN65RR86YUzsCAjEOlh5bI?=
 =?us-ascii?Q?YfP2wtQ/OpduCxyBx1lWAIfLVS6BpihD+12KHcPavzm0I7NzBh8YtxHjK23x?=
 =?us-ascii?Q?Lcvupci9iKgNDygiVtJcEsHLi8COnO8Uk20jJRDcX8E+3H5CdRDZgueawAmy?=
 =?us-ascii?Q?MdZwImIu+O+/FkfG7ksC1a4Dqo+yAUN4toQKRusTVABH2wUXXLjMbu6UELMH?=
 =?us-ascii?Q?qS1pd8CDv/+cRXceYmMRVr9NK+JEMh2yK/EOzfvFov3mvP32qviRKwIP6e3h?=
 =?us-ascii?Q?ix4CPvDhjhqZn1XKpX606QogvGfxHEtpndcXNISWcr5Eg/6tuVuW5/luc94y?=
 =?us-ascii?Q?QnUkDwCDZybsaobv1CtnfW0EsEQ62oTXNDaUwZ7dswieU41CYr6asgy07aL9?=
 =?us-ascii?Q?ohiaNqhEm73U6LtpoeVTICFyD7NJqihfPWzxe0S9XKPuSQ5DBsxpKa8zOVD+?=
 =?us-ascii?Q?tXxs5TYrIfkp04cereHKs15ykt6N/OzFXGjLUEgRs8pEx7Gdo+iLIOhhU9z6?=
 =?us-ascii?Q?19DC70cY2/jsiPqrne2LA7ebOFxbuEJsbRf9bEJE8aGHq3Sy5frsrJ4diXM2?=
 =?us-ascii?Q?f8lkEUdK/SzlgqM8YzoBDBu5MOTRuDvetaqbSU3W6LIYZSv3Apj+ixyzcyjo?=
 =?us-ascii?Q?+9669oEp7qsVDNvPV6SkaFxAYon8NsmcVpWv6+U/lfCmgm05ZhMDtReSLY7k?=
 =?us-ascii?Q?HZSF22VzEZTUTZV3if+44yk5YBLEZMAJZl2qIREMf4uht5KCNwD/fI1p5gQl?=
 =?us-ascii?Q?m54OV8mrmsgoNf1jD73BeQGr1+4PwHFP5AhqVjm9vwdXRH9zCEyUtrDOrKp1?=
 =?us-ascii?Q?q3h7WXaekQn3/6PcHNwzmkJzZQUZLWTZU1YPPYoGIatRnVNVOFYnuwLKXs51?=
 =?us-ascii?Q?NdFFLUsRjcCTSihcIW8GglmTrdbcD3UXerG48cOaYomGzCFOGFSgZoiQwJwo?=
 =?us-ascii?Q?b1Y5DxuM1zf16snSJtdZy2m9VauLtC4JIdwEBEog9buPMBXvwvK2zI/nDVJE?=
 =?us-ascii?Q?3Pb53wjnTGfcoqxHFs0h/OtgJ9McfSelwQDNBLT5KArjeaYw5CBJ6gawG1jw?=
 =?us-ascii?Q?jz3nEoC9ZVUmQmVyYwNZGWZo2CaR4EY40bGKFjOP7jW/bwdVK9zkhIKhra0k?=
 =?us-ascii?Q?iWicPcX+0FJ5vLr4nuq8OT3NWoFl8eKKTYga6exxYYfn+MaL/dccdUXQEICr?=
 =?us-ascii?Q?lhMh1F9mviHXspYSAVGup8F+ESO5cz4kAXb6Fva0JNtptgEVdr8eCNL5Vaxn?=
 =?us-ascii?Q?Ef/UDuc5JC/z27ssEYj5ve5H7aoIqa6NEG8fijlTi1YycA41OxVkUG/xi3Cz?=
 =?us-ascii?Q?gOEsj2DYT5d/q8CdbITeeQ557SJ4KVvRNn1ErcM+kNKn9lcSvG7H/Vipo+Ct?=
 =?us-ascii?Q?llsKjgzUSzqI/ek8QMo=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4474.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c3109e8-5d0f-4e44-93e6-08dc643b73db
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2024 08:49:28.8816
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: hazs87SUytDiHvbeDgFnxgtWIQVCAxTv1DTVe599qY/RqL2Xl9xa9NCgiiIuuyVVsriLbbla52orATsIpX723w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR18MB6345
X-Proofpoint-GUID: CxpAUFxRb6CWYJCMKbAn9wfOeu7aSppC
X-Proofpoint-ORIG-GUID: CxpAUFxRb6CWYJCMKbAn9wfOeu7aSppC
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-04-24_06,2024-04-23_02,2023-05-22_02


> To avoid the failure of usbnet_get_endpoints(), we should check the retur=
n
> value of the usbnet_get_endpoints().
>=20
> Signed-off-by: Ma Ke <make_ruc2021@163.com>
> ---
>  drivers/net/usb/ax88179_178a.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/usb/ax88179_178a.c
> b/drivers/net/usb/ax88179_178a.c index 752f821a1990..388ea178c91d
> 100644
> --- a/drivers/net/usb/ax88179_178a.c
> +++ b/drivers/net/usb/ax88179_178a.c
> @@ -1287,8 +1287,11 @@ static void ax88179_get_mac_addr(struct usbnet
> *dev)  static int ax88179_bind(struct usbnet *dev, struct usb_interface *=
intf)  {
>  	struct ax88179_data *ax179_data;
> +	int ret;
>=20
> -	usbnet_get_endpoints(dev, intf);
> +	ret =3D usbnet_get_endpoints(dev, intf);
> +	if (ret < 0)
> +		return ret;
>=20
>  	ax179_data =3D kzalloc(sizeof(*ax179_data), GFP_KERNEL);
>  	if (!ax179_data)
> --
> 2.37.2
>=20
Nit: please include  patch change log, below link required info
https://docs.kernel.org/process/submitting-patches.html


Reviewed-by: Hariprasad Kelam <hkelam@marvell.com>