Received-SPF: pass (google.com: domain of linux-kernel+bounces-156594-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Hariprasad Kelam <hkelam@marvell.com>
To: Hayes Wang <hayeswang@realtek.com>, "kuba@kernel.org" <kuba@kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>
CC: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "nic_swsd@realtek.com"
	<nic_swsd@realtek.com>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>,
        "linux-usb@vger.kernel.org"
	<linux-usb@vger.kernel.org>
Subject: [PATCH net-next] r8152: replace dev_info with dev_dbg for loading
 firmware
Thread-Topic: [PATCH net-next] r8152: replace dev_info with dev_dbg for
 loading firmware
Thread-Index: AQHaliZl1cms0fPnZ0yLRIDtVcUivw==
Date: Wed, 24 Apr 2024 09:04:21 +0000
Message-ID: 
 <PH0PR18MB447451E4C0CECE275218336CDE102@PH0PR18MB4474.namprd18.prod.outlook.com>
References: <20240424084532.159649-1-hayeswang@realtek.com>
In-Reply-To: <20240424084532.159649-1-hayeswang@realtek.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?/p/ZCG0b68zbSafxw+eYS0xELa6PQ0jkwkP1jGXasKikdL2tMJbBF/uF7lLe?=
 =?us-ascii?Q?yL5bges+DTQXmZTZyoyWXLmc0iHndEYzscw5XtgN/RjnqQT+cFCp8xQMm3il?=
 =?us-ascii?Q?Bs4f/NYXy1ICsO3MAid7UqIWW6ItZy4bNtC/jK7Od+jVyM09DMWYNQrJq+Yt?=
 =?us-ascii?Q?UsvElFT9/OpQR6AlQhm0K0iLRYhp5+Z/QHEuMBHXsEBeC7T0UkpwfBGHheAl?=
 =?us-ascii?Q?Ol1yqD5k7IIC0YAZVu6eD0vBrqnotzr7pvCSS97F7rzrrvezPexQQXAuhboY?=
 =?us-ascii?Q?/U+nYxlGJTEGvMnk3+KLa2DKiPEWQVOnGN5vmHYb0KfMtRDPZFsdcIptQxQC?=
 =?us-ascii?Q?ej8qt53CT1JXr38UMM9qkcIrIapHQJRTBox82ZXUAMXUovTVvBmfJKvTuMt6?=
 =?us-ascii?Q?lj6r6vZwNk6GOZeWGr0oWeX6HQ0k4Too17lSVO9UsRuTMiK2fxS3BBinhOOp?=
 =?us-ascii?Q?xK19encz0uRNYX7BiHChIC9m9twYcpR1R1ZAKuX+klwfAJgS76GTUJGSFQeA?=
 =?us-ascii?Q?8AQENysOs7T5nF6R9LOrZOufVIvhhUxG9z1PfZ4QXrulvHkSH/AVW3CDMa4E?=
 =?us-ascii?Q?NncCrXP4ZqAmil5i+01ZQxAKvJlvN+wwFwbmj6g4SRwD206UGQFQFcgoqZ7t?=
 =?us-ascii?Q?VPeq+x0SKzIrHWkeHJmunapTD9NYWfRdue67/55pOY3TiADSbhevJnquqAjR?=
 =?us-ascii?Q?mKUNSmAXi8IRPG6CI88s9WqfMMjEgauY3srmLoue5ecpCpNMF1Sfin0muHaj?=
 =?us-ascii?Q?PPhuttkRnNddIDmd89v4VZIKIMUludyXGgCHX1BvJ+DzzMuZsv3cDlZLU3Y5?=
 =?us-ascii?Q?+ltyWMBVu9Omp2pWFcKr9qWH4P88TmuNriCeYKld6cYoUr6/LGzhfvoSKmcc?=
 =?us-ascii?Q?S267sKpdOb32VHVObcqD0SY8X15bqYu5MVOqhks3KqwPKFdlGdrBkqv738Vx?=
 =?us-ascii?Q?N11bCwyUcwg9kT1bd8P75vPewhyXpVuZTs/Rx8QAZld2Djjsrfn5S/0UrtCq?=
 =?us-ascii?Q?z7fL3z257KCO9flmHz8IJm4hmcmJ4qJiv0j0XgdM00GX3hfzfZ+ZERiE7ami?=
 =?us-ascii?Q?NtNFOhCgxOD7QaSFci2YurF07Djwi/B6xpGuipgukneOvk2o7/vSIibpqvAK?=
 =?us-ascii?Q?xMjgxWjpSw9oWzi8JFV1TTESI2ONwRpiHSrCVejGwVEbxySbG+BQmTvpxnhm?=
 =?us-ascii?Q?JHpd282zOGPHtaZzFCm4t8XEFLx7oQSlKGFE9S28RZmA68lln/Q2XV9k5C1F?=
 =?us-ascii?Q?HsOlBWKurFRP0Py+v00RPkl9QKjLq3yT5vJtruLpZzO9X1Tdn06IOBiw3PII?=
 =?us-ascii?Q?yW8TRuRzWKqbn5PMkyg68ZMDLRYpDFYgbSUk17QRKfEfSz6IaHEGFx6lE8bL?=
 =?us-ascii?Q?BnIOe97XE78F4DVGvCXPZij1RsiZL6NORtp3qNxv/T/hC+aXyHtfbXCC2Zon?=
 =?us-ascii?Q?R4iev2ejS9VBd8Llx2MO0CWqmzWuXX9TlmYTVBfK4bJ3kYQfK27iN4pwWFYt?=
 =?us-ascii?Q?9EgPGGM4IJet3rML78oQtPJM8yYRR6MQp8FzIxP98r63hMZgCW5P6jD3w18r?=
 =?us-ascii?Q?TTPQBuzEisMawAH4e9Y=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4474.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 98437201-c9b7-4aad-dbb4-08dc643d8811
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2024 09:04:21.8082
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: G4+yl7aQGSZJe21zATGt5mfmZjzgeZkluWHt+cuqI79EHYODO8pdRfNf/nqDOy1dsLq2knmQ82LAUH7PomVKbA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR18MB4840
X-Proofpoint-GUID: o5CSDZNjTWb9L7ZXWEEUP86Uu9gJYhJR
X-Proofpoint-ORIG-GUID: o5CSDZNjTWb9L7ZXWEEUP86Uu9gJYhJR
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-04-24_06,2024-04-23_02,2023-05-22_02


> Someone complains the message appears continuously. This occurs because
> the device is woken from UPS mode, and the driver re-loads the firmware.
>=20
> When the device enters runtime suspend and cable is unplugged, the device
> would enter UPS mode. If the runtime resume occurs, and the device is
> woken from UPS mode, the driver has to re-load the firmware and causes th=
e
> message. If someone wakes the device continuously, the message would be
> shown continuously, too. Use dev_dbg to avoid it.
>=20
> Note that, the function could be called before register_netdev(), so I do=
n't use
> netif_info() or netif_dbg().
>=20
> Signed-off-by: Hayes Wang <hayeswang@realtek.com>
> ---
>  drivers/net/usb/r8152.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index
> 5d6aeb086fc7..51e9f5b2dccf 100644
> --- a/drivers/net/usb/r8152.c
> +++ b/drivers/net/usb/r8152.c
> @@ -5274,7 +5274,7 @@ static void rtl8152_apply_firmware(struct r8152 *tp=
,
> bool power_cut)
>=20
>  	rtl_reset_ocp_base(tp);
>  	strscpy(rtl_fw->version, fw_hdr->version, RTL_VER_SIZE);
> -	dev_info(&tp->intf->dev, "load %s successfully\n", rtl_fw->version);
> +	dev_dbg(&tp->intf->dev, "load %s successfully\n", rtl_fw->version);
Since enabling dev_dbg involves re-compiling kernel if CONFIG_DYNAMIC_DEBUG=
 not enabled,
 Does it make sense to use  "dev_info_ratelimited" here.

Thanks,
Hariprasad k
>  }
>=20
>  static void rtl8152_release_firmware(struct r8152 *tp)
> --
> 2.44.0
>=20