Received-SPF: pass (google.com: domain of linux-kernel+bounces-156645-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <33aab745-19fa-47f1-9d0b-863e88b6548c@web.de>
Date: Wed, 24 Apr 2024 11:35:46 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Kunwu Chan <chentao@kylinos.cn>, bpf@vger.kernel.org,
 linux-kselftest@vger.kernel.org, kernel-janitors@vger.kernel.org,
 Alexei Starovoitov <ast@kernel.org>, Andrii Nakryiko <andrii@kernel.org>,
 Daniel Borkmann <daniel@iogearbox.net>, Eduard Zingerman
 <eddyz87@gmail.com>, Hao Luo <haoluo@google.com>,
 Jiri Olsa <jolsa@kernel.org>, John Fastabend <john.fastabend@gmail.com>,
 KP Singh <kpsingh@kernel.org>, Martin KaFai Lau <martin.lau@linux.dev>,
 Mykola Lysenko <mykolal@fb.com>, Shuah Khan <shuah@kernel.org>,
 Song Liu <song@kernel.org>, Stanislav Fomichev <sdf@google.com>,
 Yonghong Song <yonghong.song@linux.dev>
Cc: LKML <linux-kernel@vger.kernel.org>, Kunwu Chan <kunwu.chan@hotmail.com>
References: <20240424020444.2375773-2-chentao@kylinos.cn>
Subject: Re: [PATCH bpf-next 1/4] selftests/bpf: Add some null pointer checks
Content-Language: en-GB
From: Markus Elfring <Markus.Elfring@web.de>
In-Reply-To: <20240424020444.2375773-2-chentao@kylinos.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:Bg05E1BxaFg=;KhLN/NpZF68ZfUOe1TSvGUFsRz9
 yKhOgZM2TwHifoj2Z+3g/xP3fZlMyHlTcz4zQLf8rhvX/f2of+epc9fix2CC1mEhTzV39tKiT
 /ihKYN17FQc9UmZ1yU9DkSHZWl1oNDCR5Btxyy2w+5yyGYPuz2kuL5fHJ6PvltPzFYpsNyFZg
 iMMrji3Jxe0/nPkR8exa1xuw/fyw383L7MXfwdGG/C8VWvCGj6qJO28Srkac4af6cbOefH2BY
 pY4VaNkMIWaaPedWvN8GQt9/wcSUMd+StHfoVbsQtzrMAtH0kCGVV5f0CJVcJkPWEQXs5P9i8
 Qypu0b6T14MNoJJyiV4MdDpHRDjMwig8vallNUoWkzQh/yOm+jpXE/ljlzrw8EqDzvAanD+cW
 x4sK2WVT6F1rqwTgVEkMlTi2Pxac0f9nqsHwW2ioKib5i1HEmmWo2x0xjHIOCp8csmUCAV3mb
 L4ojJ/oZkgMb4JP/5QibdodgjKxRs5kAhWkZvKbM93sI55Fb99OfXju0APopkS+m1KNwvqFqB
 RbS2InGI3RV2Rbj/DWmdiQCZ8gnurb+58TO3BmzC1znlRt0d3OdRrjxq05p+0zLA3Nfs5RrOD
 vgFBxUqZ0oWfS34ZI6ICGFhcKWjd/QUf0b/HvEFsZd79yB5OgfYi0JeYbE/f/2a6dWvx8u2sl
 GX3jLt2K0k7M9Ye5vz27lbCyjNDoKdtg9QoA32ffSw+32oFQRioBQZSBz90cnKd1uo3T3uK/j
 blrmTur4FtfH5PP2CdUcXeVHqB4Oeo+JBEg6oQ4GyXuqDBuNCFtOZxBhE8VfnBHQ1zYKM6wdt
 +gSMlG1sFsKEydUj6dnG2aYflI4ZXmBLV3cQcfaAjTZNs=

=E2=80=A6
> This patch will add the malloc failure checking
=E2=80=A6

* Please use a corresponding imperative wording for the change description=
.

* Would you like to add the tag =E2=80=9CFixes=E2=80=9D accordingly?


=E2=80=A6
> +++ b/tools/testing/selftests/bpf/test_progs.c
> @@ -582,6 +582,11 @@ int compare_stack_ips(int smap_fd, int amap_fd, int=
 stack_trace_len)
>
>  	val_buf1 =3D malloc(stack_trace_len);
>  	val_buf2 =3D malloc(stack_trace_len);
> +	if (!val_buf1 || !val_buf2) {
> +		err =3D -ENOMEM;
> +		goto out;
> +	}
=E2=80=A6

How do you think about to reuse =E2=80=9Cerrno=E2=80=9D in such error case=
s?

Regards,
Markus