Received-SPF: pass (google.com: domain of linux-kernel+bounces-156656-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <a2efd882-2d69-490b-8362-c87e10dc625e@quicinc.com>
Date: Wed, 24 Apr 2024 15:18:15 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V5 RESEND 4/5] clk: qcom: Use HW_CTRL_TRIGGER flag to
 switch video GDSC to HW mode
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
        Bjorn Andersson
	<andersson@kernel.org>,
        Michael Turquette <mturquette@baylibre.com>,
        "Stephen
 Boyd" <sboyd@kernel.org>,
        Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
        Vikash Garodia <quic_vgarodia@quicinc.com>,
        Bryan O'Donoghue
	<bryan.odonoghue@linaro.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        "Ulf Hansson" <ulf.hansson@linaro.org>,
        "Rafael J . Wysocki"
	<rafael@kernel.org>,
        Kevin Hilman <khilman@kernel.org>, Pavel Machek
	<pavel@ucw.cz>,
        Len Brown <len.brown@intel.com>,
        Greg Kroah-Hartman
	<gregkh@linuxfoundation.org>,
        "Andy Gross" <agross@kernel.org>,
        Dmitry
 Baryshkov <dmitry.baryshkov@linaro.org>,
        Abel Vesa <abel.vesa@linaro.org>
CC: <linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-media@vger.kernel.org>,
        <linux-pm@vger.kernel.org>, Taniya Das <quic_tdas@quicinc.com>,
        "Satya Priya
 Kakitapalli" <quic_skakitap@quicinc.com>,
        Imran Shaik
	<quic_imrashai@quicinc.com>,
        Ajit Pandey <quic_ajipan@quicinc.com>
References: <20240413152013.22307-1-quic_jkona@quicinc.com>
 <20240413152013.22307-5-quic_jkona@quicinc.com>
 <3592cea4-7e5c-448a-83c0-562b4ef4e7a1@linaro.org>
Content-Language: en-US
From: Jagadeesh Kona <quic_jkona@quicinc.com>
In-Reply-To: <3592cea4-7e5c-448a-83c0-562b4ef4e7a1@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit


On 4/23/2024 4:24 AM, Konrad Dybcio wrote:
> 
> 
> On 4/13/24 17:20, Jagadeesh Kona wrote:
>> The HW_CTRL_TRIGGER flag provides flexibility to switch the GDSC
>> mode as per the consumers requirement compared to HW_CTRL flag which
>> directly switches the GDSC mode as part of gdsc enable/disable.
>> Hence use HW_CTRL_TRIGGER flag for vcodec GDSC's to allow venus driver
>> to switch the vcodec GDSC to HW/SW control modes at runtime using
>> dev_pm_genpd_set_hwmode() API.
>>
>> Signed-off-by: Jagadeesh Kona <quic_jkona@quicinc.com>
>> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
>> ---
> 
> The commit title states clk: qcom: yet the only files changed are:
>

Thanks Konrad for your review! As there are 2 files with similar 
changes, I didn't mention file names in the commit title.

>>   drivers/clk/qcom/videocc-sc7280.c | 2 +-
>>   drivers/clk/qcom/videocc-sm8250.c | 4 ++--
> 
> With no explanation as to why anywhere
>

Sure, will update the target specific details in the commit text of next 
series.

Thanks,
Jagadeesh

> Konrad