Received: by 2002:a89:48b:0:b0:1f5:f2ab:c469 with SMTP id a11csp329172lqd; Wed, 24 Apr 2024 03:51:31 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUuj9QPn0m89JEcGNzV5MZm21ru/zoSktu2iP05RrqZFowHNMQ3zZd20D+CFV8IQ47Zgq6zIdujltDXfgmoWcghrIzEfVArH+tXEoHOkw== X-Google-Smtp-Source: AGHT+IHvAWLHekOguwRYx/9tRgKDhb6O8i4qQ3/KvgEdzHNmMBdqQZHBPfYmgorWr/nUZgahBBW9 X-Received: by 2002:a17:90a:cc17:b0:2a4:f16f:f31f with SMTP id b23-20020a17090acc1700b002a4f16ff31fmr1681246pju.40.1713955891049; Wed, 24 Apr 2024 03:51:31 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713955891; cv=pass; d=google.com; s=arc-20160816; b=hs66Nl8BaQlKdeQWALkngkKm4R1QLsXePILkF6VHfGosbl1PvCRDMNvmAd8ogz/kTY uG+VdHOavxJIn9Pv63ONmC+m5WPCzQ+ZWjeUTVqo0l7r58DOyFRGvSUKoTTZH9ymDdeJ FhtxCOk/7+USUoopW6LVKF7hRJWtC5buLEZ+1psyz5HcrHFMQa1fkELbkhM/T6UJmyok ePdOaVurRq5qMIAywcZHhP9F7QvUaMlztoz6SoGXAW2cIWX470qc3Zwqf+9Ijc3U+n9t CYvvcTKJe/FbaBvGp15R2Pbyo4xG98TffpKfGRSAKZ91Qc23FX4STUikISbOiiEeNJWP jG9w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=obSGRI92SvTZ9PO94qPHWzuYNKWRL1pDAIG/iGUyOTY=; fh=6i7dt3O0S5Vuc/kSsDNX46bfuLeKuDrGb7pgmBROIg0=; b=OIsemFSKHlXNZt55y377xhioqdGsrMwKQV/ykTeC1uak/NC1oZkpe1rSP+gHN/EnAi rhevWG82jKziz6sdII7A/OUT0dMpU3ZmOh3doDGSn0je7+Rj7MKf/gOHrDV5Hmm0p4+T iv2pM6mKzzaIJeiO6lH9O5Fo8NfAoyw2nkjnBNC8Hzpqr5pDuPNas511o4WdbkKAG4T2 09YnouxQm6HTImv0/1KE6W8prLis5FnM0R6kXcjD1GUrpDEfKdXT/+b7yeMXz4rwaavS pcNpQuojip7+E+7ei7g3FxfrM5xnKHhoZjE0WJC8SmdG59XzvXgITAuLT//ezIJTWT2N jMMw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="AmQj/zoo"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-156751-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-156751-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id h12-20020a17090a9c0c00b002a26a9f6b4esi12454334pjp.175.2024.04.24.03.51.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 03:51:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-156751-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="AmQj/zoo"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-156751-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-156751-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id A0219284E94 for ; Wed, 24 Apr 2024 10:51:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1AF7315A483; Wed, 24 Apr 2024 10:51:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AmQj/zoo" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 482D215A480 for ; Wed, 24 Apr 2024 10:51:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713955872; cv=none; b=FNLmJ8L8KgR+rwwKAylsRqnylPkGj/AcyYNx5tav3KJu/F45eXpUqnSqnrdmetQlVrDnbf1ANDo5/DCFl5r0b2Xc83801XFXPdcFG2fJsZXm+T70SySlai9897tyHNrgCbazR0XLYWSg7i1Lr+R4tOk8W8CvgNSBPF1bKlr14Wc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713955872; c=relaxed/simple; bh=obSGRI92SvTZ9PO94qPHWzuYNKWRL1pDAIG/iGUyOTY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Zeks9DuTrRS3Rq4rcXseQzqAfteLeapIHxfGiqrOpRWbJq3qklU/BnCSwPBSca9x7qmoiRyWDqoi615QqlhmLjVnckef6g21I0IMYkSDA8hrCORm8eBaklgZ+2sTRT/PsnrsKIal3RhJdqE292ib30zZFsS/coBSik1Rhxkq3Uo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AmQj/zoo; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7FA2C2BD10; Wed, 24 Apr 2024 10:51:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713955871; bh=obSGRI92SvTZ9PO94qPHWzuYNKWRL1pDAIG/iGUyOTY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AmQj/zooWZ3PBfCr/1PBC1YPwq9c0rnN0W2XFl9j/zySAGvGQpdlq9r69sPyzHzYn xlmKYW1J/nLcItRS5T8Xe1TPuP4PHkYQW9MPzvA5Llt6ZBDLxwxwEp26o7WNdrUI3c oHmolzPn72EBmNKFsdU3v2+hfUxVJzNiE+SvMziHdVWOWP9bjC8GYl0CgDyHubp4ke tojqxBdUeAIMQE2CowL6ilXQKFC4E9NL+53jt2KMfLn5HdOL7RT9d/v4YvgTbp4aGD bT/xE6XjUMqOBYYqOZbe58ri4VvMKtF0B7gsAX+jZD9voORGTI6YYYDD9ujLARuUjg yhUlSvLz2skZw== Date: Wed, 24 Apr 2024 11:51:08 +0100 From: Conor Dooley To: Samuel Holland Cc: Palmer Dabbelt , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 6/7] riscv: Use offset_in_page() in text patching functions Message-ID: <20240424-unthread-pelican-93629280bf14@spud> References: <20240327160520.791322-1-samuel.holland@sifive.com> <20240327160520.791322-7-samuel.holland@sifive.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="x/oSwXS7Hv3e0hQM" Content-Disposition: inline In-Reply-To: <20240327160520.791322-7-samuel.holland@sifive.com> --x/oSwXS7Hv3e0hQM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Mar 27, 2024 at 09:04:45AM -0700, Samuel Holland wrote: > This is a bit easier to parse than the equivalent bit manipulation. And it is used elsewhere in patch.c too, so makes things more consistent to boot. Reviewed-by: Conor Dooley --x/oSwXS7Hv3e0hQM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZijkHAAKCRB4tDGHoIJi 0jqeAP9xB3Z24T1JfUA6sc27uXaYJ+OXu4Vo19lKXI8bvBIi+wD/ZuREtm4j6NZz VPyLYewtekIG4sVePf3T4wcv4gmxkwM= =YSu0 -----END PGP SIGNATURE----- --x/oSwXS7Hv3e0hQM--