Received: by 2002:a89:48b:0:b0:1f5:f2ab:c469 with SMTP id a11csp330130lqd; Wed, 24 Apr 2024 03:53:56 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUMT+TVWZl0PTr8/ffEW0oRxeFyCRdiLp1Ubo5Zy0IoHYYTh/fvPoxVsKuUNtdtPEUiOPCNxKsQWOBAVLyG0o8EZgmBPCjmfu8ykzCF8Q== X-Google-Smtp-Source: AGHT+IHUJk5fdHexZC/p3IfKuM4dbmk3ZmSZHF31FcO4EEjeg1JXkjRvQftITq/YQqGkILr6PIgz X-Received: by 2002:a05:6808:190f:b0:3c5:f919:4267 with SMTP id bf15-20020a056808190f00b003c5f9194267mr2165465oib.47.1713956036601; Wed, 24 Apr 2024 03:53:56 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713956036; cv=pass; d=google.com; s=arc-20160816; b=Dwqt2GO/1AHA8YVeKGhZc/p1fQ170fUvJdVtP+yCPopSWQQveY4rkHEG/iEzL05rtc /23mtvhjXzs1h77ycHlKrKzl1YHHyv2HetLU3Z0ywijRZhwreOp5Qv+62b6f6zWzjcOf pfqHhbeFIclUgIBc1cEWxe7mseVXMvMSd56Utkyt7SAGmASZ2S80wqSaPJ1RdFrI7+PT 29Rn8QOU4unLnqaVASX815JRR1c+heYfxlYxp4s0k1N+VWsXO82r8X2BMQ+wPfR7PPNV qyMGw7b53kK6Unc2Gc/Ew87BGThjumETkt6mrx8tk+d27/MCyPsGwrQKyIGS0naXSNJf tR7Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=NThC23+STtu5jIlCkZZ55VUlsZKxUy/kB3g48hy+hDI=; fh=P7NhKE2g176075oaxBUiOZgfOx9Q/i6O87bCIRoMdNI=; b=ihaaNkt/ZUD8OaDjBQdBYvzArnv9/STFAje1isiZFgYDrbVGwJV0dmLuGBsR3wzlIg KbDjcrXPRyegj4x7HpUTxIxuSDEixkMI2Dka2SiwG72F/k8k1HmOce2fM+oJ0+O2DVxG YWyPubC+4NV4kMNi6kaYhcMbMzeqDE6DrXiHCZQSdxLLZorovSwnmC5PWcioUu++Ld/h /nkkNMz14DQqQ9IdA8RfNJXL6+NPRiGC+XngSJyd9QWHmwBDKmc6lh2gTbfkNPT8eL1w EVgfw5GdHw2XGLNcAhcwGuGDa0vZy2aqflLGZ2kgrEwWFUDxqIASlzRZOEMZTbMvJteC TtCA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-156756-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-156756-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id e1-20020a635001000000b0060474ff7527si2070730pgb.850.2024.04.24.03.53.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 03:53:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-156756-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-156756-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-156756-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 3B5672864E5 for ; Wed, 24 Apr 2024 10:53:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 24F6715AD9D; Wed, 24 Apr 2024 10:53:14 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 36865156C6F; Wed, 24 Apr 2024 10:53:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713955993; cv=none; b=nzlkQlurNrHRVTdFIsMM+XP9kpz29sAf13rUkpKJ/EvFY92q3IA7St1FdWvkDFQKTZ6s80KVQKbBY29st86izLwvnoqmgr5ppaKwwfekICdCIYTibqnTy4/OWTyLw0st3Np37Jvkdip/u5NPk4L3e3PG0GWCbJgka6jVRwcn2BA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713955993; c=relaxed/simple; bh=js8C/26yYtRBsgN6k1rTXrGTe9JoFXS17KjL+cl13uA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=CM0MmFGhQVsLFEzcb8aIF+n4NzsKueSO7IUpfLKG3OGy+8Gb1lkvYZMYZzJYN4K4I1qVIBgE7ggoMJYe8BjfBSL4haNmOmPJmsHDzvExjAuyvXbrXCFAmgh3wN43A+aNkCN18t13FY7K4QEus1q2+jZYcECsp4yPz66JsqwtMpY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D58A0339; Wed, 24 Apr 2024 03:53:37 -0700 (PDT) Received: from e125769.cambridge.arm.com (e125769.cambridge.arm.com [10.1.196.27]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 23FCE3F73F; Wed, 24 Apr 2024 03:53:09 -0700 (PDT) From: Ryan Roberts To: Andrew Morton , Shuah Khan Cc: Ryan Roberts , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Muhammad Usama Anjum , David Hildenbrand Subject: [PATCH v1] selftests/mm: soft-dirty should fail if a testcase fails Date: Wed, 24 Apr 2024 11:53:01 +0100 Message-Id: <20240424105301.3157695-1-ryan.roberts@arm.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Previously soft-dirty was unconditionally exiting with success, even if one of it's testcases failed. Let's fix that so that failure can be reported to automated systems properly. Reviewed-by: Muhammad Usama Anjum Reviewed-by: David Hildenbrand Signed-off-by: Ryan Roberts --- Applies on top of v6.9-rc3. I previously sent this out as part of a larger series [1]. Feedback was to repost standalone. [1] https://lore.kernel.org/all/20240419074344.2643212-1-ryan.roberts@arm.com/ Thanks, Ryan tools/testing/selftests/mm/soft-dirty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/soft-dirty.c b/tools/testing/selftests/mm/soft-dirty.c index 7dbfa53d93a0..bdfa5d085f00 100644 --- a/tools/testing/selftests/mm/soft-dirty.c +++ b/tools/testing/selftests/mm/soft-dirty.c @@ -209,5 +209,5 @@ int main(int argc, char **argv) close(pagemap_fd); - return ksft_exit_pass(); + ksft_finished(); } -- 2.25.1