Received-SPF: pass (google.com: domain of linux-kernel+bounces-156765-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <6c9e5914-8dee-4929-b574-f59f50305f4a@yandex.ru>
Date: Wed, 24 Apr 2024 13:58:38 +0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/2] fs: reorganize path_openat()
Content-Language: en-US
To: David Laight <David.Laight@ACULAB.COM>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Eric Biederman <ebiederm@xmission.com>,
 Alexander Viro <viro@zeniv.linux.org.uk>,
 Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
 Andy Lutomirski <luto@kernel.org>,
 "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
References: <20240422084505.3465238-1-stsp2@yandex.ru>
 <858f6fb6afcd450d85d1ff900f82d396@AcuMS.aculab.com>
From: stsp <stsp2@yandex.ru>
In-Reply-To: <858f6fb6afcd450d85d1ff900f82d396@AcuMS.aculab.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

24.04.2024 12:17, David Laight пишет:
> You probably ought to merge the two 'unlikely' tests.
> Otherwise there'll be two conditionals in the 'hot path'.
> (There probably always were.)
> So something like:
> 	if (unlikely(op->open_flag & (__O_TMPFILE | O_PATH))) {
> 		file = alloc_empty_file(op->open_flag, current_cred());
> 		if (IS_ERR(file))
> 			return file;
> 		if (op->open_flag & __O_TMFILE)
> 			error = do_tmpfile(nd, flags, op, file);
> 		else
> 			error = do_o_path(nd, flags, file);
> 	} else {

Posted v4 with this code verbatim.

> Copying op->open_flag to a local may also generate better code.
Done this as well.

Thank you.