Received-SPF: pass (google.com: domain of linux-kernel+bounces-156771-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 24 Apr 2024 12:01:33 +0100
From: Conor Dooley <conor@kernel.org>
To: Jisheng Zhang <jszhang@kernel.org>
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Samuel Holland <samuel.holland@sifive.com>,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] clocksource/drivers/timer-clint: Add option to
 use CSR instead of mtime
Message-ID: <20240424-ivory-undefined-0c96bd289c36@spud>
References: <20240406112159.1634-1-jszhang@kernel.org>
 <20240406112159.1634-3-jszhang@kernel.org>
 <20240409-krypton-employed-b2e0e1b46ddf@spud>
 <ZhVVPB0qD4pBna51@xhacker>
 <ZhZqNbbUyPhVzekO@xhacker>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="h1r6PhpT3M2gVcJm"
Content-Disposition: inline
In-Reply-To: <ZhZqNbbUyPhVzekO@xhacker>


--h1r6PhpT3M2gVcJm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 10, 2024 at 06:30:13PM +0800, Jisheng Zhang wrote:
> On Tue, Apr 09, 2024 at 10:48:33PM +0800, Jisheng Zhang wrote:
> > On Tue, Apr 09, 2024 at 03:26:18PM +0100, Conor Dooley wrote:
> > > On Sat, Apr 06, 2024 at 07:21:58PM +0800, Jisheng Zhang wrote:
> > > > As pointed out by commit ca7810aecdba ("lib: utils/timer: mtimer: a=
dd a
> > > > quirk for lacking mtime register") of opensbi:
> > > >=20
> > > > "T-Head developers surely have a different understanding of time CS=
R and
> > > > CLINT's mtime register with SiFive ones, that they did not implement
> > > > the mtime register at all -- as shown in openC906 source code, their
> > > > time CSR value is just exposed at the top of their processor IP blo=
ck
> > > > and expects an external continous counter, which makes it not
> > > > overrideable, and thus mtime register is not implemented, even not =
for
> > > > reading. However, if CLINTEE is not enabled in T-Head's MXSTATUS
> > > > extended CSR, these systems still rely on the mtimecmp registers to
> > > > generate timer interrupts. This makes it necessary to implement T-H=
ead
> > > > C9xx CLINT support in OpenSBI MTIMER driver, which skips implementi=
ng
> > > > reading mtime register and falls back to default code that reads ti=
me
> > > > CSR."
> > > >=20
> > > > To use the clint in RISCV-M NOMMU env on Milkv Duo little core, we
> > > > need to fall back to read time CSR instead of mtime register. Add t=
he
> > > > option for this purpose.
> > > >=20
> > > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> > >=20
> > > > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kcon=
fig
> > > > index 34faa0320ece..7bbdbf2f96a8 100644
> > > > --- a/drivers/clocksource/Kconfig
> > > > +++ b/drivers/clocksource/Kconfig
> > > > @@ -650,6 +650,15 @@ config CLINT_TIMER
> > > >  	  This option enables the CLINT timer for RISC-V systems.  The CL=
INT
> > > >  	  driver is usually used for NoMMU RISC-V systems.
> > > > =20
> > > > +config CLINT_USE_CSR_INSTEADOF_MTIME
> > > > +	bool "Use TIME CSR instead of the mtime register"
> > > > +	depends on CLINT_TIMER
> > > > +	help
> > > > +	  Use TIME CSR instead of mtime register. Enable this option if
> > > > +	  prefer TIME CSR over MTIME register, or if the implementation
> > > > +	  doesn't implement the mtime register in CLINT, so fall back on
> > > > +	  TIME CSR.
> > >=20
> > > This, as a Kconfig option, seems a bit strange to me. We know at runt=
ime
> > > if we are on a T-Head device without the mtime register and should be
> > > able decide to use the CSR implementation dynamically in that case,
> > > right?
> >=20
> > Dynamically decision can be done in clocksource/clockevnt:
> > I can patch clint_clocksource.read to point to different clint_rdtime()
> > implementation.
> >=20
> > But clint timer is also used in NOMMU RISCV-M's get_cycles(), this
> > can't be dynamically chosen w/o an ugly "if (is_c900)"
> > check, and I'm not sure whether this check in get_cycles() will
> > introduce non-trival overhead or not. Or use code patching technology
> > here?
>=20
> Hi,
>=20
> After some tests, I think will go with code patching path, I.E use
> static_branch in get_cycles(). New version is under cooking.

Whoops, sorry for the delay getting back to you - been busier than I
would like of late. Patching sounds good to me if your testing went
well.

--h1r6PhpT3M2gVcJm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZijmjAAKCRB4tDGHoIJi
0lW7AP9ELlOwlUcv5ji1DJE0FSqDfjyy0OOh7tUjreEqkrMykgEA298NQRO9jsRF
Eqs54vfBUEEhkTfzEU9Wf+8F7mdOSwU=
=99xV
-----END PGP SIGNATURE-----

--h1r6PhpT3M2gVcJm--