Received-SPF: pass (google.com: domain of linux-kernel+bounces-156777-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <8cb7f43e-0ee9-423d-ad27-93b3c69809f5@intel.com>
Date: Wed, 24 Apr 2024 13:06:26 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] x86: enable HAVE_LD_DEAD_CODE_DATA_ELIMINATION
To: Yuntao Liu <liuyuntao12@huawei.com>
CC: <linux-kernel@vger.kernel.org>, <linux-kbuild@vger.kernel.org>,
	<tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
	<dave.hansen@linux.intel.com>, <hpa@zytor.com>, <masahiroy@kernel.org>,
	<nathan@kernel.org>, <nicolas@fjasle.eu>, <peterz@infradead.org>,
	<jpoimboe@kernel.org>, <leitao@debian.org>, <petr.pavlu@suse.com>,
	<richard.weiyang@gmail.com>, <ruanjinjie@huawei.com>,
	<ndesaulniers@google.com>, <jgross@suse.com>
References: <20240422060556.1226848-1-liuyuntao12@huawei.com>
From: Alexander Lobakin <aleksander.lobakin@intel.com>
Content-Language: en-US
In-Reply-To: <20240422060556.1226848-1-liuyuntao12@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RTIzd2NaU2NPUGxqY01pV3pRM0c2Q09JVG9aOGo5SnJMOVRTUm9NTjlTS2tT?=
 =?utf-8?B?d2xvNDhVQmhFaXJ2SHAwWWxqb0RaUjhtU0tVTlMwL2F4Rm4wNkdvSVpMOTFu?=
 =?utf-8?B?SVFqUmplUjQ5SjV5K3RXVE05TEFYeU1zbXZoVENVZU5xZVNza2p0QVpFM0xz?=
 =?utf-8?B?TGJWTGo5Wmh1UnhEN1l6THUwUko3WUd3bEdiZlJmNmZYK3FtbVZEWDZRaVlG?=
 =?utf-8?B?T1JheXJmUjRub29mME40YXgyTW9RRFJKaUVxVTFqUmhZR3NVb0VyaTAwV05M?=
 =?utf-8?B?M2U4bTR3SVhBNWxjVWNlWlo4M0FYaWt3azNVRTNWcTFGMGh2STltcVFlRFBi?=
 =?utf-8?B?Y3pBRzhBYzk2RkFZb01rVDdRM0hqOFNFK3ltY2xXM2hTMTlQamNZNGxhaGJw?=
 =?utf-8?B?eHZXZ3hma3ROSzZSVTVDV0g3TnVQajJiZ0Vod1cveVhOYXQwdmI0UTRvOWhU?=
 =?utf-8?B?SlhuTlJmbytUQXlBTXVzcWhDc1VjNlF0TGJBYXF2MllYRGtKVWc5aDFuTWNK?=
 =?utf-8?B?aU5Ea2FnNHZuWkxQZUdMV01ob0hUOHFmaWNDenJ0aW9uQXpVdVZ5YmQrSGhZ?=
 =?utf-8?B?aVRGUi8wdlAxcWVnM0ZYUGF0SXBPZ1YvZVorV2h5RHBVKzdYRmxCYi93WG5w?=
 =?utf-8?B?UXBNdzMyTkVpcFVKclhOM3pCVkhKQ2dBMGk4RDFNUHpiMGVlbFZDcGZLanUv?=
 =?utf-8?B?dWx1Y3VISXhvV2x5Q1NGN21QdWNOd1ZweGpUVWtkZUNpYmxKdU43eWdtR3B3?=
 =?utf-8?B?MG5yYnN3ZmJjNkt3c3Q5RTBzRGQ0ajJwdW94UjhML01SWlFTNWdLVzJwb2FV?=
 =?utf-8?B?ZC8zL2l2WExRVUVpaXI3cjBBS2xKUSs1dGUzRE9vZDJJVmNlVG9wWFpTdVAr?=
 =?utf-8?B?RWRXeGR2WUIrUlo2V041WTBLRXlDOGxSNm1WTncxalo4aHFQTUl5TFlkUC9j?=
 =?utf-8?B?cUo5bHZHSUFqZDlPTzd3NGMrRmpYL1MxTHQ3Ni94QVlORTVmZm8zaFdydmM4?=
 =?utf-8?B?b29QMEVkUFdIM0ZJLzYySzJJM0pINlE4Zi9rSXdNSGlzRFh1RHdtMDFNekJT?=
 =?utf-8?B?azk3aG5hWWVWeEN1MW9SUTFpVVgwa0xvaWdWWTFZaWhYZjloYW4zZGR1Rk05?=
 =?utf-8?B?T2k0Tk94dVN0VmpuSUZWQ2psMm1SbThBRUoxTnBQbG5QcTFyY3JYeGk3TDBt?=
 =?utf-8?B?QmhHRS9vbVB0azRtaldNbzhMVnp6OThvMWVuS2RoVm1XTjhRVk9FcVVOdk8r?=
 =?utf-8?B?ektaNGVtaGhWMno3T3hVY1k1VnpiZzNuazFGci8zN1dDRmxObzRocmhKNmJw?=
 =?utf-8?B?VUsva05IaFVnQU8yWXFmL2U5WXVYWC9xV0ZRbjZEbEEraXNNK01FU2FBU2V3?=
 =?utf-8?B?eTd3Wjg5Wi9CVWgrWlhXN2J5bS9ReW1mSGRRckJJWm9zZTVwM0ozc1BxZEl4?=
 =?utf-8?B?a0pVYzAzSC8xOG94Y1JacVp0bUs1cWttcUliRUF0ZVdRUmNoakNLSXpRLzR2?=
 =?utf-8?B?SGtkMzFNOFR3R2h2YkpKeVFXRWNzNVd1eHlLUWhscnYvUEtaSUs4dEo5Y0t6?=
 =?utf-8?B?ZGV5REFsdmhTNm9kcHNCOGVocGpNTmdZUG0vUW43VXI5UDZrRXljejhuYTM2?=
 =?utf-8?B?WVlXWlFFL0F4S0Q3NHZUKzdCMzUxSzNjOHkwTndnNGNnNmUwekpkL2lKYnQx?=
 =?utf-8?B?clpmOUlXWXVBL2NPS0J2UnZsVkVwbkQyWEZlZnZqK2FtcDQ1bmpmTktmTWw2?=
 =?utf-8?B?Q21JaC9PNk5ZL0lvT291aFF0aHl3RmFJTm81VnlweFd1TlExVlhzSUF5NDh0?=
 =?utf-8?B?RnI4UnVnTmQ5K1gzY2wrbGZtR08vUGF2K3lwaUdvSnFGR2VTeGdrUmdQSXlw?=
 =?utf-8?B?N2FuaVZSYTNnTENwSityc1pIK2V2WkR0Q2NYYTdDV3hCTjFXNVBmOVo3QTZY?=
 =?utf-8?B?M253T1hFMTNSMnlpeURGV3FCVXFWVjZ6c0lQTm5VMmt4bUd4MkRVNFV0M2tm?=
 =?utf-8?B?Q1ZZVjhuUVBDeHhZR2c5cnhlc0pRcjAxaUZ2M0NZMngrNkVDV1dJQWx4L1VB?=
 =?utf-8?B?MlZPeWNoeEhkNXNEQ3pIWkZYM3ExVCtIV3NHY3h0R2EvRjduY3pKZnQ5Snlq?=
 =?utf-8?B?SDM2REU4VENERmF0cmVjVkpSaEZjWEVNNzc1QW1Hc1lGdm5mdm00TE90cnNZ?=
 =?utf-8?B?Z0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ec0a9944-201c-4ba0-f2e9-08dc644e996c
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB8718.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2024 11:06:32.5834
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7wkc7Ut3hNA7wLkZkYihAolpiL/X7vzvGy+LKxISkF8gsFCTgAuc4efS4UtNPLnQWf4DVXJMu3fYH6CoF1REktUMWxoPw6zsOT+QgsScjy4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR11MB8172
X-OriginatorOrg: intel.com

From: Yuntao Liu <liuyuntao12@huawei.com>
Date: Mon, 22 Apr 2024 06:05:56 +0000

> The current x86 architecture does not yet support the
> HAVE_LD_DEAD_CODE_DATA_ELIMINATION feature. x86 is widely used in
> embedded scenarios, and enabling this feature would be beneficial for
> reducing the size of the kernel image.
> 
> In order to make this work, we keep the necessary tables by annotating
> them with KEEP, also it requires further changes to linker script to KEEP
> some tables and wildcard compiler generated sections into the right place.
> 
> Enabling CONFIG_UNWINDER_ORC or CONFIG_MITIGATION_RETPOLINE will enable
> the objtool's --orc and --retpoline parameters, which will alter the
> layout of the binary file, thereby preventing gc-sections from functioning
> properly. Therefore, HAVE_LD_DEAD_CODE_DATA_ELIMINATION should only be
> selected when they are not enabled.

Dunno, I have DCE enabled for years on my home kernel, see commit [0]
with both ORC and retpolines enabled, and I didn't have any issues.
vmlinux still shrinks well, even with Clang LTO.

> 
> Enabling CONFIG_LTO_CLANG or CONFIG_X86_KERNEL_IBT will use vmlinux.o
> instead of performing the slow LTO link again. This can also prevent
> gc-sections from functioning properly. Therefore, using this optimization
> when CONFIG_LD_DEAD_CODE_DATA_ELIMINATION is not enabled.
> 
> The size comparison of zImage is as follows:
> x86_def_defconfig  i386_defconfig    tinyconfig
> 10892288           10826240          607232          no dce
> 10748928           10719744          529408          dce
> 1.3%               0.98%             12.8%           shrink
> 
> When using smaller config file, there is a significant reduction in the
> size of the zImage.

[0] https://github.com/solbjorn/linux/commit/25c4953ea73d

Thanks,
Olek