Received-SPF: pass (google.com: domain of linux-kernel+bounces-156796-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <c599baf5-5d10-4b17-b762-4f0f4a4ccfcc@amd.com>
Date: Wed, 24 Apr 2024 13:27:07 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 7/7] [RFT] arm64: zynqmp: Add PCIe phys
To: "Havalige, Thippeswamy" <thippeswamy.havalige@amd.com>,
 Sean Anderson <sean.anderson@linux.dev>,
 Lorenzo Pieralisi <lpieralisi@kernel.org>,
 =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= <kw@linux.com>,
 Rob Herring <robh@kernel.org>,
 "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
 "Gogada, Bharat Kumar" <bharat.kumar.gogada@amd.com>
Cc: "linux-arm-kernel@lists.infradead.org"
 <linux-arm-kernel@lists.infradead.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 Bjorn Helgaas <bhelgaas@google.com>
References: <20240422195904.3591683-1-sean.anderson@linux.dev>
 <20240422195904.3591683-8-sean.anderson@linux.dev>
 <6f7355f6-ae84-4246-83ad-3450e036b111@amd.com>
 <SN7PR12MB7201F77EEAF9134E790E09DA8B102@SN7PR12MB7201.namprd12.prod.outlook.com>
Content-Language: en-US
From: Michal Simek <michal.simek@amd.com>
Autocrypt: addr=michal.simek@amd.com; keydata=
 xsFNBFFuvDEBEAC9Amu3nk79+J+4xBOuM5XmDmljuukOc6mKB5bBYOa4SrWJZTjeGRf52VMc
 howHe8Y9nSbG92obZMqsdt+d/hmRu3fgwRYiiU97YJjUkCN5paHXyBb+3IdrLNGt8I7C9RMy
 svSoH4WcApYNqvB3rcMtJIna+HUhx8xOk+XCfyKJDnrSuKgx0Svj446qgM5fe7RyFOlGX/wF
 Ae63Hs0RkFo3I/+hLLJP6kwPnOEo3lkvzm3FMMy0D9VxT9e6Y3afe1UTQuhkg8PbABxhowzj
 SEnl0ICoqpBqqROV/w1fOlPrm4WSNlZJunYV4gTEustZf8j9FWncn3QzRhnQOSuzTPFbsbH5
 WVxwDvgHLRTmBuMw1sqvCc7CofjsD1XM9bP3HOBwCxKaTyOxbPJh3D4AdD1u+cF/lj9Fj255
 Es9aATHPvoDQmOzyyRNTQzupN8UtZ+/tB4mhgxWzorpbdItaSXWgdDPDtssJIC+d5+hskys8
 B3jbv86lyM+4jh2URpnL1gqOPwnaf1zm/7sqoN3r64cml94q68jfY4lNTwjA/SnaS1DE9XXa
 XQlkhHgjSLyRjjsMsz+2A4otRLrBbumEUtSMlPfhTi8xUsj9ZfPIUz3fji8vmxZG/Da6jx/c
 a0UQdFFCL4Ay/EMSoGbQouzhC69OQLWNH3rMQbBvrRbiMJbEZwARAQABzSlNaWNoYWwgU2lt
 ZWsgKEFNRCkgPG1pY2hhbC5zaW1la0BhbWQuY29tPsLBlAQTAQgAPgIbAwULCQgHAgYVCgkI
 CwIEFgIDAQIeAQIXgBYhBGc1DJv1zO6bU2Q1ajd8fyH+PR+RBQJkK9VOBQkWf4AXAAoJEDd8
 fyH+PR+ROzEP/1IFM7J4Y58SKuvdWDddIvc7JXcal5DpUtMdpuV+ZiHSOgBQRqvwH4CVBK7p
 ktDCWQAoWCg0KhdGyBjfyVVpm+Gw4DkZovcvMGUlvY5p5w8XxTE5Xx+cj/iDnj83+gy+0Oyz
 VFU9pew9rnT5YjSRFNOmL2dsorxoT1DWuasDUyitGy9iBegj7vtyAsvEObbGiFcKYSjvurkm
 MaJ/AwuJehZouKVfWPY/i4UNsDVbQP6iwO8jgPy3pwjt4ztZrl3qs1gV1F4Zrak1k6qoDP5h
 19Q5XBVtq4VSS4uLKjofVxrw0J+sHHeTNa3Qgk9nXJEvH2s2JpX82an7U6ccJSdNLYbogQAS
 BW60bxq6hWEY/afbT+tepEsXepa0y04NjFccFsbECQ4DA3cdA34sFGupUy5h5la/eEf3/8Kd
 BYcDd+aoxWliMVmL3DudM0Fuj9Hqt7JJAaA0Kt3pwJYwzecl/noK7kFhWiKcJULXEbi3Yf/Y
 pwCf691kBfrbbP9uDmgm4ZbWIT5WUptt3ziYOWx9SSvaZP5MExlXF4z+/KfZAeJBpZ95Gwm+
 FD8WKYjJChMtTfd1VjC4oyFLDUMTvYq77ABkPeKB/WmiAoqMbGx+xQWxW113wZikDy+6WoCS
 MPXfgMPWpkIUnvTIpF+m1Nyerqf71fiA1W8l0oFmtCF5oTMkzsFNBFFuvDEBEACXqiX5h4IA
 03fJOwh+82aQWeHVAEDpjDzK5hSSJZDE55KP8br1FZrgrjvQ9Ma7thSu1mbr+ydeIqoO1/iM
 fZA+DDPpvo6kscjep11bNhVa0JpHhwnMfHNTSHDMq9OXL9ZZpku/+OXtapISzIH336p4ZUUB
 5asad8Ux70g4gmI92eLWBzFFdlyR4g1Vis511Nn481lsDO9LZhKyWelbif7FKKv4p3FRPSbB
 vEgh71V3NDCPlJJoiHiYaS8IN3uasV/S1+cxVbwz2WcUEZCpeHcY2qsQAEqp4GM7PF2G6gtz
 IOBUMk7fjku1mzlx4zP7uj87LGJTOAxQUJ1HHlx3Li+xu2oF9Vv101/fsCmptAAUMo7KiJgP
 Lu8TsP1migoOoSbGUMR0jQpUcKF2L2jaNVS6updvNjbRmFojK2y6A/Bc6WAKhtdv8/e0/Zby
 iVA7/EN5phZ1GugMJxOLHJ1eqw7DQ5CHcSQ5bOx0Yjmhg4PT6pbW3mB1w+ClAnxhAbyMsfBn
 XxvvcjWIPnBVlB2Z0YH/gizMDdM0Sa/HIz+q7JR7XkGL4MYeAM15m6O7hkCJcoFV7LMzkNKk
 OiCZ3E0JYDsMXvmh3S4EVWAG+buA+9beElCmXDcXPI4PinMPqpwmLNcEhPVMQfvAYRqQp2fg
 1vTEyK58Ms+0a9L1k5MvvbFg9QARAQABwsF8BBgBCAAmAhsMFiEEZzUMm/XM7ptTZDVqN3x/
 If49H5EFAmQr1YsFCRZ/gFoACgkQN3x/If49H5H6BQ//TqDpfCh7Fa5v227mDISwU1VgOPFK
 eo/+4fF/KNtAtU/VYmBrwT/N6clBxjJYY1i60ekFfAEsCb+vAr1W9geYYpuA+lgR3/BOkHlJ
 eHf4Ez3D71GnqROIXsObFSFfZWGEgBtHBZ694hKwFmIVCg+lqeMV9nPQKlvfx2n+/lDkspGi
 epDwFUdfJLHOYxFZMQsFtKJX4fBiY85/U4X2xSp02DxQZj/N2lc9OFrKmFJHXJi9vQCkJdIj
 S6nuJlvWj/MZKud5QhlfZQsixT9wCeOa6Vgcd4vCzZuptx8gY9FDgb27RQxh/b1ZHalO1h3z
 kXyouA6Kf54Tv6ab7M/fhNqznnmSvWvQ4EWeh8gddpzHKk8ixw9INBWkGXzqSPOztlJbFiQ3
 YPi6o9Pw/IxdQJ9UZ8eCjvIMpXb4q9cZpRLT/BkD4ttpNxma1CUVljkF4DuGydxbQNvJFBK8
 ywyA0qgv+Mu+4r/Z2iQzoOgE1SymrNSDyC7u0RzmSnyqaQnZ3uj7OzRkq0fMmMbbrIvQYDS/
 y7RkYPOpmElF2pwWI/SXKOgMUgigedGCl1QRUio7iifBmXHkRrTgNT0PWQmeGsWTmfRit2+i
 l2dpB2lxha72cQ6MTEmL65HaoeANhtfO1se2R9dej57g+urO9V2v/UglZG1wsyaP/vOrgs+3
 3i3l5DA=
In-Reply-To: <SN7PR12MB7201F77EEAF9134E790E09DA8B102@SN7PR12MB7201.namprd12.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?b1lIM1Ryek1Kd1hHdWpjMFhQN0d6NjBMNEVJSXF5NDdOSHFPOHNUVE1yWlEz?=
 =?utf-8?B?ZmxSWVRDZmJPMjhzL3NTN0ZQZTZkTHN4S3JSQVlVUEJwanB3Qks3SG9xeC9p?=
 =?utf-8?B?YmdDODJ5M1Q3SlNWdno4VWZVRzg3dmZNVXgvWXRtOTFLcmI2S2ZTdjRKdk1q?=
 =?utf-8?B?aHJ5OS9wc2o3NU9BN1lsZWhHcWk4VU5DTUI4T2lVb3U3RUMzamJybWpmOWJz?=
 =?utf-8?B?ZzV2UmVxMDNGYno2ZkJUK1hKTytuamVhaUI2UERQbSs4QnBtemdCV3U2RGxh?=
 =?utf-8?B?K3FjK2VPOW9EWnR2RzNGVHJ6OFJvZWFzQ2JCdDBYN1hDWWVoYjhRU1lkMDMz?=
 =?utf-8?B?SmN3c25NZkZLbktRTmtVdHF1VXl3U0Q2TWE2UHJFSVNCOHNOY3JGMlY4cTE1?=
 =?utf-8?B?L1FhS3FYOUU1NG9NZVZIcnFCM3RBZEVUcC9BWlNBOHBhNFZXeldKS0toVnlG?=
 =?utf-8?B?RldUeW1SeWtEaWZ5NjBVS0FwTzBvRG5lODBPN2Y2bUoxcnRkcmpkOFN3Y2hG?=
 =?utf-8?B?R251eXg0NGtGRHlSL2VxaW51M1RjcnBTK1liNzZrZUlLamRWVXduMzFnMkhT?=
 =?utf-8?B?L0t4dlFZQTJsdnZ2WWdnbWczK1BRd015N3AyUXRRcGdzaHo4MGhOZjMzNDky?=
 =?utf-8?B?aWxYZDQ3RnZYVGRYTEYwOCs4NW9zalVITU9xN3FIcHhZTEFoZ3h1MU02Q1Ry?=
 =?utf-8?B?WjVqY3ZqR2pzRXh4VksySXVscXpGNmRXeDFFZmJaVzQ1VkFvbVBKeUN2eGky?=
 =?utf-8?B?UUxjT3M1eW94OU1JZDF2UTFqNnlySUFva1BwdCtVd2RmWkN1TTJCNExoU0pZ?=
 =?utf-8?B?NjhyYkNpK285NFVMQU1lTWpnTTZWaVRpb1JKL1NnSjBTZWZNNWQ5TXNyeDVG?=
 =?utf-8?B?Tkp6VnJwcEtiMXRzZ0YrZWJMU1M2SVJiNjN1ekJLNDkvTE5WQnNXT1c0Ulhn?=
 =?utf-8?B?amFQMzh6TjR3dGpvZWp0N0JPeTNpQ1lla2RjaEJFbTBVVURQQks5Sm96ejkx?=
 =?utf-8?B?UVpQVEpBSmYyT0dwbXF2NnJZQkVxc05ScVl0RFhXdmdHVHZzTXdKejF6QTFZ?=
 =?utf-8?B?aHltNVJIaFNsQTdQdm1UZG5BVUl2SUo0b2JWeVBuSkdRclU3azMxTDBkV2JE?=
 =?utf-8?B?OVZjcDVzV0JKWEpiTXF5R0pGN1NaUjdTZHMvU29PZm0vMndLV1UyaHVHVnBE?=
 =?utf-8?B?OFhQZFByd0hNdHRvenpIMjFiazlJTjdpbGtHaGkvRnU3S1o1U0pHVmdHK3Nl?=
 =?utf-8?B?QzNMa3JjVEpET2dYRUEyWk5jTmFKempzQXB3N0xDMEtyZFVkUHBicC9jM2lT?=
 =?utf-8?B?dFlJWXIrT3BOSkh2Q2liai9MRG84RzF1ODFXR1VHK2JPTjArYzN5cksxSjYy?=
 =?utf-8?B?b0t4T21Kb01UekdoWUdnS2tYeDF5OHVqR0VDZkNEZ2crREwrNEx4Z3htRWR6?=
 =?utf-8?B?OVhTZDBnTVNTZVJIZnU3MFprbUF0alI5STJ5NUJKQkl6bmhGM1pPa0E0Y3Br?=
 =?utf-8?B?ekErYkhmM0diVVZEOXBNV1ArQXFRbFhiVUg1R2txUlRWdWRlbEx4bldHOWRp?=
 =?utf-8?B?Q3o3RGxFNW0zemVZQkIrZTB6NHZWR0k0TG9NYmkwYitpbzRJZWg2QjRpUGI1?=
 =?utf-8?B?MzZrVDBEUi8wRnZwbEFTOWs5dlhxb00rK2d5MUpzSGlPOURIQXh3NGoybFRu?=
 =?utf-8?B?QVhrUzBZTmRieU5ZSmk1WkNRWWJZbkhST1FPRjBMY2EwNWd1Wm9UUXpHc3A5?=
 =?utf-8?B?R0s0RG9GcnRQc0lvRURGdlBXN3ZCZkRua2hnTjVmUWIvZGlRQ0FmRWxtTzR6?=
 =?utf-8?B?OGd5ekQ1Z3N1OGxZZ0FTeUN3WUNmQlVwVkNYSSt3Z1E5dVQ3cWUzOXo0eFlQ?=
 =?utf-8?B?eHZIcmhMNWk4cnkwdG1TR3MvdjdqSzRBMkVMSm8zc2ZBemVFTkhDMFVxOHFQ?=
 =?utf-8?B?SEdhZ1dMZnhxSW1LekRuaGV1Y1UwWXlERUkwUW5rSFhsNXI1YjdkY2VrYkJr?=
 =?utf-8?B?bjBvUVB5M0tqTHZWeTRlNzZJS1M3NXhOYmY1Z1cybmxmaWNUcE8rZGk0ZHgw?=
 =?utf-8?B?aTdjQ0tJelV0Q0FMSW04ZVErZEo5aFhiN2VCR1V2Y2xOZzZiTEpHZDMzR0Nx?=
 =?utf-8?Q?GxVfcEed+Y+K1jwEsOTfwvVAn?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 95ce7f46-84af-440e-dbd6-08dc645181e2
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8109.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2024 11:27:21.6809
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Zv+4C2qIm5fSOtMdCWoyGiQ2yjVPKd61l2zRxfqO5F0yPQXAJHlYrsIwJYW4a5/z
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9264


On 4/24/24 11:11, Havalige, Thippeswamy wrote:
> Hi Michal,
> 
>> -----Original Message-----
>> From: Simek, Michal <michal.simek@amd.com>
>> Sent: Tuesday, April 23, 2024 11:46 AM
>> To: Sean Anderson <sean.anderson@linux.dev>; Lorenzo Pieralisi
>> <lpieralisi@kernel.org>; Krzysztof Wilczyński <kw@linux.com>; Rob Herring
>> <robh@kernel.org>; linux-pci@vger.kernel.org; Gogada, Bharat Kumar
>> <bharat.kumar.gogada@amd.com>
>> Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Havalige,
>> Thippeswamy <thippeswamy.havalige@amd.com>; Bjorn Helgaas
>> <bhelgaas@google.com>
>> Subject: Re: [PATCH 7/7] [RFT] arm64: zynqmp: Add PCIe phys
>>
>> Hi Bharat,
>>
>> On 4/22/24 21:59, Sean Anderson wrote:
>>> Add PCIe phy bindings for the ZCU102.
>>>
>>> Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
>>> ---
>>> I don't have a ZCU102, so please test this.
>>>
>>>    arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts | 2 ++
>>>    1 file changed, 2 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
>> b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
>>> index ad8f23a0ec67..68fe53685351 100644
>>> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
>>> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
>>> @@ -941,6 +941,8 @@ conf-pull-none {
>>>
>>>    &pcie {
>>>    	status = "okay";
>>> +	phys = <&psgtr 0 PHY_TYPE_PCIE 0 0>;
>>> +	phy-names = "pcie-phy0";
>>>    };
>>>
>>>    &psgtr {
>>
>> Please review and test this series.
>>
>> Thanks,
>> Michal
> 
> Reviewed and tested the patch.

can you please provide proper Tested-by: line?

Thanks,
Michal