Received: by 2002:a89:48b:0:b0:1f5:f2ab:c469 with SMTP id a11csp373410lqd; Wed, 24 Apr 2024 05:17:48 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU7pf7099CqdzOTiRCIK5NQDZc/kx0YdQqewTcOoYw3fUC8UT87yMQND8SEElCoAzP8z10lG1u/X+AU7qI+PJb4aVgVWvwElZqBmKqT8A== X-Google-Smtp-Source: AGHT+IFnjRcsHg4l/wUNNQan1RCjF48H9xy2TU9czXI8T2AwqpoONKezlFrmJibu0X68WPr2bfL9 X-Received: by 2002:a25:c78c:0:b0:dcd:c3ba:d788 with SMTP id w134-20020a25c78c000000b00dcdc3bad788mr2116251ybe.47.1713961068236; Wed, 24 Apr 2024 05:17:48 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713961068; cv=pass; d=google.com; s=arc-20160816; b=IrG0RP860HeZjSu6smeunSMqtClOiRa7RLBFw903HlH0HJ5HGJK4q/H+teAGfW/yuA XuKoqu8ak4rW2upEhnBIWKBUpE5qjqB+9faI9VHeLZacDkBKnpkuAZAmHutWM9e+3xgb roeivHp7hHNMhzfbUfIm0/R/abJ81716+CyE3wlbbV30kh/zUhurcBDJQJQwXVLHxn0t LRVDtOATgnA7pE9WRHYVaviDFyq/+onJ3/sPEszrk7yMgPVc5cxO3f8JnsIrMMcd9EyX xINPfp/Ov8OJlhUHvf/Aguh9e1AzgWasyS7jyx7GiU9M1sHke8ueNfmGXUrxnfhQPwTt +Ftg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=K/R2dtfci+qBwoevaO60WUulbDhyWUkgaM2jw+XwiC0=; fh=vvTllZoW3odsFd/8lFDoQVtDIryqvmaisnRJG1gKm2I=; b=Ce4SmlemEl/3JvHa47bUYURNrllMlzJ1DOBV2zo6ZKFLiGqJTvQ3dYOrmxsjWN0ysm Glw6EmtamAEammTeoJz+6IzHx1lWo9YlwHV7nlwChHV2gWAqT+oY1OxDCFy6QStUHdq5 ttse5HzZONPQEHbN3YjSpOIscKrT59octGnDnjaVdp0dj+MEoOkufhKzC4ynI8bw+1BO y2ITQS/+TyBPeEPRvQZrW21KWFCRBKH449zVCnjOiP23j954CYV9WS+NNld+jLl0lWBH Yq0fECh3kFHyv4b0+f3Ovm3gyWbPw0VbqDr0W9i6YRaWxFj2yImrkbDSHHlq8c7Kac1l B54A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@fiberby.net header.s=202008 header.b=jFGpnxzp; arc=pass (i=1 spf=pass spfdomain=fiberby.net dkim=pass dkdomain=fiberby.net dmarc=pass fromdomain=fiberby.net); spf=pass (google.com: domain of linux-kernel+bounces-156847-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-156847-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=fiberby.net Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id j34-20020a056122092200b004daa94b5852si2701604vka.173.2024.04.24.05.17.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 05:17:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-156847-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@fiberby.net header.s=202008 header.b=jFGpnxzp; arc=pass (i=1 spf=pass spfdomain=fiberby.net dkim=pass dkdomain=fiberby.net dmarc=pass fromdomain=fiberby.net); spf=pass (google.com: domain of linux-kernel+bounces-156847-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-156847-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=fiberby.net Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E71BA1C23803 for ; Wed, 24 Apr 2024 12:17:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5264115B97A; Wed, 24 Apr 2024 12:16:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fiberby.net header.i=@fiberby.net header.b="jFGpnxzp" Received: from mail1.fiberby.net (mail1.fiberby.net [193.104.135.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D11C15ADA6; Wed, 24 Apr 2024 12:16:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.104.135.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713961015; cv=none; b=LmX507xOPLnbslKwVQSI+r8Nzbp2EQEcWFTVF1oX5/jcX3U7eRHdIkZjAbFYpmFkwSKJssiJWgrBz6MpTb6yC9zOvWGsUu9FyylJNIgZy/GuRclhjfenBnVXq/9rcOy0j3axQsAQRL7mWBhku3eWDfD9yFCQT2FdCD7/VHjQgzQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713961015; c=relaxed/simple; bh=uPBYsIyiiEFEvZqPZEpLvz84HGap+VSrek84RUNYIOM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=V2kb/sWz2LOwzfUBVDie/SwYu/CNf1mG2qkbfyBPjVaBYcrnBtNGmhK/IsDoxXInJYlOOAqVUDMLiGJbhGbhnoGdjKGzHdNUUhCJXElgOjTa8b4+9AV24EA6mDYR78/h41qKkmFhyiMPSjtte39l7Dnkh99nCHQQGEjx9odcRM0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fiberby.net; spf=pass smtp.mailfrom=fiberby.net; dkim=pass (2048-bit key) header.d=fiberby.net header.i=@fiberby.net header.b=jFGpnxzp; arc=none smtp.client-ip=193.104.135.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fiberby.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fiberby.net Received: from x201s (193-104-135-243.ip4.fiberby.net [193.104.135.243]) by mail1.fiberby.net (Postfix) with ESMTPSA id EF0FE600AF; Wed, 24 Apr 2024 12:16:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fiberby.net; s=202008; t=1713961004; bh=uPBYsIyiiEFEvZqPZEpLvz84HGap+VSrek84RUNYIOM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jFGpnxzpZ4ybBphl4wFEMJrlSed+bG0cdeadajBxD7ZBLhs7vLTKmMzGTdleRpfJU 1dRVxtIS4+A1mQO+Fnlz519CEDA4E2zcOn4Ya6y+VDiVtGYOkJBUyO2QN4itQbeYRp r2qgodXDyAO0zvjw3a/6JZyA31iaQjnGW4/yCK8rVADCXaa/mYEFHYKNC/PePVPtxr VxuBx2laNbvQ1AusJr9x7yeaJDEUOKtzZNvT8JvappY0Zv+ye1RCHoLAjV1N5iaPRx 0bwm7lEa86UqZNxkBspS6+Ctp9FGkdELK8jqwfNQjZA6Pyq3CzwDb40PTljIKNUbXD +7zRYMu/K/JvQ== Received: by x201s (Postfix, from userid 1000) id 7E77821BB45; Wed, 24 Apr 2024 12:16:36 +0000 (UTC) From: =?UTF-8?q?Asbj=C3=B8rn=20Sloth=20T=C3=B8nnesen?= To: netdev@vger.kernel.org Cc: =?UTF-8?q?Asbj=C3=B8rn=20Sloth=20T=C3=B8nnesen?= , Steen Hegelund , Lars Povlsen , Daniel Machon , UNGLinuxDriver@microchip.com, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org, Jiri Pirko , Simon Horman Subject: [PATCH net-next v2 2/4] net: sparx5: flower: add extack to sparx5_tc_flower_handler_control_usage() Date: Wed, 24 Apr 2024 12:16:23 +0000 Message-ID: <20240424121632.459022-3-ast@fiberby.net> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240424121632.459022-1-ast@fiberby.net> References: <20240424121632.459022-1-ast@fiberby.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Define extack locally, to reduce line lengths and aid future users. Only compile tested. Signed-off-by: Asbjørn Sloth Tønnesen --- drivers/net/ethernet/microchip/sparx5/sparx5_tc_flower.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_tc_flower.c b/drivers/net/ethernet/microchip/sparx5/sparx5_tc_flower.c index ca9e69d39439..d0dca65f8e76 100644 --- a/drivers/net/ethernet/microchip/sparx5/sparx5_tc_flower.c +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_tc_flower.c @@ -159,6 +159,7 @@ sparx5_tc_flower_handler_basic_usage(struct vcap_tc_flower_parse_usage *st) static int sparx5_tc_flower_handler_control_usage(struct vcap_tc_flower_parse_usage *st) { + struct netlink_ext_ack *extack = st->fco->common.extack; struct flow_match_control mt; u32 value, mask; int err = 0; @@ -178,7 +179,7 @@ sparx5_tc_flower_handler_control_usage(struct vcap_tc_flower_parse_usage *st) u8 vdt = sparx5_vcap_frag_map[is_frag_idx][first_frag_idx]; if (vdt == FRAG_INVAL) { - NL_SET_ERR_MSG_MOD(st->fco->common.extack, + NL_SET_ERR_MSG_MOD(extack, "Match on invalid fragment flag combination"); return -EINVAL; } @@ -199,7 +200,7 @@ sparx5_tc_flower_handler_control_usage(struct vcap_tc_flower_parse_usage *st) return err; out: - NL_SET_ERR_MSG_MOD(st->fco->common.extack, "ip_frag parse error"); + NL_SET_ERR_MSG_MOD(extack, "ip_frag parse error"); return err; } -- 2.43.0