Received-SPF: pass (google.com: domain of linux-kernel+bounces-156866-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <87c6e65dadbb3ed0c9b4506e809eb3976b12f204.camel@gmail.com>
Subject: Re: [PATCH] iio: dac: adi-axi: fix a mistake in
 axi_dac_ext_info_set()
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: Dan Carpenter <dan.carpenter@linaro.org>, Nuno Sa <nuno.sa@analog.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>, Michael Hennerich
	 <Michael.Hennerich@analog.com>, Jonathan Cameron <jic23@kernel.org>, 
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, 
	kernel-janitors@vger.kernel.org
Date: Wed, 24 Apr 2024 14:30:02 +0200
In-Reply-To: <df7c6e1b-b619-40c3-9881-838587ed15d4@moroto.mountain>
References: <df7c6e1b-b619-40c3-9881-838587ed15d4@moroto.mountain>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.0 
Precedence: bulk
MIME-Version: 1.0

Hi Dan,

On Wed, 2024-04-24 at 14:45 +0300, Dan Carpenter wrote:
> The last parameter of these axi_dac_(frequency|scale|phase)_set()
> functions is supposed to be true for TONE_2 and false for TONE_1. The
> bug is the last call where it passes "private - TONE_2".=C2=A0 That
> subtraction is going to be zero/false for TONE_2 and and -1/true for
> TONE_1.=C2=A0 Fix the bug, and re-write it as "private =3D=3D TONE_2" so =
it's
> more obvious what is happening.
>=20
> Fixes: 4e3949a192e4 ("iio: dac: add support for AXI DAC IP core")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> This is from code review.=C2=A0 Untested.
> ---

Auch, good catch! Agreed that private =3D=3D AXI_DAC_*_TONE_2 makes it more
readable.

I guess Jonathan may just squash this in the driver (was pushed this weeken=
d).
Anyways, FWIW:

Reviewed-by: Nuno Sa <nuno.sa@analog.com>

> =C2=A0drivers/iio/dac/adi-axi-dac.c | 6 +++---
> =C2=A01 file changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/iio/dac/adi-axi-dac.c b/drivers/iio/dac/adi-axi-dac.=
c
> index 9047c5aec0ff..880d83a014a1 100644
> --- a/drivers/iio/dac/adi-axi-dac.c
> +++ b/drivers/iio/dac/adi-axi-dac.c
> @@ -383,15 +383,15 @@ static int axi_dac_ext_info_set(struct iio_backend
> *back, uintptr_t private,
> =C2=A0	case AXI_DAC_FREQ_TONE_1:
> =C2=A0	case AXI_DAC_FREQ_TONE_2:
> =C2=A0		return axi_dac_frequency_set(st, chan, buf, len,
> -					=C2=A0=C2=A0=C2=A0=C2=A0 private - AXI_DAC_FREQ_TONE_1);
> +					=C2=A0=C2=A0=C2=A0=C2=A0 private =3D=3D AXI_DAC_FREQ_TONE_2);
> =C2=A0	case AXI_DAC_SCALE_TONE_1:
> =C2=A0	case AXI_DAC_SCALE_TONE_2:
> =C2=A0		return axi_dac_scale_set(st, chan, buf, len,
> -					 private - AXI_DAC_SCALE_TONE_1);
> +					 private =3D=3D AXI_DAC_SCALE_TONE_2);
> =C2=A0	case AXI_DAC_PHASE_TONE_1:
> =C2=A0	case AXI_DAC_PHASE_TONE_2:
> =C2=A0		return axi_dac_phase_set(st, chan, buf, len,
> -					 private - AXI_DAC_PHASE_TONE_2);
> +					 private =3D=3D AXI_DAC_PHASE_TONE_2);
> =C2=A0	default:
> =C2=A0		return -EOPNOTSUPP;
> =C2=A0	}