Received-SPF: pass (google.com: domain of linux-kernel+bounces-156893-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <1cb8bafb44075858221b31c056d75a40d7ba2ee1.camel@ew.tq-group.com>
Subject: Re: [PATCH net-next] net: phy: marvell: add support for MV88E6020
 internal PHYs
From: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>, Russell King
 <linux@armlinux.org.uk>,  "David S. Miller" <davem@davemloft.net>, Eric
 Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo
 Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org,  linux@ew.tq-group.com
Date: Wed, 24 Apr 2024 14:49:07 +0200
In-Reply-To: <19c4b8da-203e-4a81-9531-9ba4a4f750fd@lunn.ch>
References: <20240424121022.160920-1-matthias.schiffer@ew.tq-group.com>
	 <19c4b8da-203e-4a81-9531-9ba4a4f750fd@lunn.ch>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
Precedence: bulk
MIME-Version: 1.0

On Wed, 2024-04-24 at 14:42 +0200, Andrew Lunn wrote:
> On Wed, Apr 24, 2024 at 02:10:22PM +0200, Matthias Schiffer wrote:
> > The embedded PHYs of the MV88E6020 (88E6250 family) switch are very
> > basic - they do not even have an Extended Address / Page register.
> >=20
> > This adds support for the PHYs to the driver to set up PHY interrupts
> > and retrieve error stats. The ethtool stat functions are slightly
> > refactored to allow dealing with different marvell_hw_stat definitions.
> >=20
> > The same code should also work with other 88E6250 family switches
> > (6250/6220/6071/6070), but it is unclear whether these use the same PHY
> > ID - the spec only lists the prefix 0x01410c00 and describes the lower
> > 10 bits as reserved, but that seems too unspecific to be useful, as it
> > would cover several existing PHY IDs already supported by the driver.
>=20
> This sounds like:
>=20
> https://elixir.bootlin.com/linux/latest/source/drivers/net/dsa/mv88e6xxx/=
chip.c#L3642
>=20
> So the DSA driver will fill in the lower bits, and it should work for
> all devices in the family.
>=20
> > @@ -4072,6 +4134,7 @@ static struct mdio_device_id __maybe_unused marve=
ll_tbl[] =3D {
> >  	{ MARVELL_PHY_ID_88E1540, MARVELL_PHY_ID_MASK },
> >  	{ MARVELL_PHY_ID_88E1545, MARVELL_PHY_ID_MASK },
> >  	{ MARVELL_PHY_ID_88E3016, MARVELL_PHY_ID_MASK },
> > +	{ MARVELL_PHY_ID_88E6020, MARVELL_PHY_ID_MASK },
> >  	{ MARVELL_PHY_ID_88E6341_FAMILY, MARVELL_PHY_ID_MASK },
>=20
> Please follow the naming convention. MARVELL_PHY_ID_88E6250_FAMILY.
>=20
>        Andrew

We currently do not override the PHY ID for this family in the DSA driver -=
 my understanding was
that this is only necessary for switches that don't provide a usable PHY ID=
 at all. As I have no
idea if this PHY ID works for the whole family or just the single switch, I=
 went with the more
specific naming here.

Matthias


--=20
TQ-Systems GmbH | M=C3=BChlstra=C3=9Fe 2, Gut Delling | 82229 Seefeld, Germ=
any
Amtsgericht M=C3=BCnchen, HRB 105018
Gesch=C3=A4ftsf=C3=BChrer: Detlef Schneider, R=C3=BCdiger Stahl, Stefan Sch=
neider
https://www.tq-group.com/