Received-SPF: pass (google.com: domain of linux-kernel+bounces-156896-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 24 Apr 2024 14:50:52 +0200
From: Oscar Salvador <osalvador@suse.de>
To: Hariom Panthi <hariom1.p@samsung.com>
Cc: akpm@linux-foundation.org, urezki@gmail.com, hch@infradead.org,
	lstoakes@gmail.com, vbabka@suse.cz, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, r.thapliyal@samsung.com,
	Maninder Singh <maninder1.s@samsung.com>
Subject: Re: [PATCH 1/2] mm: page_owner: fixing wrong information in
 dump_page_owner
Message-ID: <ZikALBw17JePpWVh@localhost.localdomain>
References: <CGME20240424112123epcas5p46e76f51b8913661a6b740dcbbec83621@epcas5p4.samsung.com>
 <20240424111838.3782931-1-hariom1.p@samsung.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240424111838.3782931-1-hariom1.p@samsung.com>

On Wed, Apr 24, 2024 at 04:48:37PM +0530, Hariom Panthi wrote:
> From: Maninder Singh <maninder1.s@samsung.com>
> 
> with commit ea4b5b33bf8a ("mm,page_owner: update metadata for tail pages"),
> new API __update_page_owner_handle was introduced and arguemnt was passed
> in wrong order from __set_page_owner and thus page_owner is giving
> wrong data.
> 
> [   15.982420] page last allocated via order 0, migratetype Unmovable, gfp_mask 0xcc0(GFP_KERNEL), pid 80, tgid -1210279584 (insmod), ts 80, free_ts 0
> 
> Fixing the same.
> Correct output:
> [   14.556482] page last allocated via order 0, migratetype Unmovable, gfp_mask 0xcc0(GFP_KERNEL), pid 80, tgid 80 (insmod), ts 14552004992, free_ts 0
> 
> Fixes: ea4b5b33bf8a ("mm,page_owner: update metadata for tail pages")
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> Signed-off-by: Hariom Panthi <hariom1.p@samsung.com>

Acked-by: Oscar Salvador <osalvador@suse.de>

Thanks!

 

-- 
Oscar Salvador
SUSE Labs