Received-SPF: pass (google.com: domain of linux-kernel+bounces-156931-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 24 Apr 2024 09:09:43 -0400
From: Frank Li <Frank.li@nxp.com>
To: Joy Zou <joy.zou@nxp.com>
Cc: peng.fan@nxp.com, vkoul@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, imx@lists.linux.dev, dmaengine@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 1/2] dmaengine: fsl-edma: clean up unused
 "fsl,imx8qm-adma" compatible string
Message-ID: <ZikEl8Banvu9AyW6@lizhi-Precision-Tower-5810>
References: <20240424064508.1886764-1-joy.zou@nxp.com>
 <20240424064508.1886764-2-joy.zou@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240424064508.1886764-2-joy.zou@nxp.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?wItPSPCguoshyNhoubtJyeFAFraKJJ3OtIhZZ3K21/lPEdqLL/9ksEjzisKh?=
 =?us-ascii?Q?hPOeKBKgiOlO9l+Ia7EJW9irIGkOOpNIlLOoDGLShAY/7DCZIoSkURUaC+h0?=
 =?us-ascii?Q?kZR0YNAjyPPDl87MrsPhluYtkzhCJ6gnRgXoRDaLXwZgU9xRYsIRsGilp7tv?=
 =?us-ascii?Q?2aECc585YLXV23J+iQgpjC/6UqWvDMBHQ0mx3X1LLjrpoosbbABahHxyC3kY?=
 =?us-ascii?Q?pOTSucGXj1D9NQQpqk1Hdsoe6y7lFgJ3o/dtMwMQOo+ldc+rcWKLysyJ02GI?=
 =?us-ascii?Q?lrQEptOzYzA+e+XJCEKN1xu27zl0i4usC9tBTjhg8p2zB5WN8jDcipEYDJIc?=
 =?us-ascii?Q?yIt2hOEAyiB90t9HRlBATWhLX9umpyA0pw7kN1ze2+7+aNiLlhzLoxwRet91?=
 =?us-ascii?Q?HQG7ao7CmR5G5uAHXWuG3qS4msxXaA8CNYlYsgm5i3GtApCt977BfM6W67LU?=
 =?us-ascii?Q?H7+f6WA+8QzHwqsGj2IjNzcoxYFTbJfd9n0pwk413ahPax1DjcoEhoBPTM06?=
 =?us-ascii?Q?T9qnYhWTCl+XeuDauo/gtseoWJI/befppyx4E2pD4XlA9BnGaYcPPP+H+hGl?=
 =?us-ascii?Q?D+1g3rdSRs2bzk5SfjeP9A0+P+k+nlAyyxeydejxiSLXWcFmB5oYX34JrQjb?=
 =?us-ascii?Q?I+6KslA0rZlXWECIw3m3dxaQfa5sLP66NQQd+ZIyq56mKDEYQ1BmwrrJcryd?=
 =?us-ascii?Q?ZnOrtTUxeyi1TOk8p1AdjrWRWqvX9E1pMgUfa/6u+2gsWav5iBRu582ofhc0?=
 =?us-ascii?Q?drV/b/wpSGBxrCfP2yp0m3CCLFYYRh8rWoKtc75if6I54s+BoSafnNSGCkDw?=
 =?us-ascii?Q?Kc5a2HzgK26+ppTdA1o7Yy1vakPoWZq04Fd7FmRExT2M9zpW5TEPaxZpQncu?=
 =?us-ascii?Q?92JNnorDl5MCIO5HCnB3jKh23kz7o8QbKPTnFltr/qb4yOscBlP0gtH5guSi?=
 =?us-ascii?Q?z2pFBV/yb1mdgbTGTiOlpGzg9dGDOqvMPa8PF35k0H5vY+5QlBIrEbOfz3zt?=
 =?us-ascii?Q?CTuXzcTW5lOY94uBSUhOT0KWVbMSaqpNXgJW0Iz0kRDNohWrnva1REM02q3h?=
 =?us-ascii?Q?dBHcVNaAtpstQq5UgRSO6hgfiAiGlWAs3NepynhlB9/Uyll5gqi4d4CqY+av?=
 =?us-ascii?Q?NarfBwJ6DX3Fm1OlmwFMGyW4Tc7WDMEf17P/3RrT89dySQiWAJnRY7wzWCXb?=
 =?us-ascii?Q?yGhZzfTu/6fzOd8noEaiQZIUTCsOR7B+Xhc0G9Vx64I57/uOvI+dnqfH71Ox?=
 =?us-ascii?Q?MZ8fmSgKCNuf/dpOo/eg01d1R50JJeB3Kov2JkS/wNNvha2Ep37GD7TTrCDq?=
 =?us-ascii?Q?uHA7Gd+EMGXoy+FlhBcypN940NW8s7rJP8Ww/zWVJFjqF+QY9c/y8DMIzYFj?=
 =?us-ascii?Q?zhgZcbrOUVRc07VX9yOiD5LWpURzMaziYEwi2JHiTvPPyd37qY79mW+zUHwz?=
 =?us-ascii?Q?7X5Ukn9vCtVKo3fwRi39rzjyVyL3Ltpt/b23fS3iC4N4waObjyEkYnmrOZuS?=
 =?us-ascii?Q?IRp1aHsNPf2KB3b4fXP0Pw01Iz3u+Erv8VHjDlKHpd79waWpW8HDxGSmSGKl?=
 =?us-ascii?Q?PPA2xUoBq4jhFsFe+44=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f8b3283c-fced-45a1-c91e-08dc645fd333
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2024 13:09:50.9295
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dDej25MftCkfmWdNypyH9OxLYi5HeWxgDH+XN4Hy21P5i1WPuhRwlF18ZXeq9SJ6QREgSENCOGnryleCO9r0fw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7297

On Wed, Apr 24, 2024 at 02:45:07PM +0800, Joy Zou wrote:
> The eDMA hardware issue only exist imx8QM A0. A0 never mass production.
> So remove the workaround safely.
> 
> Signed-off-by: Joy Zou <joy.zou@nxp.com>

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> ---
> Changes for v5:
> 1.remove FSL_EDMA_DRV_QUIRK_SWAPPED in fsl-edma-common.h
> 
> Changes for v4:
> 1.change the subject to keep consistent with the patchset.
> 
> Changes for v2:
> 1. Change the subject.
> ---
>  drivers/dma/fsl-edma-common.c | 16 ++++------------
>  drivers/dma/fsl-edma-common.h |  2 --
>  drivers/dma/fsl-edma-main.c   |  8 --------
>  3 files changed, 4 insertions(+), 22 deletions(-)
> 
> diff --git a/drivers/dma/fsl-edma-common.c b/drivers/dma/fsl-edma-common.c
> index f9144b015439..ed93e01282d5 100644
> --- a/drivers/dma/fsl-edma-common.c
> +++ b/drivers/dma/fsl-edma-common.c
> @@ -75,18 +75,10 @@ static void fsl_edma3_enable_request(struct fsl_edma_chan *fsl_chan)
>  
>  	flags = fsl_edma_drvflags(fsl_chan);
>  	val = edma_readl_chreg(fsl_chan, ch_sbr);
> -	/* Remote/local swapped wrongly on iMX8 QM Audio edma */
> -	if (flags & FSL_EDMA_DRV_QUIRK_SWAPPED) {
> -		if (!fsl_chan->is_rxchan)
> -			val |= EDMA_V3_CH_SBR_RD;
> -		else
> -			val |= EDMA_V3_CH_SBR_WR;
> -	} else {
> -		if (fsl_chan->is_rxchan)
> -			val |= EDMA_V3_CH_SBR_RD;
> -		else
> -			val |= EDMA_V3_CH_SBR_WR;
> -	}
> +	if (fsl_chan->is_rxchan)
> +		val |= EDMA_V3_CH_SBR_RD;
> +	else
> +		val |= EDMA_V3_CH_SBR_WR;
>  
>  	if (fsl_chan->is_remote)
>  		val &= ~(EDMA_V3_CH_SBR_RD | EDMA_V3_CH_SBR_WR);
> diff --git a/drivers/dma/fsl-edma-common.h b/drivers/dma/fsl-edma-common.h
> index 01157912bfd5..3f93ebb890b3 100644
> --- a/drivers/dma/fsl-edma-common.h
> +++ b/drivers/dma/fsl-edma-common.h
> @@ -194,8 +194,6 @@ struct fsl_edma_desc {
>  #define FSL_EDMA_DRV_HAS_PD		BIT(5)
>  #define FSL_EDMA_DRV_HAS_CHCLK		BIT(6)
>  #define FSL_EDMA_DRV_HAS_CHMUX		BIT(7)
> -/* imx8 QM audio edma remote local swapped */
> -#define FSL_EDMA_DRV_QUIRK_SWAPPED	BIT(8)
>  /* control and status register is in tcd address space, edma3 reg layout */
>  #define FSL_EDMA_DRV_SPLIT_REG		BIT(9)
>  #define FSL_EDMA_DRV_BUS_8BYTE		BIT(10)
> diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c
> index 755a3dc3b0a7..b06fa147d6ba 100644
> --- a/drivers/dma/fsl-edma-main.c
> +++ b/drivers/dma/fsl-edma-main.c
> @@ -349,13 +349,6 @@ static struct fsl_edma_drvdata imx8qm_data = {
>  	.setup_irq = fsl_edma3_irq_init,
>  };
>  
> -static struct fsl_edma_drvdata imx8qm_audio_data = {
> -	.flags = FSL_EDMA_DRV_QUIRK_SWAPPED | FSL_EDMA_DRV_HAS_PD | FSL_EDMA_DRV_EDMA3,
> -	.chreg_space_sz = 0x10000,
> -	.chreg_off = 0x10000,
> -	.setup_irq = fsl_edma3_irq_init,
> -};
> -
>  static struct fsl_edma_drvdata imx8ulp_data = {
>  	.flags = FSL_EDMA_DRV_HAS_CHMUX | FSL_EDMA_DRV_HAS_CHCLK | FSL_EDMA_DRV_HAS_DMACLK |
>  		 FSL_EDMA_DRV_EDMA3,
> @@ -397,7 +390,6 @@ static const struct of_device_id fsl_edma_dt_ids[] = {
>  	{ .compatible = "fsl,ls1028a-edma", .data = &ls1028a_data},
>  	{ .compatible = "fsl,imx7ulp-edma", .data = &imx7ulp_data},
>  	{ .compatible = "fsl,imx8qm-edma", .data = &imx8qm_data},
> -	{ .compatible = "fsl,imx8qm-adma", .data = &imx8qm_audio_data},
>  	{ .compatible = "fsl,imx8ulp-edma", .data = &imx8ulp_data},
>  	{ .compatible = "fsl,imx93-edma3", .data = &imx93_data3},
>  	{ .compatible = "fsl,imx93-edma4", .data = &imx93_data4},
> -- 
> 2.37.1
>