Received-SPF: pass (google.com: domain of linux-kernel+bounces-156934-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <bbc315ed-3482-4abb-b3f6-88c335dcf9d2@amd.com>
Date: Wed, 24 Apr 2024 15:11:08 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] drm/amd/display: re-indent dc_power_down_on_boot()
To: Dan Carpenter <dan.carpenter@linaro.org>,
 Harry Wentland <harry.wentland@amd.com>, Charlene Liu <charlene.liu@amd.com>
Cc: Leo Li <sunpeng.li@amd.com>, Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
 Alex Deucher <alexander.deucher@amd.com>, "Pan, Xinhui"
 <Xinhui.Pan@amd.com>, David Airlie <airlied@gmail.com>,
 Daniel Vetter <daniel@ffwll.ch>, Alvin Lee <alvin.lee2@amd.com>,
 Wenjing Liu <wenjing.liu@amd.com>, Jun Lei <jun.lei@amd.com>,
 Tom Chung <chiahsuan.chung@amd.com>, Dillon Varone <dillon.varone@amd.com>,
 amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
 linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
References: <e5f538ab-ebc8-400b-8104-4642b8089b4f@moroto.mountain>
Content-Language: en-US
From: =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
In-Reply-To: <e5f538ab-ebc8-400b-8104-4642b8089b4f@moroto.mountain>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bzhVc2dSLzNsck5RWnN5QnJ6UGF5ZGhDM2s2TXhiRVBMZXhubzNma2VJb0RT?=
 =?utf-8?B?RU9HMm9OTVVKM1pQNUNJMnkyYXRnM3pIdWVHWFZDOEpOSmU4RnI2Mi9MWGd2?=
 =?utf-8?B?MGVXWjV2dkdrbmZLR2NnMU1CbE01cllSZkFiR0ZBWm9mY0k4OU1MaG5rdWxr?=
 =?utf-8?B?OVdDMUZXbnExOVFPeDhNQjM5NkRaekJyRXBvWnVEZ1lnd1FXRWNjZGx5Y2hy?=
 =?utf-8?B?TGJCMlo2QWsvMldoT1I2QmRhV2RlR1VyV3E1MUptcW5mM2hxU0xlbERtZWg5?=
 =?utf-8?B?Q0pCa0Y0V1Z6eURpTEJtd2ZkNjFFS0NGdVdxaWNCcXlUMGN4RDVMMkRDWGlH?=
 =?utf-8?B?UVg3K2xhT0s0eTNDTzVVMGhqY0VocVptR0RQSXdtY3U0cmxRU2FDaXR4L1ZW?=
 =?utf-8?B?RmZFTzVpc2tTenRvWjFXM3N6d3ZCVW00RHFWc2l0ZkV5Kzg5QlhaYUtUU3VC?=
 =?utf-8?B?UkxScG5qTDluaFhOMSsrNndvdG93MW5LanJ6S09wZnBRa0h2QVI3SjYrVjlO?=
 =?utf-8?B?SDVZQjI3MUd1eVJDeUNjMG5LakI2SzRlL1duV0ZyK0tYV05KSkR5RmNFTXVm?=
 =?utf-8?B?VzVWNnVRN2xZVWZuTzRPV0g3bEVlaTFKay80Sk9uaGJISTgrMXpVdHYxT1lM?=
 =?utf-8?B?Nm9wd2c4VDh4UXI2WldSOHhYdjExeklvY0hIU2dJRDNvc3VUZjFHUjNMQWZF?=
 =?utf-8?B?d0RqRjJ1Z0xzNER2ZGRyTWw4ajVSWG1xY3c5WDNUSVlzSUdtRDBleEVNVDE3?=
 =?utf-8?B?UzNYeGFuQnRCMituVEpTamFnY3J2c05vbnZBYUxDeWtQTnpOL1NHYktZa3Y5?=
 =?utf-8?B?djE3aWdUdUZ4azlXSmUvTXJjK1RiMDZMaFBOdy84aDY0UHd6Ym8wUnRiN2Vi?=
 =?utf-8?B?R2JDcDZNT1R1UHBiOWwzRmdKaEl0OVNNKytGbWRYNVFtL1I0UFJNWFo5ekJ1?=
 =?utf-8?B?NkhkU3k4MndOL0tJdzY4QmVpdDlBOHRtMkFhRGhwT1BVMG5PQlA3L2FhVDFO?=
 =?utf-8?B?ckxWMlRZS2g2TktDSm9YZmx0VUJ0c2pzVm1FRm1PZzhsaWJyRFUySEJmZnVL?=
 =?utf-8?B?NkJZVmlFa1E5T0c1bDcrS0VtUXlWOG5KdXJ4RHA2REgzTXFBKzUzdkJwNGZE?=
 =?utf-8?B?Si9TWnVRRUZSWS81MGdDQVRqeVhYd1NKT0N6Q0o1TWJiV0RvMDlvaDRXRGxm?=
 =?utf-8?B?M2ltSUExYWpYMC9aUWo4US9KVEYvbnc0QVFjTVFqUGZNbW1tZ0ZsSW1KbWV4?=
 =?utf-8?B?V3l0bHVyR2lOckNQTFY1KytleTdUQ285RU1rc1RqLzdBOG9GaUJjamxhemNV?=
 =?utf-8?B?WTZnN3dwRXdTbzU0V1pORUZPNGlIV3VaUmY3bmxCRnpDTTZmL2MrRnA4YVNM?=
 =?utf-8?B?dzRCWXlkZEsxd2NCWVAvWFJNS1ZFejFwL3gxcFhRU3VYcGI1VmN2VHVZSko4?=
 =?utf-8?B?UmYvS2NCZGNFcU00a2Q5SlRVZERvbEI4YmNzZ3VIa3crK1l6eWd3cXBtSUwr?=
 =?utf-8?B?YmFIRjhIMng2MU42dEl3V3VaKzhqaGg0bFpNUnNLSUtQTC94WVorY0FiVGcz?=
 =?utf-8?B?L1dyQ3c2OC9TTHMrNkIva0dqdTJhMDA1bDNYRWQ0Mjg0bkM3ZFc2U0EydEpr?=
 =?utf-8?B?d0pGWTlib21mOTkxKzVWcWNJaUFvZmpwckZMMFlRdDR3TVpCVTU0TSttejVD?=
 =?utf-8?B?ZG8ycFp5QVk1NG4xSmxCMDlscVpxcnRPUUpnc1ZvMkY0M0djYjNXV0drSjlF?=
 =?utf-8?B?RlBWZTVldkJBVGJaaUxiTjJxSDkrMzJIbVRjTHRlcmRDNVQrSmpSMnRTY1FO?=
 =?utf-8?B?d3RWclNIOGFwMG4vL0pzK3NXaWsreXZCRHpmSlpJY09kVHpxd2dBUDRlWlFW?=
 =?utf-8?B?OG5CMkk3TlgxSnc0bU54V3dSV2JjRmx6NDhua2xIQXRDSmcxNzhqancxZFNL?=
 =?utf-8?B?M01hQUZraXNnUzJrU1NWS0E4Y2xuMHl5djZFTk0wYTFSOUpBbkRlWHUxM0lo?=
 =?utf-8?B?NWR0RHBTS2k1cHgxdEVtM1htZ2FSMEVVT2FIcmZWY1VyV0EvUG8zaEhaRUFF?=
 =?utf-8?B?N1B0b1Z2NDNjdnRCakxtL1hYTmY2WWJYVU5maDdoMTR2SU1KQzFjZktkNVFF?=
 =?utf-8?Q?AhOXwG4MfSG3qWf7YLg4tbY3k?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a7e155d2-4f33-4b9f-a2fc-08dc6460084d
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5685.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2024 13:11:20.2898
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WhZcmhjeyCyDGfawcLoMRwzXFBpBGi/oxGSawFsusTJizgWW3Df6dSci25/3cH6M
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4088

Am 24.04.24 um 13:41 schrieb Dan Carpenter:
> These lines are indented too far.  Clean the whitespace.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
>   drivers/gpu/drm/amd/display/dc/core/dc.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index 8eefba757da4..f64d7229eb6c 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -5043,11 +5043,10 @@ void dc_interrupt_ack(struct dc *dc, enum dc_irq_source src)
>   void dc_power_down_on_boot(struct dc *dc)
>   {
>   	if (dc->ctx->dce_environment != DCE_ENV_VIRTUAL_HW &&
> -			dc->hwss.power_down_on_boot) {
> -
> -			if (dc->caps.ips_support)
> -				dc_exit_ips_for_hw_access(dc);
> +	    dc->hwss.power_down_on_boot) {
>   
> +		if (dc->caps.ips_support)
> +			dc_exit_ips_for_hw_access(dc);

Well while at it can't the two ifs be merged here?

(I don't know this code to well, but it looks like it).

Regards,
Christian.

>   		dc->hwss.power_down_on_boot(dc);
>   	}
>   }