Received-SPF: pass (google.com: domain of linux-kernel+bounces-156978-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <f3b0e0fe-edb9-420d-b4a1-71c267246875@amd.com>
Date: Wed, 24 Apr 2024 15:33:11 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] drm/amd/display: re-indent dc_power_down_on_boot()
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Harry Wentland <harry.wentland@amd.com>,
 Charlene Liu <charlene.liu@amd.com>, Leo Li <sunpeng.li@amd.com>,
 Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
 Alex Deucher <alexander.deucher@amd.com>, "Pan, Xinhui"
 <Xinhui.Pan@amd.com>, David Airlie <airlied@gmail.com>,
 Daniel Vetter <daniel@ffwll.ch>, Alvin Lee <alvin.lee2@amd.com>,
 Wenjing Liu <wenjing.liu@amd.com>, Jun Lei <jun.lei@amd.com>,
 Tom Chung <chiahsuan.chung@amd.com>, Dillon Varone <dillon.varone@amd.com>,
 amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
 linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
References: <e5f538ab-ebc8-400b-8104-4642b8089b4f@moroto.mountain>
 <bbc315ed-3482-4abb-b3f6-88c335dcf9d2@amd.com>
 <4a996c51-e101-47a0-8a89-78c6f9f01e0f@moroto.mountain>
Content-Language: en-US
From: =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
In-Reply-To: <4a996c51-e101-47a0-8a89-78c6f9f01e0f@moroto.mountain>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VnNnUEd3T2t6RXFrckhCc3NlSGNlaDB1TmwrbG4xTHBjcm0wQURNZkNNTmVX?=
 =?utf-8?B?MmdzaUk5aVlvTHZibkM3MVF6TS9wMkxBNjU4Q1p3MG9IV3NVeDZ3ZVpUS0c0?=
 =?utf-8?B?VFpES0VvbE9hdXpUcThJcXNQcnlQeVJRVkdiK09GUFdSLzdPS0svYm1EVUFp?=
 =?utf-8?B?a2dxTmhJZUxyT21tS013YWVXS0VGb3Nub0RFSVZXM1Z4My84cHloYVJCTWd1?=
 =?utf-8?B?b1dFMFZ5MERQenBKSzBmcXY5YWJQVWpwM2lVMG1lQ1p2MG92bER5Q0FSamtr?=
 =?utf-8?B?bkpuMHY5czdOdU93VkZYd2h5UXFwOWFkMWhYKzYrN0ZjL3ZjQmw3cXJFbnQx?=
 =?utf-8?B?ZHoyV3JnZ0gxbWJyKzlkOCtzaXBQd3NORWduQnhBeU82UjRRaFJWSFliQVNE?=
 =?utf-8?B?dTc2QU5RamNLU0ZxaFB2QXJBbktVRVN2MzVvNXozUDRlZWhjV3RLNmJlTGpX?=
 =?utf-8?B?dnB6SUwzc3Rad0FVVnBLblZ2emhnTFBEY3d6Wk8wZnN6ek9LOEpqZzQ4ZVpE?=
 =?utf-8?B?b1BpTkxVQkN0bHJaUTEwKzB3dkhaRjJhaHdGV3U4dndRMUFoemNTYjk3QTc1?=
 =?utf-8?B?OC9mVDBIajN5dmtFT1lCbHJ4VDJqNjJqSkJJSEdnV0pIM0xtUkdwYlBIeHJR?=
 =?utf-8?B?NlRLa0VVdmx0TnNyYkNFeWNRWHcvMHRKUHM0RnIvVFlyaHRpQ2lBOVBnenMw?=
 =?utf-8?B?dE1vQThTbWFVLzBrUktHRFpZTStpZ2ZSTkZwU2Y0MWF4RDVaUDE4VnRnZ1JO?=
 =?utf-8?B?dWdVMTZPdG5WNXJYTXBGaVpyS2Y1d0RXYmlQak1abnJsMEFEVWYxVWtJOTBx?=
 =?utf-8?B?WFQvMVViMmJyWVVDRUpvVnVrRUNiN09PU3BzNHJDTDNsOUxSK0I4TXZCS2Vq?=
 =?utf-8?B?b2tCTExWKzBLLzJQMDhlc3FoMVl3ZHhaYS9mWlJVWmlzVUt3VFdjd1dOU21a?=
 =?utf-8?B?cHEybW5Cb2tWMnJFc2xrTzVQa2dhL1NZNTczVWhTUFZhdnlVK0pBWmVMVkJY?=
 =?utf-8?B?L0xpVElPZWduRzdhVjZsOElmRGwyb1d4VGp0N3FOdWZ4Vy9qN2xjcVdjMVhJ?=
 =?utf-8?B?cmxxdkdaNElBLzMySUVKN0ZnSy92K3I5WnRpTlAzUjJ1ZmJwWHQrejRsQUlC?=
 =?utf-8?B?eWJVeWhFbEpma2dyN0lGZ09RMlVkQklPdHVUQkxjQlpiUjBwYnkwOUlMM1N5?=
 =?utf-8?B?ODJYV29qNW9BamMzWDhROVpyZmFuMjQ5bW5HMWdyMUpiVDdEUnNhY1g1TCt6?=
 =?utf-8?B?RjJ6bFhacm5Tb1FaVGhwWmFXUjJnQk5jS1pSa3VERFliQXVlWGhnOE9UQ2gr?=
 =?utf-8?B?MldEaFExMjQ0L3pHTkRraUw1Q1hJcHVHQkJyZDNmOGJzSXVzdXlJdnJHKzBZ?=
 =?utf-8?B?SkQ0UVVPUk1IV1JNbFlyZ3NDSjVOVHU3aUtNV2diVUxOaVQvUW81RXk2d3hm?=
 =?utf-8?B?MHF3cXp3eUw2RFR4bEtIOFZIQjVXZUNtcVh2TFA5dEQ3TTlDdVpIaUx1MDVN?=
 =?utf-8?B?Nnoyam0vUnBKaXMvb00yM05aYzVpMDJmSlgxRFp0RHpkSzNnSWlOUUFUS1BL?=
 =?utf-8?B?ZE02WXZjSWNXZ3BMZzNIeENvdXE1SmVvczZ3TG1xV29ydzB4cUFiVVl3TjF2?=
 =?utf-8?B?Q0lNQSsrb1FqYU1GdGRMSC8yU1YxTjFOQmV0bUM0aVJUNEtGbHlyRCt0Sjcy?=
 =?utf-8?B?NURFa3puR1V6NGhMSC81N2RHbDJ1VDRHdmVzS28renNUWkV2dWhwV1RlR3lB?=
 =?utf-8?B?aTVFeGovamY5R1MycXVyOWVjTXJRNGVWalgxR1hNVE1mZDJRTk9KaGdNcDUy?=
 =?utf-8?B?YU5WcjRKQzg2TjJnZnJGbjZGNFhpbnloMVlTTFJtRmRsVS9qQ2JRVW91SDBC?=
 =?utf-8?B?L1BTYVdVTUxxMXNnNER4dXdlMXBad0VJUFFVN3I0NFFLZUQ2MnFweUU2UU1P?=
 =?utf-8?B?QVJ0d0NaN1BYVG91QzVNRmkrZVl5Zzc3V1VzSW16OU1JRHdnNmlUK004QTg4?=
 =?utf-8?B?WFUzbCtMOXNMeEVpM0w0T0Nic2ZkbFNhWm9JbTAzcUs3UzU2UndCRDEvajVw?=
 =?utf-8?B?WFRFZzU1NlJhekgxOCtrbjVoTFNnRElocGZ0QTZxM1BnUnc2QXoyMHM1QjY2?=
 =?utf-8?Q?ccn/aRsP3C53df8qBQI2X+WGr?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 19a0b861-a2c5-487d-333e-08dc64631aed
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5685.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2024 13:33:19.8931
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 164E+vTknOb6sfnLCSFRYaqT/SEr8kw12LXKq2VlL6byiTWOTZF9ghbYXA5qW2A5
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7379

Am 24.04.24 um 15:20 schrieb Dan Carpenter:
> On Wed, Apr 24, 2024 at 03:11:08PM +0200, Christian König wrote:
>> Am 24.04.24 um 13:41 schrieb Dan Carpenter:
>>> These lines are indented too far.  Clean the whitespace.
>>>
>>> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
>>> ---
>>>    drivers/gpu/drm/amd/display/dc/core/dc.c | 7 +++----
>>>    1 file changed, 3 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
>>> index 8eefba757da4..f64d7229eb6c 100644
>>> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
>>> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
>>> @@ -5043,11 +5043,10 @@ void dc_interrupt_ack(struct dc *dc, enum dc_irq_source src)
>>>    void dc_power_down_on_boot(struct dc *dc)
>>>    {
>>>    	if (dc->ctx->dce_environment != DCE_ENV_VIRTUAL_HW &&
>>> -			dc->hwss.power_down_on_boot) {
>>> -
>>> -			if (dc->caps.ips_support)
>>> -				dc_exit_ips_for_hw_access(dc);
>>> +	    dc->hwss.power_down_on_boot) {
>>> +		if (dc->caps.ips_support)
>>> +			dc_exit_ips_for_hw_access(dc);
>> Well while at it can't the two ifs be merged here?
>>
>> (I don't know this code to well, but it looks like it).
>>
> I'm sorry, I don't see what you're saying.

The indentation was so messed up that I though the call to 
power_down_on_boot() was after both ifs, but it is still inside the first.

So your patch is actually right, sorry for the noise.

Regards,
Christian.

>
> I probably should have deleted the other blank line as well, though.
> It introduces a checkpatch.pl --strict warning.
>
> regards,
> dan carpenter
>