Received: by 2002:a89:48b:0:b0:1f5:f2ab:c469 with SMTP id a11csp424863lqd; Wed, 24 Apr 2024 06:41:56 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXMLhGoXs0ur41NTFahgMN2vfvtdRhHi+qtLkQC+B+5iTPLTn/V/cXMbFEKO7D+HwiPzUBWF4qqvBMm94x5PH3JShZA1QWgfVHuuH63jQ== X-Google-Smtp-Source: AGHT+IHdHrIdMIn5qgsq8MmgLDO8AQUFprN5nivnAhze13jnh8SNsg55sjjmGw/v8imq0d3lw+YW X-Received: by 2002:a05:6870:1044:b0:22e:98df:9a2 with SMTP id 4-20020a056870104400b0022e98df09a2mr2065836oaj.8.1713966115760; Wed, 24 Apr 2024 06:41:55 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713966115; cv=pass; d=google.com; s=arc-20160816; b=aBtFSNC3wXCpJVeNMB3o+CuWhZgkZLC5RkYVp8yxbONpFtq26dTEAUsG5Odf3HwZrl vcTsflX5Iol4kSH+ZYdaBba1JWZMvNSjuZaRZodU8cyIw+0WYNjuLKr/nqeUZ2Iv2yy9 tYC3IlzMOg6dCs2Bj2Yo3l4S1iUgA14i3kmfCjXK8wjJMrRdro/CX6iL+dViKeSLiUT1 p94ciCywpzG/hiL3FTBtXtivBc5OqMYzIdojGRwyPqHlOFeAo0APzwcJZHvNILHvUMsA dYuAwamSWzwhKPpaG6c8XJnBOFuIaCU+ucYNgjMTiHy8RkrutBElBe2rldDqgIWtpduh /30w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=q6aITZTXQCTUVUwLcR6U98fZZ2o8vgsLlCbL7AYXoHw=; fh=SRCieMxsm9eMgT7u+2qaBOewrm2MFo2j/fFUR/ymlA0=; b=tz0FNv9CbugYExI1OiEhmEZwp/uGpkFLdtHQQkxjY9xFLW2I19S5+y59xotRxtqNDr MH6kTEe7mTyiCFvXD6Jmc+fnpDIZTw8i1o3sYiEWPh7IQNUNGCbZzfXyxaaN3oDrjUyM 8CKU24QJZqhtfhFeDyR61ZCEADHtRrdX31EzkOuFhVjtwOeH/rajPqamXt/jYoui6ykT 5earfRAkGrSs5af0WQC26qWhOws7MjNSbiVZ17EWTBUGvFqueqPNeXP6dIgvlDVRolHb TikiruvtKLZK6Fe45GKHw3lHbHjCtN7lDqvTOqdY2d5mKQBXJypSf1WmQkkE14s4GTUK c8hg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=2VwaBiS0; arc=pass (i=1 spf=pass spfdomain=microchip.com dkim=pass dkdomain=microchip.com dmarc=pass fromdomain=microchip.com); spf=pass (google.com: domain of linux-kernel+bounces-156990-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-156990-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microchip.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id o190-20020a6341c7000000b005f07f352951si11137640pga.356.2024.04.24.06.41.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 06:41:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-156990-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=2VwaBiS0; arc=pass (i=1 spf=pass spfdomain=microchip.com dkim=pass dkdomain=microchip.com dmarc=pass fromdomain=microchip.com); spf=pass (google.com: domain of linux-kernel+bounces-156990-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-156990-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microchip.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 5CDE5283FE8 for ; Wed, 24 Apr 2024 13:41:55 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 16BF215F400; Wed, 24 Apr 2024 13:39:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="2VwaBiS0" Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF8B115CD7B; Wed, 24 Apr 2024 13:39:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=68.232.154.123 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713965983; cv=none; b=kl09alBF/PHb/c3jLCJVUzVLDLSij18mxrprDQnxq9o7TCMz/UlskIyX+BscB4Yrb9bYMih3KCibJxHE+1i5l3A+6JYTPtbKCDntiD6+efBwBNwaSa8aofeawLzhRVuDT+fbCgm3rDGvLr+rBfbF8eQaRnG8uP6qMEST1n7XxFM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713965983; c=relaxed/simple; bh=64mDTdBCtb8WNuIGOYCX/n2GuSDDhRGuuaVDFtoB9wI=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=f0L12Sa5iRUGZ4GenegZO+6Bk9PPQygH/bOzY25sqNjoYcY82n0KBuW4rHCbdYF+jnPXWtedNs+E4IHD2jT/xa01E9VbF6HS8me1e1t/pg+cFabAdYKu7zP2xTUQppSIto4eyoTxUnzx3shuQBytDdcRdEbfGFdGVkFD/BmzbLI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com; spf=pass smtp.mailfrom=microchip.com; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b=2VwaBiS0; arc=none smtp.client-ip=68.232.154.123 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1713965981; x=1745501981; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=64mDTdBCtb8WNuIGOYCX/n2GuSDDhRGuuaVDFtoB9wI=; b=2VwaBiS01Yx8YlNfq4yX53UAeQ1rCN9wkNHxD718YNjitX2o6nPztNEA WoPH6AQr41BZhIeSHtpEXiLnSNzaebeilGdfASwYezueBvNWgk5ats7fr TkLFnWSvsqiha+kJcJAM4saPvtsWgCJPsZdfGbLhvjirNhepJ+uO026fu GxFLuLEga5rfa8kbx4ZQ4FH8PLA4MXb7jl5o5mOt/5cIeB3Ffi05ZpGqR FpJcesV6bhLJTAP7zm8Oi1mFA23WWCNN1gyJYgLFygTlb7SyK8cVQNw1C FncC3GuWu4mkFrfoo7Z6or+XJDIIaTbdeDS2Jz4oXr1K2uYKx6dq1DOdW g==; X-CSE-ConnectionGUID: DZwg016nQRyZW6QR0k7REg== X-CSE-MsgGUID: UqCHhIGESMmxZaRwjd1Piw== X-IronPort-AV: E=Sophos;i="6.07,226,1708412400"; d="scan'208";a="23034276" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 Apr 2024 06:39:33 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 24 Apr 2024 06:39:08 -0700 Received: from DEN-DL-M70577 (10.10.85.11) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2507.35 via Frontend Transport; Wed, 24 Apr 2024 06:39:06 -0700 Date: Wed, 24 Apr 2024 13:39:05 +0000 From: Daniel Machon To: =?utf-8?Q?Asbj=C3=B8rn_Sloth_T=C3=B8nnesen?= CC: , Steen Hegelund , Lars Povlsen , , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , , Jiri Pirko , Simon Horman Subject: Re: [PATCH net-next v2 0/4] net: sparx5: flower: validate control flags Message-ID: <20240424133905.iex24gviwgoe7h3t@DEN-DL-M70577> References: <20240424121632.459022-1-ast@fiberby.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240424121632.459022-1-ast@fiberby.net> > This series adds flower control flags validation to the > sparx5 driver, and changes it from assuming that it handles > all control flags, to instead reject rules if they have > masked any unknown/unsupported control flags. > > --- > > Changelog: > > v2: > * Split first patch into 3 (requested by Jiri) > * Convert a missed extack usage (noticed by Daniel) > * Added cover letter (requested by Simon and Daniel) > > v1: https://lore.kernel.org/netdev/20240423102728.228765-1-ast@fiberby.net/ > > Asbj?rn Sloth T?nnesen (4): > net: sparx5: flower: only do lookup if fragment flags are set > net: sparx5: flower: add extack to > sparx5_tc_flower_handler_control_usage() > net: sparx5: flower: remove goto in > sparx5_tc_flower_handler_control_usage() > net: sparx5: flower: check for unsupported control flags > > .../microchip/sparx5/sparx5_tc_flower.c | 20 +++++++++++-------- > 1 file changed, 12 insertions(+), 8 deletions(-) > > -- > 2.43.0 > For the series: Reviewed-by: Daniel Machon Tested-by: Daniel Machon