Received-SPF: pass (google.com: domain of linux-kernel+bounces-157009-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 24 Apr 2024 15:51:31 +0200
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: kelvin.zhang@amlogic.com, George Stark <gnstark@salutedevices.com>, 
	Neil Armstrong <neil.armstrong@linaro.org>, Kevin Hilman <khilman@baylibre.com>, 
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>, Rob Herring <robh@kernel.org>, 
	Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>, linux-pwm@vger.kernel.org, 
	linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, 
	devicetree@vger.kernel.org, Junyi Zhao <junyi.zhao@amlogic.com>
Subject: Re: [PATCH v4 1/2] pwm: meson: Add support for Amlogic S4 PWM
Message-ID: <ikwqq5veuad7fehk6qrpebevvn2ezuxwm3h7agloqeomxc5cbg@kj3be67luyxm>
References: <20240424-s4-pwm-v4-0-ee22effd40d0@amlogic.com>
 <20240424-s4-pwm-v4-1-ee22effd40d0@amlogic.com>
 <1jil07f3ps.fsf@starbuckisacylon.baylibre.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="iu54kaoqx4r57nc6"
Content-Disposition: inline
In-Reply-To: <1jil07f3ps.fsf@starbuckisacylon.baylibre.com>


--iu54kaoqx4r57nc6
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

On Wed, Apr 24, 2024 at 12:32:36PM +0200, Jerome Brunet wrote:
> > +err:
> > +	while (--i >=3D 0) {
> > +		channel =3D &meson->channels[i];
> > +		clk_put(channel->clk);
>=20
> Fine on error but leaks on module unload.
>=20
> Same as George,
>=20
> Add the devm variant of of_clk_get() if you must.

There shouldn't be a reason to still use of_clk_get(). I'd expect that
devm_clk_get() should do the job and if not that's a bug.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--iu54kaoqx4r57nc6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmYpDmIACgkQj4D7WH0S
/k4DWwf7B/jLf47AuXBENtfvni8lWuon3Tt/DXDsPZRlEb9UoEXv4WxXlFZKVftO
l0q+KF0HHEML/dD9UUE4g8UNe2U7eUlEg7gyUjExBdfPlGM+j3lNOGZDwdqreNle
Gdoit31nRGG4IBuTHQDewkHDPOs92aw0EqeWayTuBlTXdl/F6Sm7qe8/HckfWumO
o9DdQi0o6HUdFpx6WLKRX3HiNebDQSVaWg9BSZeJyFt8uF3ppm6ZfWNKlyDJzxvE
lnQ+8aDWoPghdZFh4OBPg6KCRTd/hgs2jnkVq1py5jjxyoz68cQHxAh+fAho+9sX
EHf+41Kbc2RIW2j8/2JXauQz2hDXXA==
=LRdh
-----END PGP SIGNATURE-----

--iu54kaoqx4r57nc6--