Received-SPF: pass (google.com: domain of linux-kernel+bounces-156999-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <e9bb8474-ae18-4e1e-9bba-0ae5c04624cd@amd.com>
Date: Wed, 24 Apr 2024 09:44:18 -0400
User-Agent: Mozilla Thunderbird
Cc: yazen.ghannam@amd.com, linux-edac@vger.kernel.org,
 linux-kernel@vger.kernel.org, tony.luck@intel.com, x86@kernel.org,
 Avadhut.Naik@amd.com, John.Allen@amd.com
Subject: Re: [PATCH v2 05/16] x86/mce/amd: Clean up SMCA configuration
To: Borislav Petkov <bp@alien8.de>
References: <20240404151359.47970-1-yazen.ghannam@amd.com>
 <20240404151359.47970-6-yazen.ghannam@amd.com>
 <20240423190641.GDZigGwXXEPeDnfOsr@fat_crate.local>
 <eb9c5d9b-07d2-4b56-98dd-c2616ef73a0a@amd.com>
 <20240424022822.GAZihuRjwlK6kOF0ya@fat_crate.local>
Content-Language: en-US
From: Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <20240424022822.GAZihuRjwlK6kOF0ya@fat_crate.local>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eU5BZG9KN2xDalFDVkFHR21ranF2R3VoUlR3bXNRTDFzQVh4Y0VTaUJOajZs?=
 =?utf-8?B?Mld6TEpCSnpRWUl0RERyeUVucTlyZmF1OVE3TnE0ZDVzdWRnNnU4akxKUWdk?=
 =?utf-8?B?QnE2UXF6STNLQ1ZCRXpxZTdOdzRtRlV4dTBKaGtRenpDOHdYYVRHZ294QTBN?=
 =?utf-8?B?Y3BTeGJHRGxGdkdMeGtGQ3FpMTA1cmtBQkl2Y0owQmNabHV3WGRDUzZUUDZv?=
 =?utf-8?B?WllWTk5JQkw1cWdoS1BPdUhRNVFyODJFZ0dERVhVLzlxMjVpaGl0YVhobk9o?=
 =?utf-8?B?aWhMSldUYWJDODd1WklDMy9rRFlCSnhKL1p6QWFqa0hrbUIrR1RpcnVSb21Z?=
 =?utf-8?B?anNpbnpxQ29ncDlNNE1LbXduQ1ljeU0yMWE0QksyY0xhcG9vOUI2VTlHSVZr?=
 =?utf-8?B?d3RkV2VUSnJSMHVQWC9ZZ2pBY1dGTWIzRXV2aTJwMkVXMEZod1VYZzBnMmpw?=
 =?utf-8?B?RlorcGhCTFI2M3ZGRDFmbW5YYTZYRHhlNHB4OHhlOGV1a3V3NDFFRW5TWjlD?=
 =?utf-8?B?VjU0djlHdXVCUjRqOGpSZncyVTdCajZFU1E0eDFGZG1NbXM5aVJPcTRLRlpo?=
 =?utf-8?B?YzVWdU0xQ2QvWHQwK0s5dlJwb0V1SUkwQ0xmaHFLSTFzYlZYanBDN1BXVVgv?=
 =?utf-8?B?OE9uUEhkcnRWR3FNL3AxaXlNblBlRW9UcFRwQUgxYytMdVA2cEd4NHFYREhY?=
 =?utf-8?B?enQyV0trRFUzQnRxa2FSckl3c3F5UFBFejFtS1IvaWphTmd3K1dSZkw1NlNB?=
 =?utf-8?B?ckJGRHFOVm1IeTVEaFcvdWU1T1Zza3lrUmp3VitVQkw4Z0kxK3lsRmZzWFEv?=
 =?utf-8?B?aC9DNHVONG56ZDhqQS8yUEM2L0JxZUNFQ1ZKL1pBdlpHL2ZXVWNNK01mdm9X?=
 =?utf-8?B?NVhkdHp3aS9sZTltclBjd2s5b0ZNeUVhYldNdURweUx3QjhKdHBOMWtaa0NL?=
 =?utf-8?B?ZVM2NWtlTjJwdnFZY2pJWGQwQndiejUyUFdRNEdRekI5bTlBSzBoSy83dEFT?=
 =?utf-8?B?Rkd3ZG1BT3ZnOUpoQ0wwNlFuYWl3blhCTjFST2pHL0ZNVzFyNmluNHhTd3ZH?=
 =?utf-8?B?b3l0c2pNNHVMY3U5RG9mUVAvSmZaRXQ1TmxSblV4ajRmczNUK2c0VTY1Wm5I?=
 =?utf-8?B?bkJSNURFK1VobUJoVEsvOXZSQ1JRTzdaMnBaTEZ2cU9mN3Vqak40UVlqUlBJ?=
 =?utf-8?B?NG5ONzRYazQxOFlmSW16ZTdoSzd3OEZEbGwyUXBLdzk2cXFISktjUHRXV1RJ?=
 =?utf-8?B?Mm5nWWdZbUZtNlljZEJLNFY0Yk9Ydk5XNlRRRzNoSlFtU2duOThuYm9EVEJl?=
 =?utf-8?B?eExxSHhsZmdVclJhdnZlVlZYTmxrVXhZdXdQcVR4WFpEenQ1enBZWEx5OXdC?=
 =?utf-8?B?N05rbGRydWhOOURUM3FNNFMzbHNrdzl0cTFCSDFoc1FuZDg5bFNsK2RvOEJh?=
 =?utf-8?B?RDRVTXF5aGtneXFxMGdFZXM4bFBjSUZHZDZhNThHLzZ0c1ZCcWppSEtaRXho?=
 =?utf-8?B?dnRHMHhyQXZWZ1J3SmN0eUlmLzZqWCtVUDBBdmJYRW5TVDFaTmtPaU5FWnhi?=
 =?utf-8?B?dWhXU0pjYWpRM0pqUU11TVhvdXJqNzNReDA2blRoOThkN0pFVytFQWcrTndZ?=
 =?utf-8?B?K3pWdThaeHQ4dE1pc1hlU0hUc3NCblpnQkZRNjBVcTdrczFoWmtpc2NtWjVr?=
 =?utf-8?B?MHlxcE5DUm9kNXVoNW80bi9XMk5YUDNVVXNnTUp0Tm52MU14Zkp4SVZHSXBv?=
 =?utf-8?B?eVMzZzhhYUhVS3NabHh0dXhrQmo0Z2U0SlRFNHJNZTdscFUwOWJ5OUFaZkwr?=
 =?utf-8?B?V24xSUJ1ME1ybDdQbStMR0w2WjZiWWU4NktzcGRSejJDL2t6S1FoYjYvUE5j?=
 =?utf-8?B?VXlub3pBNXVKa2FQUUYrL1NuRW1ndXJCbGlHQnNMQWJRc0NhVjFYT3NCTlgz?=
 =?utf-8?B?UC9RZFdJbTdjcTJISDNXQkgwb2REM1hZaTM1cTJPNTRDNElCdG5yR1ZTanpo?=
 =?utf-8?B?ZlNFeXBkN0RFNEdSSVFoS1JPN0pzTUh2SDRRQ1NUdlJ0NmcwNTZlRXg3cTND?=
 =?utf-8?B?YkpGaHpFV1V4TDZpUEFwSk4vaHVPam5CMmFxUks4L0VBRWZybWxFQ3l5M1E0?=
 =?utf-8?Q?T9mmT2lDXff5gj+cOoU5WZtKY?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a1d7a2aa-2d24-4dcb-abcc-08dc6464a40e
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2024 13:44:19.2815
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DGNb0v3E8BP++O75u+ZE9tGWqa18N9ZpOWMX9l/Ge85LoLlBhc1XQ2HaQHs2GCq7qcaxtegsXO422yKF72d8Vg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9167

On 4/23/2024 10:29 PM, Borislav Petkov wrote:
> On Tue, Apr 23, 2024 at 03:32:00PM -0400, Yazen Ghannam wrote:
>> This is not the same.
>>
>> "CFG_DFR_INT_TYPE" is a register field.
>>
>> "INTR_TYPE_APIC" is a value. And this same value can be used in other register
>> fields.
> 
> I don't care - this was just an example of how it should look like. Like
> the rest of the code around the kernel and not like an obfuscated
> C contest mess.
> 
>> I think it's fair to just use logical AND for single bit checks instead of the
>> FIELD_GET() macro.
>>
>> But the FIELD_PREP() macro does help for setting bitfields. I think it's
>> clearer than manually doing the proper shifts and masks.
> 
> To you maybe.
> 
> Pls stick to how common code does masks generation and manipulation so
> that this remains readable. This FIELD* crap is not helping.
> 

Okay, will do. I'll drop all the bitfield stuff from the entire set.

>> Okay. I was thinking to keep the names shorter since they are only used in
>> this file. But I'll change them.
> 
> If you want to keep them shorter, then think of an overall shorter
> scheme of how the register *and* the fields which belong to it, should
> be named. But there's a point in having the same prefix for register and
> bits which belong to it.
>

Okay, understood.

Thanks,
Yazen