Received-SPF: pass (google.com: domain of linux-kernel+bounces-157096-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 24 Apr 2024 10:39:22 -0400
From: Frank Li <Frank.li@nxp.com>
To: Richard Zhu <hongxing.zhu@nxp.com>
Cc: Richard Zhu <hongxing.zhu@nxp.com>, vkoul@kernel.org, kishon@kernel.org,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, linux-phy@lists.infradead.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel@pengutronix.de,
	imx@lists.linux.dev
Subject: Re: [PATCH v3 2/3] dt-bindings: phy: Add i.MX8Q HSIO SerDes PHY
 binding
Message-ID: <ZikZmo3420wqx16E@lizhi-Precision-Tower-5810>
References: <1713939683-15328-1-git-send-email-hongxing.zhu@nxp.com>
 <1713939683-15328-3-git-send-email-hongxing.zhu@nxp.com>
 <20240424-lustfully-region-826b9570bc38@spud>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240424-lustfully-region-826b9570bc38@spud>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Gze8w4ilMGlTssjKdJDuPpWjCMdszE5bK9sW8ts1OF12xn0jB4jFBozoaY6X?=
 =?us-ascii?Q?0DK783NDUEfn3VRFFzwAI7xtwLhfgNOINakKkf8ypktXLA8XLqwnPfBPrxKO?=
 =?us-ascii?Q?CRuaElKMFoLIXB0ThM+ae8o97fLqXVFEvOlTGte0I5q0AoX5Bv8G+LcJxUoA?=
 =?us-ascii?Q?RjmhnvtshqTawyPTsgU2eItE6/jSVWNFkck4SyJ8sZy0K6sv0d7wT3df90Mg?=
 =?us-ascii?Q?Y9XyyxmqBPV3/rmsYeN+OXW+Lx70km1XWeG/vXGi9mgr8iz2edSq53wREq7k?=
 =?us-ascii?Q?yW7FmnwimMt4CDBZy58SSBADqFHwYHFxrdZ2riKfaZF03Xxl8JDD7XKTCEZF?=
 =?us-ascii?Q?ZyZnFRXM3MPUEe9kglxFRMeDZV+4eS7/4RSxVeUUtnDZwNurZ3dfCpRBZDBH?=
 =?us-ascii?Q?D7nVfe+YvpW0UFbZIZsGC9GyJ5GQJ/gwTSxWSi/pDuldY4mO4MwgN31aXjRp?=
 =?us-ascii?Q?80DHAxII+xWZDxFPu5HPM1fCDyo4/1lpf04OjdBK0XD8S/k75f2W1d6ZJhX/?=
 =?us-ascii?Q?pY9rwUekHr6xm+/Gymzz+vvAYnEUgzZNbLTrTL0+imm2n85Uty3EGLzACQA2?=
 =?us-ascii?Q?uzvdNYm7tu+IRGAv+V2jkh8e5C3wnQpGzqB6XUzONvgnJBCHHHz4F0pXU4/n?=
 =?us-ascii?Q?XPZUODjoJapRaTZ2J7HFdq25LlUFlUzkzxWlfPfbjpDHLDZMMAAfQOJCdUXl?=
 =?us-ascii?Q?xgsC4qQwBIkDp3ZNQEQ+e4/7p6d/dPnphyGq2AzBlUiITssDhaAIlCFa93NO?=
 =?us-ascii?Q?LeClULVB2aWmcafZs0q+OkkoQmsF192n+EWgJZTw+NkCau5Utu6NZXtRYipr?=
 =?us-ascii?Q?044T/dHsNX5O4jJOQDwOu/ZRLGlJLQ4aSLZqWTqX9T4hRnHtrnX8lKUKG8OT?=
 =?us-ascii?Q?6X8Cc5MejE8uEg1J9jda8b6M6vDkuUfhmeAAxCCxbugCZYeGqhIuG1gWSsdC?=
 =?us-ascii?Q?IVyw/vTZBTAHrjVv1uzkSkozQz/BtxkOme54WVTSRjeWN2iX8msqDI8gXYyx?=
 =?us-ascii?Q?vQi8UOV6nPHZ4LeFtxSLGMHoar8ozP6628qx1n4wXPJ1TdaMWtB2NdKrA9oK?=
 =?us-ascii?Q?Mh9CuxtMjACfh4PIWMjUIGpSsUJhvtG8zT5WpHznnv4ah7FAle3y2O50DlPV?=
 =?us-ascii?Q?/rYC35dkMOsSKtYNzN+6Yab8I2Iq+mKqkSm8M5I+c/tFv8TPDZRsoVv5famD?=
 =?us-ascii?Q?D2pxuGooQHv+Pi3piOF3XOYaKKI5CRAkF2yZtGoQL8DgM6QlewB2KRJ8fhsA?=
 =?us-ascii?Q?VjmP6+Km37zPfIvXUOJ1FeuxZ1Xw/qeLPvXs2GflfUrQ0c+zgrCxdtV3xCck?=
 =?us-ascii?Q?Tn6bBNltzL7skuq84Kk1hlR35i3BlkxMGt1i8LynED0YR7ajkK3/7ZbdIp/3?=
 =?us-ascii?Q?PPswItn0B4ixnJSlE+le8mP58zo4NKcDa8qUHMgp92Zax+D7CFRf7MUtix9f?=
 =?us-ascii?Q?XfDkaahN0m+Ias67brLCPPIvTacvLpWD+c70JthQKml887+R/MpvhoEy0lSL?=
 =?us-ascii?Q?yraoSwXOd5n91bJ4/1hFUubpRGqwTioYPPLpoitPSfzL4cTFjmfOHiABgUs/?=
 =?us-ascii?Q?0M1VWpFO5UYNGjXRP44+JEvwvtjFNReonkCEleV3?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f0a6aad5-1b79-4030-ea6a-08dc646c5a26
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2024 14:39:31.4091
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tEk5SIIpzYs+t6nEVH2swLVc/E+r4tRRk1zIJAJRssKY8vkS35pyviiPSDO/cOxj3ZtpYvLj+SAfVZz3ZN/i0Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9453

On Wed, Apr 24, 2024 at 01:04:27PM +0100, Conor Dooley wrote:
> On Wed, Apr 24, 2024 at 02:21:22PM +0800, Richard Zhu wrote:
> > Add i.MX8QM and i.MX8QXP HSIO SerDes PHY binding.
> > Introduce one HSIO configuration 'fsl,hsio-cfg', which need be set at
> > initialization according to board design.
> > 
> > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> > ---
> >  .../bindings/phy/fsl,imx8qm-hsio.yaml         | 146 ++++++++++++++++++
> >  1 file changed, 146 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/phy/fsl,imx8qm-hsio.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/phy/fsl,imx8qm-hsio.yaml b/Documentation/devicetree/bindings/phy/fsl,imx8qm-hsio.yaml
> > new file mode 100644
> > index 000000000000..3e2824d1616c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/phy/fsl,imx8qm-hsio.yaml
> > @@ -0,0 +1,146 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/phy/fsl,imx8qm-hsio.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Freescale i.MX8QM SoC series HSIO SERDES PHY
> > +
> > +maintainers:
> > +  - Richard Zhu <hongxing.zhu@nxp.com>
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - fsl,imx8qm-hsio
> > +      - fsl,imx8qxp-hsio
> > +  reg:
> > +    minItems: 4
> > +    maxItems: 4
> > +
> > +  "#phy-cells":
> > +    const: 3
> > +    description:
> > +      The first defines the type of the PHY refer to the include phy.h.
> > +      The second defines controller index.
> > +      The third defines the lane mask of the lane ID, indicated which
> > +      lane is used by the PHY. They are defined as HSIO_LAN* in
> > +      dt-bindings/phy/phy-imx8-pcie.h
> > +
> > +  reg-names:
> > +    items:
> > +      - const: reg
> > +      - const: phy
> > +      - const: ctrl
> > +      - const: misc
> > +
> > +  clocks:
> > +    minItems: 5
> > +    maxItems: 14
> > +
> > +  clock-names:
> > +    minItems: 5
> > +    maxItems: 14
> > +
> > +  fsl,hsio-cfg:
> > +    description: Refer macro HSIO_CFG* include/dt-bindings/phy/phy-imx8-pcie.h.
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +
> > +  fsl,refclk-pad-mode:
> > +    description:
> > +      Specifies the mode of the refclk pad used. It can be UNUSED(PHY
> > +      refclock is derived from SoC internal source), INPUT(PHY refclock
> > +      is provided externally via the refclk pad) or OUTPUT(PHY refclock
> > +      is derived from SoC internal source and provided on the refclk pad).
> > +      Refer include/dt-bindings/phy/phy-imx8-pcie.h for the constants
> > +      to be used.
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    default: IMX8_PCIE_REFCLK_PAD_OUTPUT
> 
> My comments on this are still not addressed. Please go back and read my
> comments about this property on v1.

Richard: I think we missunderstand conor's means at v1.

"Why do we need numbers and a header here at all? The enum should be an
enum of strings input, output & unused. Oh and "unused" can just be
dropped, and not having the property at all would mean "unused"."

fsl,refclk-pad-mode:
  description:
    ...
  enum: ["input", "output"].

If not exist "fsl,refclk-pad-mode" means "unused".

Frank