Received-SPF: pass (google.com: domain of linux-kernel+bounces-157130-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 24 Apr 2024 15:51:54 +0100
From: Conor Dooley <conor@kernel.org>
To: Alexandre Ghiti <alex@ghiti.fr>
Cc: Charlie Jenkins <charlie@rivosinc.com>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>, Guo Ren <guoren@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Samuel Holland <samuel@sholland.org>,
	Conor Dooley <conor.dooley@microchip.com>,
	Evan Green <evan@rivosinc.com>,
	=?iso-8859-1?Q?Cl=E9ment_L=E9ger?= <cleger@rivosinc.com>,
	Jonathan Corbet <corbet@lwn.net>, Shuah Khan <shuah@kernel.org>,
	linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Palmer Dabbelt <palmer@rivosinc.com>,
	linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev,
	linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v3 06/17] riscv: Fix extension subset checking
Message-ID: <20240424-wildly-goofy-c81aac6f8cd7@spud>
References: <20240420-dev-charlie-support_thead_vector_6_9-v3-0-67cff4271d1d@rivosinc.com>
 <20240420-dev-charlie-support_thead_vector_6_9-v3-6-67cff4271d1d@rivosinc.com>
 <6c624361-a968-498b-a9fb-ea2aaec70ce8@ghiti.fr>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="ISCd5ZrJR7K6TsSY"
Content-Disposition: inline
In-Reply-To: <6c624361-a968-498b-a9fb-ea2aaec70ce8@ghiti.fr>


--ISCd5ZrJR7K6TsSY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 24, 2024 at 04:22:02PM +0200, Alexandre Ghiti wrote:
> Hi Charlie,
>=20
> On 21/04/2024 03:04, Charlie Jenkins wrote:
> > This loop is supposed to check if ext->subset_ext_ids[j] is valid, rath=
er
> > than if ext->subset_ext_ids[i] is valid, before setting the extension
> > id ext->subset_ext_ids[j] in isainfo->isa.
> >=20
> > Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
> > Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> > Fixes: 0d8295ed975b ("riscv: add ISA extension parsing for scalar crypt=
o")
> > ---
> >   arch/riscv/kernel/cpufeature.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/arch/riscv/kernel/cpufeature.c b/arch/riscv/kernel/cpufeat=
ure.c
> > index 48874aac4871..b537731cadef 100644
> > --- a/arch/riscv/kernel/cpufeature.c
> > +++ b/arch/riscv/kernel/cpufeature.c
> > @@ -609,7 +609,7 @@ static int __init riscv_fill_hwcap_from_ext_list(un=
signed long *isa2hwcap)
> >   			if (ext->subset_ext_size) {
> >   				for (int j =3D 0; j < ext->subset_ext_size; j++) {
> > -					if (riscv_isa_extension_check(ext->subset_ext_ids[i]))
> > +					if (riscv_isa_extension_check(ext->subset_ext_ids[j]))
> >   						set_bit(ext->subset_ext_ids[j], isainfo->isa);
> >   				}
> >   			}
> >=20
>=20
> I think this should go into -fixes, let's check with Palmer if he wants to
> take this patch only or if you should send the patch on its own.

I think splitting out this and patch 1 into a new series targeting fixes
would probably make things clearer?

--ISCd5ZrJR7K6TsSY
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZikcigAKCRB4tDGHoIJi
0lY6AP9fxMZ4oOWAWRpbaYHs+Q77SeZ+QaOXEZh098c2I789WAEAmdgrmjjeEcJ4
b2LKa6uCXOLW9VEFR/QJlfNVN9MYwgU=
=Z23p
-----END PGP SIGNATURE-----

--ISCd5ZrJR7K6TsSY--