Received-SPF: pass (google.com: domain of linux-kernel+bounces-156858-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240422130036.31856-1-brgl@bgdev.pl> <99242a7c-53bf-4227-9623-7bc092f564b3@penguintechs.org>
 <CAMRc=MepDwUbAKrWgm0CXKObqy8=igtug0QDgo-CgwxjZCAC2Q@mail.gmail.com>
 <b982b73d-0540-409c-a6e2-0e03ecb11715@penguintechs.org> <0381f39c-38ba-4a2b-915c-f14c5f911eb9@penguintechs.org>
 <CAMRc=MfnEct7ThQhCA3AoY7hxq8j1mmFLNNkK17+RSvJxs67XQ@mail.gmail.com>
 <2371f538-ec53-4037-b171-c62bf4e06eb1@penguintechs.org> <CACMJSeunUaj0cxLaN4MpFmX5vTOx_vnWjBN4Y2FavdQoQxFRkg@mail.gmail.com>
In-Reply-To: <CACMJSeunUaj0cxLaN4MpFmX5vTOx_vnWjBN4Y2FavdQoQxFRkg@mail.gmail.com>
From: Bartosz Golaszewski <brgl@bgdev.pl>
Date: Wed, 24 Apr 2024 14:23:55 +0200
Message-ID: <CAMRc=MeZh6YugXtDeF=nuwmpW5qvmHLt+g6S3Guoome7mz2xyA@mail.gmail.com>
Subject: Re: [PATCH] Bluetooth: qca: set power_ctrl_enabled on NULL returned
 by gpiod_get_optional()
To: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Cc: Wren Turkal <wt@penguintechs.org>, linux-bluetooth@vger.kernel.org, 
	linux-kernel@vger.kernel.org, Zijun Hu <quic_zijuhu@quicinc.com>, 
	Marcel Holtmann <marcel@holtmann.org>, Luiz Augusto von Dentz <luiz.dentz@gmail.com>, 
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 24, 2024 at 2:20=E2=80=AFPM Bartosz Golaszewski
<bartosz.golaszewski@linaro.org> wrote:
>
> On Wed, 24 Apr 2024 at 14:17, Wren Turkal <wt@penguintechs.org> wrote:
> >
> > On 4/24/24 4:56 AM, Bartosz Golaszewski wrote:
> > > On Wed, Apr 24, 2024 at 1:53=E2=80=AFPM Wren Turkal <wt@penguintechs.=
org> wrote:
> > >>
> > >> On 4/24/24 4:16 AM, Wren Turkal wrote:
> > >>> On 4/24/24 2:04 AM, Bartosz Golaszewski wrote:
> > >>>> On Wed, 24 Apr 2024 07:07:05 +0200, Wren Turkal<wt@penguintechs.or=
g>
> > >>>> said:
> > >>>>> On 4/22/24 6:00 AM, Bartosz Golaszewski wrote:
> > >>>>>> From: Bartosz Golaszewski<bartosz.golaszewski@linaro.org>
> > >>>>>>
> > >>>>>> Any return value from gpiod_get_optional() other than a pointer =
to a
> > >>>>>> GPIO descriptor or a NULL-pointer is an error and the driver sho=
uld
> > >>>>>> abort probing. That being said: commit 56d074d26c58 ("Bluetooth:
> > >>>>>> hci_qca:
> > >>>>>> don't use IS_ERR_OR_NULL() with gpiod_get_optional()") no longer=
 sets
> > >>>>>> power_ctrl_enabled on NULL-pointer returned by
> > >>>>>> devm_gpiod_get_optional(). Restore this behavior but bail-out on
> > >>>>>> errors.
> > >>>>> Nack. This patch does fixes neither the disable/re-enable problem=
 nor
> > >>>>> the warm boot problem.
> > >>>>>
> > >>>>> Zijun replied to this patch also with what I think is the proper
> > >>>>> reasoning for why it doesn't fix my setup.
> > >>>>>
> > >>>> Indeed, I only addressed a single issue here and not the code unde=
r the
> > >>>> default: label of the switch case. Sorry.
> > >>>>
> > >>>> Could you give the following diff a try?
> > >>>
> > >>> I had a feeling that was what was going on. I'll give the patch a s=
hot.
> > >>>
> > >>> wt
> > >>
> > >> Considering this patch is basically equivalent to patch 1/2 from Zij=
un,
> > >> I am not surprised that is works similarly. I.e. on a cold boot, I c=
an
> > >> disable/re-enable bluetooth as many time as I want.
> > >>
> > >
> > > Zijun didn't bail out on errors which is the issue the original patch
> > > tried to address and this one preserves.
> > >
> > >> However, since this patch doesn't include the quirk fix from Zijun's
> > >> patchset (patch 2/2), bluetooth fails to work after a warm boot.
> > >>
> > >
> > > That's OK, we have the first part right. Let's now see if we can reus=
e
> > > patch 2/2 from Zijun.
> >
> > I'm compiling it right now. Be back soon.
> >
>
> Well I doubt it's correct as it removed Krzysztof's fix which looks
> right. If I were to guess I'd say we need some mix of both.
>
> Bart
>

Anyway, these are two separate issues. Let me send a v2 of this one to
address at least one of them. I think Krzysztof will be better at
fixing the other one as it's his patch that caused the second
regression.

Bart