Received-SPF: pass (google.com: domain of linux-kernel+bounces-157142-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <5426c24a215b363e7b9b03a97d023d2e29b6a0a7.camel@ew.tq-group.com>
Subject: Re: [PATCH net-next] net: phy: marvell: add support for MV88E6020
 internal PHYs
From: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>, Russell King
 <linux@armlinux.org.uk>,  "David S. Miller" <davem@davemloft.net>, Eric
 Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo
 Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org,  linux@ew.tq-group.com
Date: Wed, 24 Apr 2024 16:57:24 +0200
In-Reply-To: <64dbfe14-e777-49e2-ab7d-ec6fa517a8f1@lunn.ch>
References: <20240424121022.160920-1-matthias.schiffer@ew.tq-group.com>
	 <19c4b8da-203e-4a81-9531-9ba4a4f750fd@lunn.ch>
	 <1cb8bafb44075858221b31c056d75a40d7ba2ee1.camel@ew.tq-group.com>
	 <64dbfe14-e777-49e2-ab7d-ec6fa517a8f1@lunn.ch>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
Precedence: bulk
MIME-Version: 1.0

On Wed, 2024-04-24 at 16:52 +0200, Andrew Lunn wrote:
> > We currently do not override the PHY ID for this family in the DSA
> > driver - my understanding was that this is only necessary for
> > switches that don't provide a usable PHY ID at all. As I have no
> > idea if this PHY ID works for the whole family or just the single
> > switch, I went with the more specific naming here.
>=20
> The 'broken' switches have the Marvell OUI, but no module number. From
> your description it sounds like the 6250 is the same?
>=20

No, the PHYs have a proper ID, 0x01410db0. The "Functional Spec" for the 88=
E6020 switch family gives
us the 0x01410c00 part, but the lower 10 bits are undocumented ("reserved")=
, and I don't know if
they differ for each individual switch of the family, as I only have a 88E6=
020 here.

Matthias


--=20
TQ-Systems GmbH | M=C3=BChlstra=C3=9Fe 2, Gut Delling | 82229 Seefeld, Germ=
any
Amtsgericht M=C3=BCnchen, HRB 105018
Gesch=C3=A4ftsf=C3=BChrer: Detlef Schneider, R=C3=BCdiger Stahl, Stefan Sch=
neider
https://www.tq-group.com/