Received-SPF: pass (google.com: domain of linux-kernel+bounces-157240-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 24 Apr 2024 08:48:38 -0700
In-Reply-To: <20240424134248.GCZikMWA8EvlhGEYC7@fat_crate.local>
Precedence: bulk
Mime-Version: 1.0
References: <20240420000556.2645001-1-seanjc@google.com> <20240420000556.2645001-3-seanjc@google.com>
 <20240424053940.3ypivvztvv35dpu7@treble> <20240424134248.GCZikMWA8EvlhGEYC7@fat_crate.local>
Message-ID: <Zikp1sPVzoYVt00X@google.com>
Subject: Re: [PATCH v2 2/2] cpu: Ignore "mitigations" kernel parameter if CPU_MITIGATIONS=n
From: Sean Christopherson <seanjc@google.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Josh Poimboeuf <jpoimboe@kernel.org>, Thomas Gleixner <tglx@linutronix.de>, 
	Ingo Molnar <mingo@redhat.com>, Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org, 
	Peter Zijlstra <peterz@infradead.org>, linux-kernel@vger.kernel.org, 
	Stephen Rothwell <sfr@canb.auug.org.au>, Michael Ellerman <mpe@ellerman.id.au>, 
	Geert Uytterhoeven <geert@linux-m68k.org>, Will Deacon <will@kernel.org>, 
	Linus Torvalds <torvalds@linux-foundation.org>
Content-Type: text/plain; charset="us-ascii"

On Wed, Apr 24, 2024, Borislav Petkov wrote:
> On Tue, Apr 23, 2024 at 10:39:40PM -0700, Josh Poimboeuf wrote:
> > On Fri, Apr 19, 2024 at 05:05:55PM -0700, Sean Christopherson wrote:
> > > +#ifdef CONFIG_CPU_MITIGATIONS
> > >  extern bool cpu_mitigations_off(void);
> > >  extern bool cpu_mitigations_auto_nosmt(void);
> > > +#else
> > > +static inline bool cpu_mitigations_off(void)
> > > +{
> > > +	return false;
> > > +}
> > 
> > This should probably return true?

/facepalm

Glad you were paying attention, as I was clearly not.  I double checked that
flipping that to true does indeed force off mitigations.

> Right, I'll fix it up while applying and send them linuswards this
> weekend so that 6.9 releases fixed.

Thanks!