Received-SPF: pass (google.com: domain of linux-kernel+bounces-157343-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <923135c6-1bd1-414d-b574-c201644d35ab@fiberby.net>
Date: Wed, 24 Apr 2024 16:43:14 +0000
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next] net: qede: flower: validate control flags
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
 "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
 Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
 Ariel Elior <aelior@marvell.com>, Manish Chopra <manishc@marvell.com>
References: <20240424134250.465904-1-ast@fiberby.net>
 <Zikcq2S90S97h7Z0@nanopsycho>
Content-Language: en-US
From: =?UTF-8?Q?Asbj=C3=B8rn_Sloth_T=C3=B8nnesen?= <ast@fiberby.net>
In-Reply-To: <Zikcq2S90S97h7Z0@nanopsycho>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Jiri,

On 4/24/24 2:52 PM, Jiri Pirko wrote:
> Wed, Apr 24, 2024 at 03:42:48PM CEST, ast@fiberby.net wrote:
>> This driver currently doesn't support any flower control flags.
>>
>> Implement check for control flags, such as can be set through
>> `tc flower ... ip_flags frag`.
>>
>> Since qede_parse_flow_attr() are called by both qede_add_tc_flower_fltr()
>> and qede_flow_spec_to_rule(), as the latter doesn't having access to
>> extack, then flow_rule_*_control_flags() can't be used in this driver.
> 
> Why? You can pass null.

Ah, I see. I hadn't traced that option down through the defines,
I incorrectly assumed that NL_SET_ERR_MSG* didn't allow NULL.

Currently thinking about doing v2 in this style:

if (flow_rule_match_has_control_flags(rule, extack)) {
         if (!extack)
                 DP_NOTICE(edev, "Unsupported match on control.flags");
         return -EOPNOTSUPP;
}

pw-bot: changes-requested

-- 
Best regards
Asbjørn Sloth Tønnesen
Network Engineer
Fiberby - AS42541