Received-SPF: pass (google.com: domain of linux-kernel+bounces-157356-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Wed, 24 Apr 2024 09:54:50 -0700
From: Bjorn Andersson <quic_bjorande@quicinc.com>
To: Luca Weiss <luca@z3ntu.xyz>
CC: <~postmarketos/upstreaming@lists.sr.ht>, <phone-devel@vger.kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Mathieu Poirier
	<mathieu.poirier@linaro.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Rob
 Herring <robh@kernel.org>,
        Krzysztof Kozlowski <krzk+dt@kernel.org>,
        Conor
 Dooley <conor+dt@kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <linux-remoteproc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/7] rpmsg: qcom_smd: Don't print error during probe
 deferral
Message-ID: <Zik5WuYgJap2RVC5@hu-bjorande-lv.qualcomm.com>
References: <20240424-apcs-mboxes-v1-0-6556c47cb501@z3ntu.xyz>
 <20240424-apcs-mboxes-v1-1-6556c47cb501@z3ntu.xyz>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240424-apcs-mboxes-v1-1-6556c47cb501@z3ntu.xyz>

On Wed, Apr 24, 2024 at 06:23:54PM +0200, Luca Weiss wrote:
> When the mailbox driver has not probed yet, skip printing the error
> message since it's just going to confuse users.
> 
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
>  drivers/rpmsg/qcom_smd.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c
> index 43f601c84b4f..6fc299657adf 100644
> --- a/drivers/rpmsg/qcom_smd.c
> +++ b/drivers/rpmsg/qcom_smd.c
> @@ -1502,7 +1502,8 @@ struct qcom_smd_edge *qcom_smd_register_edge(struct device *parent,
>  
>  	ret = qcom_smd_parse_edge(&edge->dev, node, edge);
>  	if (ret) {
> -		dev_err(&edge->dev, "failed to parse smd edge\n");
> +		if (ret != -EPROBE_DEFER)
> +			dev_err(&edge->dev, "failed to parse smd edge\n");

In the described case, this error message would not be entirely
accurate, and the cause is not accurately captured in devices_deferred.

Unless I'm mistaken, it seems like qcom_smd_parse_edge() will also print
a more useful error in every other case, except after the mbox_chan !=
-ENODEV check..

How about making that:

	if (PTR_ERR(edge->mbox_chan) != -ENODEV) {
		ret = dev_err_probe(dev, PTR_ERR(edge->mbox_chan),
				    "failed to acquire IPC mailbox\n");
		goto put_node;
	}

And then drop the error print here in qcom_smd_register_edge().

It would bring us the devices_deferred tracking, and it would avoid the
double print in all other cases.

Regards,
Bjorn

>  		goto unregister_dev;
>  	}
>  
> 
> -- 
> 2.44.0
>