Received-SPF: pass (google.com: domain of linux-kernel+bounces-157400-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <df15843e830d1be0137eb43402a334faf895d2be.camel@sipsolutions.net>
Subject: Re: 6.9.0-rc2+ kernel hangs on boot (bisected, maybe LED related)
From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>, Linux regressions mailing list
	 <regressions@lists.linux.dev>, Lee Jones <lee@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, linux-leds@vger.kernel.org, Miri
	Korenblit <miriam.rachel.korenblit@intel.com>
Date: Wed, 24 Apr 2024 19:31:26 +0200
In-Reply-To: <6eba2967-e2de-d9f1-3794-01cf4e88c56c@candelatech.com>
References: <30f757e3-73c5-5473-c1f8-328bab98fd7d@candelatech.com>
	 <30819e01-43ce-638f-0cc6-067d6a8d03c7@candelatech.com>
	 <89a9eec3-337f-3c9f-6bbe-00a26a15287c@candelatech.com>
	 <20240411070718.GD6194@google.com>
	 <de43c7e1-7e8c-bdbe-f59e-7632c21da24a@candelatech.com>
	 <8736ebc8881e1e0cabfbbf033725a3123a5e8e90.camel@sipsolutions.net>
	 <bc420f3a-5809-4c4a-80ad-ccd8a46853b6@leemhuis.info>
	 <8ab88be5de30bcbd0d1cac3cfde6b2085dcfc8fb.camel@sipsolutions.net>
	 <0197efe8-828b-43ae-85c9-5d521913a289@leemhuis.info>
	 <6eba2967-e2de-d9f1-3794-01cf4e88c56c@candelatech.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

Hi Ben,

On Wed, 2024-04-24 at 10:26 -0700, Ben Greear wrote:
>=20
> This patch makes the problem go away in my testbed with 24 Intel
> iwlwifi radios.  My guess is that it is just papering over the problem,

Agree, there seems to be some locking issue with LED stuff, but I'm not
sure where, and the driver doesn't even hold any locks here.

> but maybe good enough?

For all I care, yes. We explicitly do this last, from a worker that
holds no locks in the driver ... so it's odd. Looking at the history of
it, it seems that it was originally _nowait(), but then in 3.6 I changed
it because of some backport concerns. Though then I also moved it out of
the locked section.

> Would you like me to submit as official
> patch to linux-wireless?

Sure.

johannes