Received-SPF: pass (google.com: domain of linux-kernel+bounces-157424-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 24 Apr 2024 10:54:22 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: Robert Richter <rrichter@amd.com>, "Rafael J. Wysocki" <rafael@kernel.org>
CC: Dave Hansen <dave.hansen@linux.intel.com>, Dan Williams
	<dan.j.williams@intel.com>, Alison Schofield <alison.schofield@intel.com>,
	<linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-cxl@vger.kernel.org>, Robert Richter <rrichter@amd.com>, Len Brown
	<lenb@kernel.org>
Subject: Re: [PATCH v4 6/7] ACPI/NUMA: Add log messages for memory ranges
 found in CEDT
Message-ID: <6629474eab671_b6e0294e8@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <20240424154846.2152750-1-rrichter@amd.com>
 <20240424154846.2152750-7-rrichter@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240424154846.2152750-7-rrichter@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aIL5SFUrMnmeO7JtIn9im/C5ZG2+5RgqtV/XPE5cHhh7phVbXI2TdISVT9x5?=
 =?us-ascii?Q?IxlBb8N1GY0WPK2tVWpUztc7chiDS1jA3hfvrZ2Ffo73L0gy2aLxTd/hxgGK?=
 =?us-ascii?Q?bScH/X/UB8mxixnm0ip7gnfdmzOxPibwQT4buIG+ptZsW4GsgJfJW8spmEDX?=
 =?us-ascii?Q?ry2beKTIDPKOWit0kEZ+D2jU8bmzSCs6/zTUS/Zj0CTPiNntL36BLNX6KHwR?=
 =?us-ascii?Q?FWEA0A3uaqLmjc/geOQ4SmeCIXhJ90pD2LR4ng4esdvEptagZ17+xDKUqTlr?=
 =?us-ascii?Q?nIgmnOj1hcTfC3rjihyPWdKvzV/5rcWv4g+x4wD/lTGE7L5Tf5ElFIroPumV?=
 =?us-ascii?Q?7gvdEDVnaCgwl11M18mK94ZyBmuvduqGsBgX1aAoWcjj2fZd1bfDiCPS7hta?=
 =?us-ascii?Q?suXVdNy6eDzpRJYmYLPy7G2hfvnUhdFecKiII+dGXPzESlqpBklq23coZGmd?=
 =?us-ascii?Q?w63NFvlwyb/Qvh9lP1bWTWnXYnigfQ/JCoPzU3TfhtIZgFgrEZQv0jIwWI7n?=
 =?us-ascii?Q?tBmVfhmbTyAryR/8vrQQN49/JDKcI/D4ly+LTfPxydcn6uO3y6I66VpX/l1S?=
 =?us-ascii?Q?roR0Scm3am72IqLbrl0nCQFSu4SFjWcZXGv25vena08Yeotvi2qMH5M5l6W9?=
 =?us-ascii?Q?MmwlKVn+m2nRe7wcKWYn5UQ5pt8HRQuJRYR+fu0/eDkCd25ErVFNop3bmfao?=
 =?us-ascii?Q?NS57YvOnawllX5dhtkSwI6VEfQgrYsF72x2R0Se8SqJxQUceEhzuWQmLxccg?=
 =?us-ascii?Q?tKbcPmu5Z3Ev3WUOCcF1gb9mUsNNgVzKWCz+zUV/IOxpfZj8LTfTPuc0oJwN?=
 =?us-ascii?Q?DMqN6St17ke+oM/G4UXny3LQm+JTUPmVBVst/CYi2cYOU6yz/KpXXCBwz0+Z?=
 =?us-ascii?Q?EatUjYaXwTKCCuCIn9ymdrjdtKcVkEoObmj7uuM43zTwZS+5TAYKho4l51wZ?=
 =?us-ascii?Q?+VLpO6UTULvgnWusVSaEDNsFPrd3kQTdVNmGsbKxatJBBXu06NaeW7N/wjAT?=
 =?us-ascii?Q?5VZxSwUGIJAKftvqB+N7AE4/slzJyJ08HgA9P+cHf92G61VQbonMlDIpUdIK?=
 =?us-ascii?Q?/gu84Puv3Prwr6VgoV0fW/yDMOGJb9utv9gZyIkIG6saMM3mNMvlwPF21SxZ?=
 =?us-ascii?Q?oyRxnUr/EYxdxT7hrfLH0ES8PG1LDFfXVdA0CLhO4RjkFwEXCZw+udWjoNSc?=
 =?us-ascii?Q?pb6s7o2CIzVblJ4YkLo3xzjVzVjmrfJiGFF5vYmYryhs6Cq/CwMUF2/l0yL4?=
 =?us-ascii?Q?/aKfbQKkH6IXR2X0KAVctXM1abOP2UukJDCQC3qhvyqydb/6dAuRL2sSiWgx?=
 =?us-ascii?Q?g10Zx+34EONLCbS+H5UvqW5trQEmTHLs4S/Ff4PtTg7/VjEugUdO22wRf0hh?=
 =?us-ascii?Q?Q6OiCu9yGCTqhS4BEa4v59e84Wx52dmOqJXVKzjTg41s10mwjNDlR1mIDBm3?=
 =?us-ascii?Q?VelmrasUeqpw/U3ok+A6Gr5gJ2WPf+VIWZrVBLsVeGD7Y919ShENfcNTbfIh?=
 =?us-ascii?Q?kkTfFDjt511TCkHWQLthS5Ssx3CNuwZVnHKgVeqnFSvMc+4zNlvztvfjpcHg?=
 =?us-ascii?Q?vGHlkHJifzPipW1AzuPR5U8niVvRBsRVFdR4gBXyHpSAIwuuAqMAZPPAlNj7?=
 =?us-ascii?Q?bQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 66a952f1-afb0-4568-fd39-08dc648794f8
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2024 17:54:26.4050
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EuuGOT0TjxZ2PMHWr74ALw6X9qKY9HKewWi8tR7AFr3nF44gF1XpWqOL5A4/6dq5wB+EiAuadoH+SILbuL48NXdaKsBzgQLhUIFZ8MOXAkQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4955
X-OriginatorOrg: intel.com

Robert Richter wrote:
> Adding a pr_info() when successfully adding a CFMWS memory range.
> 
> Suggested-by: Alison Schofield <alison.schofield@intel.com>
> Signed-off-by: Robert Richter <rrichter@amd.com>
> ---
>  drivers/acpi/numa/srat.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/numa/srat.c b/drivers/acpi/numa/srat.c
> index e3f26e71637a..c62e4636e472 100644
> --- a/drivers/acpi/numa/srat.c
> +++ b/drivers/acpi/numa/srat.c
> @@ -338,8 +338,11 @@ static int __init acpi_parse_cfmws(union acpi_subtable_headers *header,
>  	 * found for any portion of the window to cover the entire
>  	 * window.
>  	 */
> -	if (!numa_fill_memblks(start, end))
> +	if (!numa_fill_memblks(start, end)) {
> +		pr_info("CEDT: memblk extended [mem %#010Lx-%#010Lx]\n",
> +			(unsigned long long) start, (unsigned long long) end - 1);

This looks like pr_debug() material to me.

>  		return 0;
> +	}
>  
>  	/* No SRAT description. Create a new node. */
>  	node = acpi_map_pxm_to_node(*fake_pxm);
> @@ -354,8 +357,13 @@ static int __init acpi_parse_cfmws(union acpi_subtable_headers *header,
>  		pr_warn("ACPI NUMA: Failed to add memblk for CFMWS node %d [mem %#llx-%#llx]\n",
>  			node, start, end);
>  	}
> +
>  	node_set(node, numa_nodes_parsed);
>  
> +	pr_info("CEDT: Node %u PXM %u [mem %#010Lx-%#010Lx]\n",
> +		node, *fake_pxm,
> +		(unsigned long long) start, (unsigned long long) end - 1);
> +

This makes sense to mirror the SRAT pr_info().