Received-SPF: pass (google.com: domain of linux-kernel+bounces-157189-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 24 Apr 2024 17:27:04 +0200
From: Andrew Lunn <andrew@lunn.ch>
To: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux@ew.tq-group.com
Subject: Re: [PATCH net-next] net: phy: marvell: add support for MV88E6020
 internal PHYs
Message-ID: <5ff26668-b96c-44ae-b9d8-4807b6a1a4c0@lunn.ch>
References: <20240424121022.160920-1-matthias.schiffer@ew.tq-group.com>
 <19c4b8da-203e-4a81-9531-9ba4a4f750fd@lunn.ch>
 <1cb8bafb44075858221b31c056d75a40d7ba2ee1.camel@ew.tq-group.com>
 <64dbfe14-e777-49e2-ab7d-ec6fa517a8f1@lunn.ch>
 <5426c24a215b363e7b9b03a97d023d2e29b6a0a7.camel@ew.tq-group.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5426c24a215b363e7b9b03a97d023d2e29b6a0a7.camel@ew.tq-group.com>

On Wed, Apr 24, 2024 at 04:57:24PM +0200, Matthias Schiffer wrote:
> On Wed, 2024-04-24 at 16:52 +0200, Andrew Lunn wrote:
> > > We currently do not override the PHY ID for this family in the DSA
> > > driver - my understanding was that this is only necessary for
> > > switches that don't provide a usable PHY ID at all. As I have no
> > > idea if this PHY ID works for the whole family or just the single
> > > switch, I went with the more specific naming here.
> > 
> > The 'broken' switches have the Marvell OUI, but no module number. From
> > your description it sounds like the 6250 is the same?
> > 
> 
> No, the PHYs have a proper ID, 0x01410db0. The "Functional Spec" for the 88E6020 switch family gives
> us the 0x01410c00 part, but the lower 10 bits are undocumented ("reserved")

Great, Marvell breaking things in new ways :-(

It would be so much nicer if they broke things consistently.

> and I don't know if they differ for each individual switch of the
> family, as I only have a 88E6020 here.

Marvell are pretty consistent within a family. So i expect this same
ID is used for them all. However, i would use MARVELL_PHY_ID_MASK so
the lower nibble is ignored.

Please document these assumptions in the commit message.

       Andrew