Received: by 2002:a89:48b:0:b0:1f5:f2ab:c469 with SMTP id a11csp616316lqd; Wed, 24 Apr 2024 11:31:52 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWDcs7WSGme7dLTMwURrTiukwT2Rms0O11EgdxY0NjQwBCqy2h5knVrFhKZtt7B4sg0AZtrzBIRnxSQaAjRjhUPYTvaNfmApQR6HsaF4w== X-Google-Smtp-Source: AGHT+IHcWqi+jGATGsWqkzOPFy/hp1qQsI1KqbO9Reg7uwh3yFQAtSbifMmDdL+xVRy+q8cB5JNQ X-Received: by 2002:ac8:5f14:0:b0:438:5264:e865 with SMTP id x20-20020ac85f14000000b004385264e865mr3701488qta.10.1713983512235; Wed, 24 Apr 2024 11:31:52 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713983512; cv=pass; d=google.com; s=arc-20160816; b=xlh1kp/XdiF35gfKekLIwviLk6/w87rRkToD4YXaCk48sCdkK59H40PTtC5kyQc9Fj 4ndat4SoM1ukbeS/K1qG9GbiuBcD6738xnACXnSFOu6NA9ZUMyDYVHjz6ri2nihE66uN wdA/KIVudpWF4QvLAdFirxkN/vtAjjkQH3Qjp0yb5f1A+Titpvu6cey/dCXsRmWSdEls pbtImApyit0O5kH/163zkiqrW5WqtoX7X0TQ3ESX/4BEyMpBLdiuwxn1h1cK3+RI+UYv 0A9nromnWvv+EtM6SLOeSyDgR6aEHKMP34SXtTtBKe8dKWhmmfo7B8T8daAEaJXD8WUZ tM6A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=0NRQThXot6y/Efk0nWO5jKrrMvhMpA3ZVgH7fSZlQUo=; fh=8RWZCsFcFW7tfRyjnxchvkKLz+fqJXf4t60QAFPbaoQ=; b=AA+zC13czG0NDIXD5zQw0rp7phfODT7hGPwXlb0hgt6lelpfq5YJGcwzIUSJsZnKvg PZA8qpIfwulfZwm6EXHFWKiabGjTZse1LJDtrc8watIaXJA1BaSZsmXl152XBulWxT2e 27bZTR0JRkvqArk9BV4o38/7CrtT1FNTc6eupuk/VL2c9/dh7m7SSx56zVjllSx/Ou4B 0uFxRSVcTe9lMxh1VCk+auDNUF8Mj3LvKziPdsnsXrOozkA4f4RIoc1PmPZWV7sYW44d sv0b5D8aaFxZsiUDXQTcKgcU1UyIX0cPxLeJVzr6NNhR4cEV2QVPmxv9mHh7fKLhEW+W e4Mw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=POS7GywA; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-156875-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-156875-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id d3-20020a05622a15c300b0043a3c2ac58asi413886qty.433.2024.04.24.11.31.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 11:31:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-156875-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=POS7GywA; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-156875-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-156875-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 905B21C22F15 for ; Wed, 24 Apr 2024 12:32:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3F3F51422AF; Wed, 24 Apr 2024 12:32:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="POS7GywA" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9A0F2F52; Wed, 24 Apr 2024 12:32:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713961923; cv=none; b=Hvr0XASRiqdzISqQX7GcXG47Xe6Ye5AVIBX5tmuhQF7PnuWbCJxQVDiBq1hIh81aQUdaHSEC/g4z7p7VnRJNt4hIdUURi2J2gwTf+MhhzpjBewMBIdDdgcsHJYNqALJWPuvZyUbOqSXrvzSdskykVjzDdw493N3ZQHVsmrJSr90= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713961923; c=relaxed/simple; bh=U0euOlY6tiB7c15NB3mxk++7fzTgXW2igHdpXo+Lays=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gGFSkmGYIqS8Wti/uYpceiddunqHbDxjgG9Fx9a+yiynxY6oYfDrLt4m26t6PRU2mfnlWUPvEkV28kIAhrR0nQiJwyb/83fXcSLyXd1+Y7h9PG+IPLoZJfnMbduJRsInvkyTiaOSc0WQahrOPhUA4O33nzLHweMA9DRcVmO80GQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=POS7GywA; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=0NRQThXot6y/Efk0nWO5jKrrMvhMpA3ZVgH7fSZlQUo=; b=POS7GywASdyiIAJZqgJmFTKi3a ja/i/bUjaZniVkU3XCjHqBEHAPikV0oUPTerGzDtYx9TTMM6pWK7nBFlo7gYBNZjc4v3+FSQeA8NV Hiv5Pb44pkStFYthN8aeRwsE5IFKtOyf9s/UKPj82MpzH1k3TQVonQV/oIwYC9AwCTfE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rzbmv-00DoQJ-04; Wed, 24 Apr 2024 14:31:49 +0200 Date: Wed, 24 Apr 2024 14:31:48 +0200 From: Andrew Lunn To: MD Danish Anwar Cc: Dan Carpenter , Heiner Kallweit , Jan Kiszka , Diogo Ivo , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srk@ti.com, Vignesh Raghavendra , r-gunasekaran@ti.com, Roger Quadros Subject: Re: [PATCH net-next] net: ti: icssg_prueth: Add SW TX / RX Coalescing based on hrtimers Message-ID: <98588a89-4970-4d75-be8a-ac410d77789f@lunn.ch> References: <20240424091823.1814136-1-danishanwar@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240424091823.1814136-1-danishanwar@ti.com> On Wed, Apr 24, 2024 at 02:48:23PM +0530, MD Danish Anwar wrote: > Add SW IRQ coalescing based on hrtimers for RX and TX data path for ICSSG > driver, which can be enabled by ethtool commands: > > - RX coalescing > ethtool -C eth1 rx-usecs 50 > > - TX coalescing can be enabled per TX queue > > - by default enables coalesing for TX0 > ethtool -C eth1 tx-usecs 50 > - configure TX0 > ethtool -Q eth0 queue_mask 1 --coalesce tx-usecs 100 > - configure TX1 > ethtool -Q eth0 queue_mask 2 --coalesce tx-usecs 100 > - configure TX0 and TX1 > ethtool -Q eth0 queue_mask 3 --coalesce tx-usecs 100 --coalesce > tx-usecs 100 > > Minimum value for both rx-usecs and tx-usecs is 20us. Do you have some benchmark numbers? Did you see this patch on the mailing list: https://lore.kernel.org/all/20240415094804.8016-1-paul.barker.ct@bp.renesas.com/T/#md50cb07bbdd6daf985f3796508cf4b246b085268 This is basically a one line change, which brings big performance gains. Did you try something as simple as that, rather than all your hrtimer code? Andrew