Date: Sat, 26 Jan 2008 22:01:47 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Alex Dubov <oakad@yahoo.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [MEMSTICK] Updates for the memstick driver
Message-Id: <20080126220147.c9be389e.akpm@linux-foundation.org>
In-Reply-To: <439089.5370.qm@web36701.mail.mud.yahoo.com>
References: <20080122105900.c7ea1cc3.akpm@linux-foundation.org>
	<439089.5370.qm@web36701.mail.mud.yahoo.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1223
Lines: 36

> On Thu, 24 Jan 2008 23:58:52 -0800 (PST) Alex Dubov <oakad@yahoo.com> wrote:
> * Mark shared inline functions as static
> 
> * Use member-at-a-time assignment for protocol structures
> 
> * Comments for publicly exported functions
> 
> * Use end_queued_request to end unhandled block layer requests
> 
> * Use sysfs attribute group to export MSPro attributes
> 
> * Fix includes
> 
> * Use scnprintf instead of snprintf where string length matters
> 
> * Remove spurious get_device/put_device in probe method
> 

Please sign off your patches.

Please don't send wordwrapped patches.

Please put the subsystem identifier "memstick" outside [], for reasons
described in http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt

Your patch contained a fix which I already merged into -mm, which suggests
that you haven't been testing the code in 2.6.24-rc8-mm1.  Please do test
-mm when you have patches in there, so that we know that we'll be merging
things which work.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/