Received-SPF: pass (google.com: domain of linux-kernel+bounces-157577-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: brauner@kernel.org, amir73il@gmail.com, hu1.chen@intel.com,
 malini.bhandaru@intel.com, tim.c.chen@intel.com, mikko.ylinen@intel.com,
 lizhen.you@intel.com, linux-unionfs@vger.kernel.org,
 linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 0/3] overlayfs: Optimize override/revert creds
In-Reply-To: <CAJfpeguqW4mPE9UyLmccisTex_gmwq6p9_6_EfVm-1oh6CrEBA@mail.gmail.com>
References: <20240403021808.309900-1-vinicius.gomes@intel.com>
 <CAJfpeguqW4mPE9UyLmccisTex_gmwq6p9_6_EfVm-1oh6CrEBA@mail.gmail.com>
Date: Wed, 24 Apr 2024 12:01:54 -0700
Message-ID: <87frvay47x.fsf@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Miklos Szeredi <miklos@szeredi.hu> writes:

> On Wed, 3 Apr 2024 at 04:18, Vinicius Costa Gomes
> <vinicius.gomes@intel.com> wrote:
>
>>  - in ovl_rename() I had to manually call the "light" the overrides,
>>    both using the guard() macro or using the non-light version causes
>>    the workload to crash the kernel. I still have to investigate why
>>    this is happening. Hints are appreciated.
>
> Don't know.  Well, there's nesting (in ovl_nlink_end()) but I don't
> see why that should be an issue.
>
> I see why Amir suggested moving away from scoped guards, but that also
> introduces the possibility of subtle bugs if we don't audit every one
> of those sites carefully...
>
> Maybe patchset should be restructured to first do the
> override_creds_light() conversion without guards, and then move over
> to guards.   Or the other way round, I don't have a preference.  But
> mixing these two independent changes doesn't sound like a great idea
> in any case.

Sounds good. Here's I am thinking:

patch 1: introduce *_creds_light()
patch 2: move backing-file.c to *_creds_light()
patch 3: move overlayfs to *_creds_light()
patch 4: introduce the guard helpers
patch 5: move backing-file.c to the guard helpers
patch 6: move overlayfs to the guard helpers

(and yeah, the subject of the patches will be better than these ;-)

Is this what you had in mind?


Cheers,
-- 
Vinicius