Received: by 2002:a89:48b:0:b0:1f5:f2ab:c469 with SMTP id a11csp642486lqd; Wed, 24 Apr 2024 12:20:36 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWO5e5bsHBIh4S3yb74rcltpOwXq9TWUi4MZuPC8iGODUfVv3bsD18UHM6gu4+6OFBwfVxS+Rb11krE4Gw58pJq4tH0td8X7/fhF0vChA== X-Google-Smtp-Source: AGHT+IE8S3AwWNCUxbg5nadFGIHL6W7GjpX4AgT8qDC1KrlOUesZ/cYnhHyzfMFbuM3gKU05J1nL X-Received: by 2002:a17:902:e747:b0:1e4:b1ea:23ef with SMTP id p7-20020a170902e74700b001e4b1ea23efmr4548354plf.49.1713986435746; Wed, 24 Apr 2024 12:20:35 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713986435; cv=pass; d=google.com; s=arc-20160816; b=OKVnCCzuKCEMpq+D5P8jPVK172u3cYNkmwepza8oMEZv253ydtew8SSj9jC8itwMEM AKTaoq1wFe0DxuJsg/3NZXN9GxzOo6/m0p7o7GPaPy2Q7ORClx3vyt+9a3fv7ZrMZ6i8 ZuQOUH02kAxJyU4B+vS7xJTL3LNMKRLI1hjg/d6krAw8j4f6C2ceobckPAlfz0FkgHlr gig4OeP4RFgrfvrJ9SufUvXCCfaWdF8VFJUszEfo5YymPs5kxe58KoEVF82PpDMLb7SC OvIlPZBHwf67Maw+Yf7Bvml9lskEii6ExSzqDT6HFj3RRBHDQNZp1XsqlyzKqDftX6OS Zrrw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=4AwOZN/CXJINDZMZm6R7Zvr+ACwmcGZIxMNTmWiwQnk=; fh=m8CHippVYL/WmXGON84XpMkdiEpyh9X14nY5/HGC1yE=; b=ZvhcETymCuPg4I2NQSansi0N6FYWQCXImkgV5g8IxbreVfTLqEvxhq7jJlO/3QM3jJ MILmtUXL9Tyz8ndSVHk69JlS6qAQeCGqPTZz7DClegzKHFul278cHRU5dHoHBalarpWk Ne/ezn+hU6bPx2awVIdXEndAlXH60DlyWPxNEBI3Eq1a2T0sxrX6BEXSXidemxi8T8M2 3w5E+Yw8W26/g71etN4T6sMXfbPvnu4owttSgtBxQZS+gwTFFdDzf/2iUaQ4xEW0A7HB zrkwk5MN34AP5uC3xt4PNjtq1eqdr2wBTwRtIKCjrW5CQOSEq90lmw2je98Wiy9WsL5w QPIQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=N9YffqBo; arc=pass (i=1 spf=pass spfdomain=microchip.com dkim=pass dkdomain=microchip.com dmarc=pass fromdomain=microchip.com); spf=pass (google.com: domain of linux-kernel+bounces-157566-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-157566-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microchip.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id z14-20020a170902ccce00b001debbc0f034si12463638ple.98.2024.04.24.12.20.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 12:20:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-157566-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=N9YffqBo; arc=pass (i=1 spf=pass spfdomain=microchip.com dkim=pass dkdomain=microchip.com dmarc=pass fromdomain=microchip.com); spf=pass (google.com: domain of linux-kernel+bounces-157566-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-157566-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microchip.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id A64B6B2307A for ; Wed, 24 Apr 2024 18:55:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 53FF41BF40; Wed, 24 Apr 2024 18:55:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="N9YffqBo" Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E7EF1CD13; Wed, 24 Apr 2024 18:55:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=68.232.154.123 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713984912; cv=none; b=dPSzY6IQwd1mYDUXHzeouNc16khGzyu2LI6vdeUAstRgExMX8gzkilUihtJ5IWw5EeBgzhDSYTsYl27sSZkbgICE/A/Fx4yW2IHun2LhS1ASgCMCu6wnsE4bEFcN9sIFzl4Jcn4CTDoL+9OC/7or3lJPUuUReQ/KTUpGFRmS1O0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713984912; c=relaxed/simple; bh=9h9XSuWvb5TMFWVoA2JzaGK8vJ7HZ7sMfKj7T0OuiFw=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EqKr18+QEe+m1n8wFT8QTGl3U3ov0T4rDkL1LNQSSkzmD+kwGbuDGmLdU7uCo2F49Zeiwpbmue28nH4Z9k3Gbf2i1MzEzunTqvPBWUXcpniTsi83OVxdc6nIjcqKmyQX+F3NNZdck23qcFdp9qI6DMLqewZ4BavFBsLBhkc82Ww= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com; spf=pass smtp.mailfrom=microchip.com; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b=N9YffqBo; arc=none smtp.client-ip=68.232.154.123 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1713984910; x=1745520910; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=9h9XSuWvb5TMFWVoA2JzaGK8vJ7HZ7sMfKj7T0OuiFw=; b=N9YffqBo0N1tvRP1J6X3l12h3eMhHuEmP9j9JoUXeSOO8TJDEraQn1x/ LlYjE3e+uusAsi/vtBiiwC4M5aCurchKIMCPq7n6asHo3ThQmmgb58fHh aql5P9cwXuNkE0hsB/Jz+pi8Vd9uLf6KLUNTeSt13rFaAQWIhIN9j09Me FZ+JLd2tBGLzBL70ITXwLVM4Q2N6ylmyKlq1oZha6lniDwPyNeDxiwLYB 6RUmx51lkWp2C3DuoqzG+kMmX5jGcXQr0xQ3doTl7bSyz63bXdUNWzuBn O9nC38Yhw9VCarL1i1dDEO5Dwcv+dsYFP0tZ97uLEjHEW35blMIzzQuUB g==; X-CSE-ConnectionGUID: vKyXeTDKRPST0335z8A8qQ== X-CSE-MsgGUID: AJXK7MjuTSG+e9x+TXfBow== X-IronPort-AV: E=Sophos;i="6.07,227,1708412400"; d="scan'208";a="23075848" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 24 Apr 2024 11:55:09 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.87.72) by chn-vm-ex02.mchp-main.com (10.10.87.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 24 Apr 2024 11:54:56 -0700 Received: from localhost (10.10.85.11) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.2507.35 via Frontend Transport; Wed, 24 Apr 2024 11:54:56 -0700 Date: Wed, 24 Apr 2024 20:54:55 +0200 From: Horatiu Vultur To: =?utf-8?Q?Asbj=C3=B8rn_Sloth_T=C3=B8nnesen?= CC: , , "David S. Miller" , Eric Dumazet , "Jakub Kicinski" , Paolo Abeni , , Jiri Pirko , Simon Horman Subject: Re: [PATCH net-next v2 0/3] net: lan966x: flower: validate control flags Message-ID: <20240424185455.p35dp3sqnlugxenv@DEN-DL-M31836.microchip.com> References: <20240424125347.461995-1-ast@fiberby.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240424125347.461995-1-ast@fiberby.net> The 04/24/2024 12:53, Asbjørn Sloth Tønnesen wrote: > > This series adds flower control flags validation to the > lan966x driver, and changes it from assuming that it handles > all control flags, to instead reject rules if they have > masked any unknown/unsupported control flags. For the entire series: Reviewed-by: Horatiu Vultur > > --- > Changelog: > > v2: > * Split first patch into 2 (requested by Jiri) > * Added cover letter (requested by Simon) > > v1: https://lore.kernel.org/netdev/20240423102720.228728-1-ast@fiberby.net/ > > Asbjørn Sloth Tønnesen (3): > net: lan966x: flower: add extack to > lan966x_tc_flower_handler_control_usage() > net: lan966x: flower: rename goto in > lan966x_tc_flower_handler_control_usage() > net: lan966x: flower: check for unsupported control flags > > .../ethernet/microchip/lan966x/lan966x_tc_flower.c | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > > -- > 2.43.0 > -- /Horatiu