Received: by 2002:a89:48b:0:b0:1f5:f2ab:c469 with SMTP id a11csp645142lqd; Wed, 24 Apr 2024 12:25:52 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWQtrboLvui51iqTDpcYMpV8cONLCeY5mObwom8Z9SdtwuX58464AAukXs/X4apEeKJ0XSaLnaukEM88lAPaqSxESgDUPhwV9hz3CbgCQ== X-Google-Smtp-Source: AGHT+IH1tSgXAgPelIvG666RtjWZQVEZ3o3GBnwiyLrYbIYLBCkNJiitTnUwPRJLxlQBVjWXVrmr X-Received: by 2002:a17:902:8ecc:b0:1ea:274:7570 with SMTP id x12-20020a1709028ecc00b001ea02747570mr3230971plo.31.1713986751803; Wed, 24 Apr 2024 12:25:51 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713986751; cv=pass; d=google.com; s=arc-20160816; b=yl6CTMxueIS9BJveNUJEIVsIiSXueLTuKRO5+RcA4MOF8NliVuwtitND0OpeYwD40/ fgzGY7wiTOPYJd7jfjH4T55mxrftFknKHKVCbTtiLy3h/EIpiq6H5qaMx+n6cdQnLO/I TDIsVSGd89PHUBiq3V5I8v1Wfxe3hVTPqS3uO9Nlp4YpQSeoXYHkQ/hpe4QgApj+s0NM zFxIiVHpR5g/KRMTEMHpf4BRQO4VgCqtA0KAeyNmnBG4zw3cCT2QbmhJASIqGSKqmOix 23QqevTK1rd/QUg193ADkYOVOqN67k1VOcl8dAhOPJPrEJU1ygbzm1Ltaw2qvyDImHPk WYZA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=8/pJWBK7NCR8cJ86fTwUM8CwNOEjC8NWwcVYq5e+ko0=; fh=whn9FzAUpcQHAO/XwFto8bLvZ06m1nt89vGGqEVvpEQ=; b=f+oDh4I6YHm3eaMiCjECaRAuvlcqd0JCIXfo+Wnou+fFpRYA91Qe6nWtsaqufZRFBE tDCloL56xD4qYHL/3UCEdiGzUIYtf4KTg8JNwSlZt7xqvOUh/IN6qtY9Ovk5i2IVwAor TeuL1JhEAcPrXeMPHFrC9WCrBe9JYdQcB3Gui8nytaG47t+GW3gF2bwtQObIY3GkE8ZX vYiuN3bMIo+tEyMdWGDddU3FfLnzj2yEitvOxUz7CuCc5V/rjO7a3Z4lBjR4j8Z/4X+H Ln2/jtVSMlFFOuh7C8RC4gOWa5mHXosqTfOWathN6FXPNRw58NghdFq1zP1+x06dL+lE ie3g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=zxnjUag+; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-156899-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-156899-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id e14-20020a170903240e00b001e3db9672dfsi11926636plo.567.2024.04.24.12.25.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 12:25:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-156899-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=zxnjUag+; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-156899-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-156899-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 0C7C4B27065 for ; Wed, 24 Apr 2024 12:52:37 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9947E15B124; Wed, 24 Apr 2024 12:52:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="zxnjUag+" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85410134A5; Wed, 24 Apr 2024 12:52:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713963146; cv=none; b=mJvZyfqfOrjIRfY8UIpqohYf7JGc6ED7fu6d5NTnwCagSqvvbJfOKmsBykSyWI8tZOqoo4GR3m7I7RAIccYMg7GNdiCX72T3cmlwS8SaDT3UVr2xKc+yBk2hch0QktI2KoYbSSpoz7jRs5OmSx5nc01HINsBtjE59UBcYiO7NCM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713963146; c=relaxed/simple; bh=vanSXdv4Y6JZfy9ZTweKXIH65775yaAoxSbG12Wme1Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Pgz4p0cdBBQH9+Y4BJ27EHcu+xV4ys24JWQT2RS+Ldjxd3T6+AFKwUcw5/O/JERxLfIM94FYSUK+uTEwvHdVEAbPJ3Dm7LOiF97i9gEJaUYy6mCK1C+76etviQa1fjIU8IN7pvjew+owYcSoYwsOniKSeKKMr7Ixxle05w4xTa0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=zxnjUag+; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=8/pJWBK7NCR8cJ86fTwUM8CwNOEjC8NWwcVYq5e+ko0=; b=zxnjUag+JE3XLLairBeEV7ILY7 Iae8+V/6QtRA2b3lzUJ49mVXMNqMEDYByamF8gmOkZzKmXu98xegf4oFjgL4CvsSl3yXss6XD7F+K Db/PdPuyN2qfC0vN8oy0DL4+/GmOAPoD9Jhgr22/9+y3jrpZ6gs901hD0zZPoPX6OXM8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rzc6g-00DoYj-HQ; Wed, 24 Apr 2024 14:52:14 +0200 Date: Wed, 24 Apr 2024 14:52:14 +0200 From: Andrew Lunn To: Matthias Schiffer Cc: Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux@ew.tq-group.com Subject: Re: [PATCH net-next] net: phy: marvell: add support for MV88E6020 internal PHYs Message-ID: References: <20240424121022.160920-1-matthias.schiffer@ew.tq-group.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240424121022.160920-1-matthias.schiffer@ew.tq-group.com> On Wed, Apr 24, 2024 at 02:10:22PM +0200, Matthias Schiffer wrote: > The embedded PHYs of the MV88E6020 (88E6250 family) switch are very > basic - they do not even have an Extended Address / Page register. > +static struct marvell_hw_stat marvell_hw_stats_88e6020[] = { > + { "phy_receive_errors", 0, 21, 16}, So the 0 here is bogus? This patch is quite invasive, and it is hard to say it is worth it. I would probably not try to reuses as much code, add functions which are specific to the 6250. Keep it KISS. Andrew