Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758158AbYA0GE4 (ORCPT ); Sun, 27 Jan 2008 01:04:56 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757879AbYA0GES (ORCPT ); Sun, 27 Jan 2008 01:04:18 -0500 Received: from smtp2.linux-foundation.org ([207.189.120.14]:53213 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757850AbYA0GEQ (ORCPT ); Sun, 27 Jan 2008 01:04:16 -0500 Date: Sat, 26 Jan 2008 22:01:51 -0800 From: Andrew Morton To: Tim Bird Cc: a.p.zijlstra@chello.nl, rostedt@goodmis.org, dwalker@mvista.com, linux-kernel@vger.kernel.org, mingo@elte.hu, torvalds@linux-foundation.org, hch@infradead.org, mathieu.desnoyers@polymtl.ca, ghaskins@novell.com, acme@ghostprotocols.net, tglx@linutronix.de, sam@ravnborg.org, fche@redhat.com, jan.kiszka@siemens.com, johnstul@us.ibm.com, arjan@infradead.org, srostedt@redhat.com Subject: Re: [PATCH] defer printks in irqs Message-Id: <20080126220151.784893b1.akpm@linux-foundation.org> In-Reply-To: <47991DD7.9070009@am.sony.com> References: <20080123160236.969334052@goodmis.org> <20080123160441.236562634@goodmis.org> <1201107978.13596.16.camel@imap.mvista.com> <1201110185.13596.22.camel@imap.mvista.com> <47991454.50603@am.sony.com> <1201214935.6341.105.camel@lappy> <47991DD7.9070009@am.sony.com> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.19; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 986 Lines: 23 > On Thu, 24 Jan 2008 15:23:03 -0800 Tim Bird wrote: > Peter Zijlstra wrote: > > I suspect these features reduce the chance a crash messages makes it out > > onto the console, but fail to spot any of the copious text mention this > > critical issue. > > Anything not in interrupts would not be deferred. > The following code is meant to avoid deferring in oops as well. > I'm not sure if that covers all crash cases or not. > If you know of other cases, and ways to detect them, please advise. > Yes, using oops_in_progress seems an appropriate fix for that. I assume that another downside is that printk-from-interrupt will now get jumbled up with an interrupted pritk-from-non-interrupt. Please use checkpatch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/