Received-SPF: pass (google.com: domain of linux-kernel+bounces-157661-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 24 Apr 2024 15:11:05 -0500
From: Rob Herring <robh@kernel.org>
To: Ji Sheng Teoh <jisheng.teoh@starfivetech.com>
Cc: Mark Brown <broonie@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Michal Simek <michal.simek@amd.com>,
	Ley Foon Tan <leyfoon.tan@starfivetech.com>,
	linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Eng Lee Teh <englee.teh@starfivetech.com>
Subject: Re: [PATCH v1 2/2] dt-bindings: spi: spi-cadence: Add optional reset
 control
Message-ID: <20240424201105.GA428137-robh@kernel.org>
References: <20240424051317.2084059-1-jisheng.teoh@starfivetech.com>
 <20240424051317.2084059-3-jisheng.teoh@starfivetech.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240424051317.2084059-3-jisheng.teoh@starfivetech.com>

On Wed, Apr 24, 2024 at 01:13:17PM +0800, Ji Sheng Teoh wrote:
> Document the optional reset control to SPI.
> 
> Signed-off-by: Eng Lee Teh <englee.teh@starfivetech.com>
> Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com>
> Signed-off-by: Ji Sheng Teoh <jisheng.teoh@starfivetech.com>

3 people developed 4 lines of code? Generally the first S-o-b should be 
the author (.i.e. a From line).

> ---
>  Documentation/devicetree/bindings/spi/spi-cadence.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/spi-cadence.yaml b/Documentation/devicetree/bindings/spi/spi-cadence.yaml
> index d4b61b0e8301..2358489be4bc 100644
> --- a/Documentation/devicetree/bindings/spi/spi-cadence.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-cadence.yaml
> @@ -55,6 +55,11 @@ properties:
>    label:
>      description: Descriptive name of the SPI controller.
>  
> +  resets:
> +    description: |
> +      Optional entry to specify the reset controller to the SPI

Drop the description.

> +    maxItems: 1
> +
>  required:
>    - compatible
>    - reg
> -- 
> 2.43.2
>