Received-SPF: pass (google.com: domain of linux-kernel+bounces-157634-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Wed, 24 Apr 2024 12:57:53 -0700
From: Ira Weiny <ira.weiny@intel.com>
To: Dave Jiang <dave.jiang@intel.com>, <ira.weiny@intel.com>, Fan Ni
	<fan.ni@samsung.com>, Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	"Navneet Singh" <navneet.singh@intel.com>
CC: Dan Williams <dan.j.williams@intel.com>, Davidlohr Bueso
	<dave@stgolabs.net>, Alison Schofield <alison.schofield@intel.com>, "Vishal
 Verma" <vishal.l.verma@intel.com>, <linux-btrfs@vger.kernel.org>,
	<linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 16/26] cxl/extent: Realize extent devices
Message-ID: <66296441d655a_e9f9f29497@iweiny-mobl.notmuch>
References: <20240324-dcd-type2-upstream-v1-0-b7b00d623625@intel.com>
 <20240324-dcd-type2-upstream-v1-16-b7b00d623625@intel.com>
 <10a45890-422d-4956-bfe0-101eee23b323@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <10a45890-422d-4956-bfe0-101eee23b323@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OgBNrbUHg+l5zwhYJGRgBXzbVlZ6iELcBbPkOfzLnN01tR2g3FD1lG79cKHB?=
 =?us-ascii?Q?xYwNhRHfMGfcAuwJSePlugRaFln6Bovd8O6JYjmozeuzADq+frUSE9U0ruxL?=
 =?us-ascii?Q?nV8ZbtEC+82QPTG1Y7MG9/7S9J/mvI0AYXnQI6UC2BGCc6HFWpDWkozDVyKS?=
 =?us-ascii?Q?UGSpDyqY2mWrHxqiqHSpDg8zvMxJEYZjfCTyGbassRKp5EwTHJIlAHhr/fgu?=
 =?us-ascii?Q?akeQCWA3Ud+hYmeyHFr38O9kYDkcc8QLV97MGyxvu7CexO2ekvbE+MSvx8hR?=
 =?us-ascii?Q?cUW112AKhBKJaEMYqjh+gR2GL7Rw3hMyIWlwIK5zX7stKaC70RnQBZNbR91u?=
 =?us-ascii?Q?BwDGPmNgNvXQvq/MtiDg1JLDKgOLwee47+emOYuk/OY/jft0tUJJKJosb5Wa?=
 =?us-ascii?Q?0otno0LqR/WIUxYdHUsO6zq+oL5U2fP19MBWgsMzy5UeQOLgG0XbkUoRrqAT?=
 =?us-ascii?Q?ZZwzXR8AQU1VUp9r5C3z81/htreLCukOFfNfd1BOd9vn4bGA+nR69wsCxwOr?=
 =?us-ascii?Q?5TLpcSvSv6IQ+EjMPMwgcjd6l8O7GmoYnQEpm+IZQVyYxI5999jx1SevIi0b?=
 =?us-ascii?Q?bIZ/YMSPJx5g26grgjgZXG0WWApQUcknW9AIVFJB8GMJELaZgXU6N6FeD+mF?=
 =?us-ascii?Q?2lsOJKeZH/fGpZqryrpnLxFv8LnfRI5QgcOBZWajcGVw8c1QuZL8Us9PhDsL?=
 =?us-ascii?Q?6arHoTZSz3ncDzZQMy7wT8ug+Flru/cw99shN3s+plTKgKdqcrK37wYcSmKv?=
 =?us-ascii?Q?pc4JHN9lLNPU6IqH+11MUsMNhuP1nSq2tCvgdjD0LUw3Bk3gsoYR4/y7GA1A?=
 =?us-ascii?Q?s4ysgHRjk/qcxN0BjYDhd8N2FdBbjB9g7UG2A8tzNq4AkID8qkqBSRgM5lvP?=
 =?us-ascii?Q?Zl1pIejt4b82BBcFhn3CmVspKAq52W30udBMHZyDNFCfYxHKFAymsDoCy+Ku?=
 =?us-ascii?Q?AWBebZ8zqPeMySWn8dYMSZVQO7t+dECYboRArKVgTe1j26re0qu3NHaTSk/D?=
 =?us-ascii?Q?U2jZll08RWqkD6V/BDsu40AReyV0IbirjViQ/TVr6p4YvegIqhNZlr6cZ8W+?=
 =?us-ascii?Q?NkGyElD1UZortrjTqIamw32zG9Kg45B9a2nJds6gQWOCJAQraViVBc+mJpmu?=
 =?us-ascii?Q?21qCUeQjBcoCGilwgkqJkmPHJNJaubrOxH1EeRLofry0dOURNORVv3JTpYaR?=
 =?us-ascii?Q?8fQrS0tdjMKSX7Go2U6J9YxFGkaaqpJf7ZVwhsDXklYRtCqMSGDGpMs4PGY5?=
 =?us-ascii?Q?LKln4t3qarG8G6voeSWqPFsGkaqTv5+iVWfa5OPf+50P9aIvdoN3hH2V06ui?=
 =?us-ascii?Q?Di9VFS9SQ/VQyG5Qfj/tgHb6y19JPNBsLI96rhhWj4q+AZV/IqbLhXmud5Fz?=
 =?us-ascii?Q?drB3UCats9s/jmgHe0+9y2EA5ilW/GpDIQfJoM+pTygyOganDobfu6asSX6H?=
 =?us-ascii?Q?KwveHTZy7h6TCFjepEE9LIPJHdj+OUB1C0gx4K+ZhtcAzPUixNui2rdsCvXR?=
 =?us-ascii?Q?STNkpxV5KFFaOYmCYiJ2M+fXHQSC5ImToFl4TWqqRRUth4GTrbcD+upz7T+L?=
 =?us-ascii?Q?IFZirx5vYbIbUUQ5WI2CP1w3GCh8w7UVkbxHtOpq?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 006d4b6e-4455-4d72-5c70-08dc6498d6e3
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2024 19:57:58.4517
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: o/a4hZ2JseV1e4hv3ctCwxAMFewqJGUbcTC0FwSGgJdXGpMj7v/sU7s+L6zn0luRG1CYkJKk1Hi6NaCUbEGr5g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6925
X-OriginatorOrg: intel.com

Dave Jiang wrote:
> 
> 
> On 3/24/24 4:18 PM, ira.weiny@intel.com wrote:
> > From: Navneet Singh <navneet.singh@intel.com>
> > 

[snip]

> > diff --git a/drivers/cxl/core/extent.c b/drivers/cxl/core/extent.c
> > new file mode 100644
> > index 000000000000..487c220f1c3c
> > --- /dev/null
> > +++ b/drivers/cxl/core/extent.c
> > @@ -0,0 +1,133 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/* Copyright(c) 2024 Intel Corporation. All rights reserved. */
> > +
> > +#include <linux/device.h>
> > +#include <linux/slab.h>
> > +#include <cxl.h>
> > +
> > +static DEFINE_IDA(cxl_extent_ida);
> 
> According to Documentation/core-api/idr.rst, IDR interface is deprecated and
> xarray usage is preferred.

IDA != IDR

ida_alloc() provides a unique, unused id for the device.  I worked hard to
eliminate all extra references to the extent objects so as to ensure object
lifetimes.  So I'm keeping this for now.

> > +
> > +static ssize_t offset_show(struct device *dev, struct device_attribute *attr,
> > +			 char *buf)
> 
> Parameter alignment a bit off here? and some of the other functions as well.

Thanks, fixed.

[snip]

> > diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
> > index 9e33a0976828..6b00e717e42b 100644
> > --- a/drivers/cxl/core/mbox.c
> > +++ b/drivers/cxl/core/mbox.c
> > @@ -1020,6 +1020,32 @@ static int cxl_clear_event_record(struct cxl_memdev_state *mds,
> >  	return rc;
> >  }
> >  
> > +static int cxl_send_dc_cap_response(struct cxl_memdev_state *mds,
> > +				    struct range *extent, int opcode)
> > +{
> > +	struct cxl_mbox_cmd mbox_cmd;
> > +	size_t size;
> > +
> > +	struct cxl_mbox_dc_response *dc_res __free(kfree);
> > +	size = struct_size(dc_res, extent_list, 1);
> > +	dc_res = kzalloc(size, GFP_KERNEL);
> > +	if (!dc_res)
> > +		return -ENOMEM;
> > +
> > +	dc_res->extent_list[0].dpa_start = cpu_to_le64(extent->start);
> > +	memset(dc_res->extent_list[0].reserved, 0, 8);
> 
> Not needed. kzalloc already zeroed.

Thanks, Fan mentioned it too.

Ira