Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754565AbYA0GnT (ORCPT ); Sun, 27 Jan 2008 01:43:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751100AbYA0GnN (ORCPT ); Sun, 27 Jan 2008 01:43:13 -0500 Received: from smtp2.linux-foundation.org ([207.189.120.14]:50057 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750792AbYA0GnM (ORCPT ); Sun, 27 Jan 2008 01:43:12 -0500 Date: Sat, 26 Jan 2008 22:42:28 -0800 (PST) From: Linus Torvalds X-X-Sender: torvalds@www.l.google.com To: Rusty Russell cc: Greg KH , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [GIT PATCH] driver core patches against 2.6.24 In-Reply-To: <200801261550.58337.rusty@rustcorp.com.au> Message-ID: References: <20080125071127.GA4860@kroah.com> <20080125194219.GA4596@suse.de> <200801261550.58337.rusty@rustcorp.com.au> User-Agent: Alpine 1.00 (LFD 882 2007-12-20) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1222 Lines: 39 On Sat, 26 Jan 2008, Rusty Russell wrote: > > module.c:1832 (in load_module) > > if (find_module(mod->name)) { > err = -EEXIST; > goto free_mod; > } > > That's pretty early, and before this backtrace. > > Even for simultaneous loads, there's a mutex which protects from here to the > list insertion. My problem isn't trying to load the same module twice. My problem is that the *driver* already exists (because it's compiled in), and has already initialized itself, and has already registered. Then, initrd tries to load an old module for that driver. So no simultaneous loading, no two modules, simple two *drivers* with the same module names - but one was compiled in, and the other will fail because it doesn't have the required linkages (ie it will failt the modversions checks). But even before it fails the modversion checks, it apparently does various ugly things that clash with the built-in driver. At least that seems to be the case. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/