Received-SPF: pass (google.com: domain of linux-kernel+bounces-157732-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 24 Apr 2024 14:20:09 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Lance Yang <ioworker0@gmail.com>
Cc: Matthew Wilcox <willy@infradead.org>, maskray@google.com,
 ziy@nvidia.com, ryan.roberts@arm.com, david@redhat.com, 21cnbao@gmail.com,
 mhocko@suse.com, fengwei.yin@intel.com, zokeefe@google.com,
 shy828301@gmail.com, xiehuan09@gmail.com, wangkefeng.wang@huawei.com,
 songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org,
 linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] mm/vmscan: avoid split PMD-mapped THP during
 shrink_folio_list()
Message-Id: <20240424142009.149eb988cca33822ce0fd0f1@linux-foundation.org>
In-Reply-To: <CAK1f24kaHcKOS1ajfLney-1+Pqrwrk_0LWqRr2DmZ+41YBzXug@mail.gmail.com>
References: <20240422055213.60231-1-ioworker0@gmail.com>
	<ZiiHSwG_bnLJbwfb@casper.infradead.org>
	<CAK1f24kaHcKOS1ajfLney-1+Pqrwrk_0LWqRr2DmZ+41YBzXug@mail.gmail.com>
Precedence: bulk
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On Wed, 24 Apr 2024 23:46:59 +0800 Lance Yang <ioworker0@gmail.com> wrote:

> On Wed, Apr 24, 2024 at 12:15 PM Matthew Wilcox <willy@infradead.org> wrote:
> >
> > On Mon, Apr 22, 2024 at 01:52:13PM +0800, Lance Yang wrote:
> > > When the user no longer requires the pages, they would use
> > > madvise(MADV_FREE) to mark the pages as lazy free. IMO, they would not
> > > typically rewrite to the given range.
> > >
> > > At present, PMD-mapped THPs that are marked as lazyfree during
> > > shrink_folio_list() are unconditionally split, which may be unnecessary.
> > > If the THP is clean, its PMD is also clean, and there are no unexpected
> 
> "If the THP is clean, its PMD is also clean" can be confusing - sorry. It should
> be modified to "If the THP and its PMD are both marked as clean".

I made that changelog edit.