Received: by 2002:a89:48b:0:b0:1f5:f2ab:c469 with SMTP id a11csp726361lqd; Wed, 24 Apr 2024 15:20:27 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW+GXDK3iWejQEiFZKilbqLWx9cxfJipDOkqICwMOMGw3bXKJUNtDKev1ItdyIwyAUAXzWcJr3/FVY0CYLsYRdrLJQLinZ2TrT3mP/Qzw== X-Google-Smtp-Source: AGHT+IHMW5teKmhNV/KCqXe6MBuSt9GB3nG1b4QgGMcAEIEe2IyWFZS4S2GpIbldX34lOi3F1zWg X-Received: by 2002:a25:870d:0:b0:de4:5e52:9eb with SMTP id a13-20020a25870d000000b00de45e5209ebmr4346913ybl.57.1713997226737; Wed, 24 Apr 2024 15:20:26 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713997226; cv=pass; d=google.com; s=arc-20160816; b=utYcD4tHRuoQoZcgOPQ8gOIg5zdMcMt6iS5Y0/3ZfynPSQWecyj4Sa2sOc72NAV+W6 p3P/GwkmCB7PMcEGpPWEr13arcwMPndekUko8nfvHtpRuYf3N81+haSNRnjDdbbXEKJS OSQOspqfNtDI2wNk1eKOgYCuPPOhPPk8y3U9pYtw1++0fqHmCtydr0xwEWdiLQrcfq7z vH82+P7/ZEZlWCFK4iztjynJalLSOACpNbs/ezLS5HA6UPT+ikrnNIrXsSioXHHGxHzm Gejn4IbKsP70nHBIb6A8DVzwTYamNMCYuVMBmCvcLm4n6bd8ej/QXSBauIIclsefBQZE Cadg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date; bh=pVmVfqFymUDJiJ/yKKjabCfDAjju2hzjoA400lgjjRg=; fh=L8MUQ2vf4m1sqQF+k4dzZiIogMJVd4WsOWwCRVnZAvI=; b=trxmYGF6eJVyYxsbW+AgYJsBnhc2vNdmZnwsh7b79B2Ar1Q3XaWUd6oNUWN9ginHaM 6UmM3TgVTpxY5CFIydAV12l6VB4Gd2mZ5qMYFRkga/+SNP2+uNYiqLapYDGudjSL1afd VNqzooGHjl9k0eCbVsJfFcHejBYZRfkYnbsvVlGCDt+vP5XWR+8YEMdztiTGP4D+n1EH XFz8vQE7DR745AvSpGq5ki9J0Ig70U2KbN9k7wub07KLVTRbFO4LirS8jyuUkPbZ0gwT gilGOHPz5kzmq854cx+qCUeZM8IucpZucp0oDEJGnb5pIwdGn2Xc9kMXUNhZnh3tkmLp SQVg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=netfilter.org); spf=pass (google.com: domain of linux-kernel+bounces-157776-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-157776-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id e11-20020ad442ab000000b006a07edd8e83si7731638qvr.111.2024.04.24.15.20.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 15:20:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-157776-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=netfilter.org); spf=pass (google.com: domain of linux-kernel+bounces-157776-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-157776-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 4B07D1C22A9A for ; Wed, 24 Apr 2024 22:20:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C46ED16C87B; Wed, 24 Apr 2024 22:20:15 +0000 (UTC) Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DA6B213AD0D; Wed, 24 Apr 2024 22:20:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.188.207 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713997215; cv=none; b=XvkSJHbd01Pn7xBg/guPjhX0mzhpavQ8ZbqS/14hLBfCLWBTV1MZTEoRNa8Bh/WKM1XZIvTzMGSIh0z17mcQhHt2EXiXIscMuAieeBbjkJ1D2gUXOEg8nWjOe2RokF5JE27AEe2HoAI4kWG0VHYUZdJSlmwjaWL1JcsOIl44J2g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713997215; c=relaxed/simple; bh=2SanSr9ivrXvN7XrjSoc2KbOt8Z+ZjzTk7lp7LZ4U1M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QKMB7uwYGZ9tP2a/bg/VzeGHOuknfV8mjcM/5RwLjOXfEggl2JMbVWBUEAoqh98jaqSjpQVYT/pQ1eOWNXZoWZZr5Mjpu3q381WW21pET6wG98mejh5gMhxOZfG+ENcKnoCduNZlupxz/HrZi5qgCP7bPWzzExLFqmiavv8yfjA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org; spf=pass smtp.mailfrom=netfilter.org; arc=none smtp.client-ip=217.70.188.207 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=netfilter.org Date: Thu, 25 Apr 2024 00:20:09 +0200 From: Pablo Neira Ayuso To: Florian Westphal Cc: linke li , xujianhao01@gmail.com, Jozsef Kadlecsik , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: mark racy access on ext->gen_id Message-ID: References: <20240423120309.GA18954@breakpoint.cc> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240423120309.GA18954@breakpoint.cc> On Tue, Apr 23, 2024 at 02:03:09PM +0200, Florian Westphal wrote: > linke li wrote: > > In __nf_ct_ext_find(), ext->gen_id can be changed by > > nf_ct_ext_valid_post(), using WRITE_ONCE. Mark data races on ext->gen_id > > as benign using READ_ONCE. > > > > This patch is aimed at reducing the number of benign races reported by > > KCSAN in order to focus future debugging effort on harmful races. > > Acked-by: Florian Westphal > > Should proably go to nf tree. Can I get a Fixes: tag for this one?