Received: by 2002:a89:48b:0:b0:1f5:f2ab:c469 with SMTP id a11csp733215lqd; Wed, 24 Apr 2024 15:37:34 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVdHYVrje1bFiCsx3Mg+ec/gIM/HQzvyYCD98RZBzhiUgSYVKdiqTWxJMTi4aA4wk8g9TDh9m4JDzq7/p92wFN/IIwCMrXBSNI+hbfWEw== X-Google-Smtp-Source: AGHT+IHd3dBtDe69ktP/2kJqnn6k4yM66i5uZHmSOgD9+Mv+5LDhQX7HyVk+RXHUJVNTEkv7pw8P X-Received: by 2002:a0c:d791:0:b0:6a0:911f:4add with SMTP id z17-20020a0cd791000000b006a0911f4addmr1747682qvi.26.1713998254607; Wed, 24 Apr 2024 15:37:34 -0700 (PDT) Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id g15-20020a0562141ccf00b0069b51757382si15570123qvd.322.2024.04.24.15.37.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 15:37:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-157793-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b="xJ+Lt+/X"; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-157793-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-157793-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 4BD081C21494 for ; Wed, 24 Apr 2024 22:37:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BFE2316DED8; Wed, 24 Apr 2024 22:37:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="xJ+Lt+/X" Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C0282263E for ; Wed, 24 Apr 2024 22:37:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713998247; cv=none; b=TJ6TNVft1mV3M3VnfaN2k1DBN4h0GLCHXy154OPVnO55OrysgkqZ+Mv83IN2l5WgT9L2eBcqH8pygdN6pkauBQxIGi+lsiiyWuuliOerAwVaNHiF7MVNmFi76y1gREya1o6Wwfk5Cav1noEzdlEIJ30fGHMV+A+kgZEbqYOXGRQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713998247; c=relaxed/simple; bh=qVRTzUA+MWdKY71cY09kaWnQVDV6+oWl0Dkhha0WLr4=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=T2cKtm/WNu2+nfhbE3dCoEhu6Ztd3U3/PUD16mA2yDLmTf8WI639rlsI9WJg7z3Nn4y8QmSEqgBKG9Ag9lX+i6y1YTKsdx5xkcYnlKT6IgWoeZ+KDZgfcRczmhjAhgihbOzYvbo3Rc39wzTrOlzErZT28YP6BauQOzi/YTtL6Fc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=xJ+Lt+/X; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1e2c725e234so12022615ad.1 for ; Wed, 24 Apr 2024 15:37:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1713998245; x=1714603045; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=aO8Rp7JUgS7Xhpz5uMrLG4WHnD0bm/FTRd8cK1NaJfI=; b=xJ+Lt+/X6MMZ5Q/Sut655bxWSIaz7RYlmkWVsX8IL4gr0y2D6XDI0AHBKu7H8Kzn/0 Qjcjkx96mOlaHi/tJYvCXC6kDKFCnsc81WArKY+aB6kaYvgpzLw9Oos9p6g9J2Jj9rvW VgfQ8ywAvLxVBj+VSiWyI56uuFalTXq6TZ01TUlnahI/yImgBsjSuZscuFfftAKdGr1L NUrKrgQ2uTtM1NSqeUwrRNfSxR7KSMvDTaGHBGiPimJSS5a7HgudZxiLiF6aMCGS8yH0 Pv9MNz4IoYNSmUR2N0hIDmjY7YVnzdghnvJtdbTXj7SkYnv27/fBIlq95kdrxJDU87Uh tPvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713998245; x=1714603045; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aO8Rp7JUgS7Xhpz5uMrLG4WHnD0bm/FTRd8cK1NaJfI=; b=XOZ7vPQk99/EoyKJPhdxVqrj35Dv2e/k8sJ0iXYl/Y5PJgadA6yXzpotdH5w1Eq773 TJxnQ/qtOesEM/K0psC0s3AB3nQqDUwFeTF8mz+w0vfH7S+txKh5P6LaRSLcMFQM/rIJ zawzs73a3oliqWB9V/C3L44pAy6oRckRTy/p77FzFlBwI35LLoax4fVOcUujbohcvg27 Z7vKL9+BpFJOH46Dentted3qUndRVaVF/EkC2C6juQb7FZ+ObKtAjdj5BHucTgCS+VR+ UeA8YZlto1kaP8xdOB1KtwbIYWSLIP0pz4XGl7brU0oJOQJrpQYDsN0xRU02lFyRbQTa Oxjg== X-Forwarded-Encrypted: i=1; AJvYcCW70Cq5IUH4sRtegoJDF64Q1M5T/wnFSqXLgCq1SSQlGSDOZZSCxwXldQUrb/798fqGjrX5MgcrGatEEUTCrQ/fRGD3g1k7gLH5bhSh X-Gm-Message-State: AOJu0YyVtLYZh3n4fjgALjmarDYzDGjZltS54xG4D+vczfwILtHDBlKM gDGDNtu3Q3jURjTWj1zO6/91eotXNxpTXSVuF8CRQvpJOus5ocls2xIy3baSzCFooJlaLvrxgf+ jdw3ZyZvdXAzAyy/ObeFh3FXDrRl2qX5RUNB49Q== X-Received: by 2002:a17:90b:4d8d:b0:2af:c3ea:8122 with SMTP id oj13-20020a17090b4d8d00b002afc3ea8122mr338008pjb.7.1713998245527; Wed, 24 Apr 2024 15:37:25 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240418-approach-liquefy-04551ddefbc4@spud> In-Reply-To: <20240418-approach-liquefy-04551ddefbc4@spud> From: Tomasz Jeznach Date: Wed, 24 Apr 2024 15:37:14 -0700 Message-ID: Subject: Re: [PATCH v2 1/7] dt-bindings: iommu: riscv: Add bindings for RISC-V IOMMU To: Conor Dooley Cc: Joerg Roedel , Will Deacon , Robin Murphy , Paul Walmsley , Palmer Dabbelt , Albert Ou , Anup Patel , Sunil V L , Nick Kossifidis , Sebastien Boeuf , Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, iommu@lists.linux.dev, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux@rivosinc.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Apr 18, 2024 at 10:04=E2=80=AFAM Conor Dooley wr= ote: > > On Thu, Apr 18, 2024 at 09:32:19AM -0700, Tomasz Jeznach wrote: > > Add bindings for the RISC-V IOMMU device drivers. > > > > Co-developed-by: Anup Patel > > Signed-off-by: Anup Patel > > Signed-off-by: Tomasz Jeznach > > --- > > .../bindings/iommu/riscv,iommu.yaml | 149 ++++++++++++++++++ > > MAINTAINERS | 7 + > > 2 files changed, 156 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/iommu/riscv,iommu= yaml > > > > diff --git a/Documentation/devicetree/bindings/iommu/riscv,iommu.yaml b= /Documentation/devicetree/bindings/iommu/riscv,iommu.yaml > > new file mode 100644 > > index 000000000000..d6522ddd43fa > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iommu/riscv,iommu.yaml > > @@ -0,0 +1,149 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/iommu/riscv,iommu.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: RISC-V IOMMU Architecture Implementation > > + > > +maintainers: > > + - Tomasz Jeznach > > + > > +description: |+ > > FYI, the + here is probably not needed. > > > + The RISC-V IOMMU provides memory address translation and isolation f= or > > + input and output devices, supporting per-device translation context, > > + shared process address spaces including the ATS and PRI components o= f > > + the PCIe specification, two stage address translation and MSI remapp= ing. > > + It supports identical translation table format to the RISC-V address > > + translation tables with page level access and protection attributes. > > + Hardware uses in-memory command and fault reporting queues with wire= d > > + interrupt or MSI notifications. > > + > > + Visit https://github.com/riscv-non-isa/riscv-iommu for more details. > > + > > + For information on assigning RISC-V IOMMU to its peripheral devices, > > + see generic IOMMU bindings. > > + > > +properties: > > + # For PCIe IOMMU hardware compatible property should contain the ven= dor > > + # and device ID according to the PCI Bus Binding specification. > > + # Since PCI provides built-in identification methods, compatible is = not > > + # actually required. For non-PCIe hardware implementations 'riscv,io= mmu' > > + # should be specified along with 'reg' property providing MMIO locat= ion. > > I dunno, I'd like to see soc-specific compatibles for implementations of > the RISC-V IOMMU. If you need a DT compatible for use in QEMU, I'd > suggest doing what was done for the aplic and having a dedicated > compatible for that and disallow having "riscv,iommu" in isolation. > Makes sense. Will update to something like below: compatible: oneOf: - items: - enum: - qemu,iommu - const: riscv,iommu - items: - enum: - pci1efd,edf1 - const: riscv,pci-iommu > > + compatible: > > + oneOf: > > + - items: > > + - const: riscv,pci-iommu > > + - const: pci1efd,edf1 > > + - items: > > + - const: pci1efd,edf1 > > Why are both versions allowed? If the former is more understandable, > can't we just go with that? > > > + - items: > > + - const: riscv,iommu > > Other than the compatible setup I think this is pretty decent though, > Conor. ACK to other comments, Thanks for the review, - Tomasz