Received: by 2002:a89:48b:0:b0:1f5:f2ab:c469 with SMTP id a11csp739973lqd; Wed, 24 Apr 2024 15:56:25 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXQwdheciDQMFfSKDvhRfzAEugohl63C8fwzNp3f4ux5P2ZcjeipdYfCDthhY/6ONhyG97OZWEgVjnFYbFN9wVJTLQYJknskPFphT2qVg== X-Google-Smtp-Source: AGHT+IFjN0QxEu9uNTvWMi3Otnkg0J/ssaua9qQ1NiQmv0C66C1/TL57aF3bnzeDosEUi0Ob/Rux X-Received: by 2002:a50:c356:0:b0:56e:2b1c:d013 with SMTP id q22-20020a50c356000000b0056e2b1cd013mr2259112edb.21.1713999385287; Wed, 24 Apr 2024 15:56:25 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713999385; cv=pass; d=google.com; s=arc-20160816; b=a1muUplHjGZaFCggoTSQkQ4Y1xMRZx89sRuBACS+TDsPgfqcyDJHsJfFokzWk10Cwl Rhtn3fk6wSEW5bekWrSfJNkbs90rYFNLoZbJt59HC3+Ju1Op5bCYIIPCHVnQfO4dDeTt odulMCbi8D+ymQvnmBDe+ic98ARdRHNqmzggIFMfafiB3K9zuQUrgfDGQHvwQzSjcR/V EdZewV3axWzjeXpFTb+D4fIDs+mfjI01UzL5b2swQhujXp0a0N7lYGiYOeW2SHfxzOvh qpaptyAtSO3env+v0g/sC0NI5SCxAdPuaJouMcKDXB8nylyFyMpNQOYpLN3yqc4sY+tn s1YQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=GmG+fEHBP8gIP1ZYSdwFfbBD/WbACGMT2ciJ+XzN0e0=; fh=CNhO48VK8DhbPsQ/SSIPYlk0Fh/QSz9Ow2ccuqDHvss=; b=W4eIi5WxUk7KXbpvul8K5kT86oZrrQZcb6d7j44ELkH6tGFikj7pbf7/678dS3Xzq8 h9ZFDie+/wo7NH31whUS5z+xe9SEFOFdwqY8tGuub4C8OlGozlTv7oJ750rzu/mcoZzT A9aE2161X5XnfCZ98bE7vRWFwxU2m8UxMvHfLliaLkcKdmiRqSu2GpaGCjCuT1M6TuGX 0HHaoTsaStze6pI5yvMnBXxMoNHv68CVGAk5Qc+fc/Ars1DUTDC49ubWGXjo3ppJxle0 ELu7LANQYrDvA72CEN+FtVHquGIWDEIe4eYGjNzuzA4Ln5xHgILlLsX+QRIK8uk/c92l lieA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=aUxgXy7O; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-157814-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-157814-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id e19-20020a50fb93000000b0056e23db9ce6si8859797edq.87.2024.04.24.15.56.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 15:56:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-157814-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=aUxgXy7O; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-157814-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-157814-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 0B0281F253D0 for ; Wed, 24 Apr 2024 22:56:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1E42316F0E4; Wed, 24 Apr 2024 22:55:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="aUxgXy7O" Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0817B16E885 for ; Wed, 24 Apr 2024 22:55:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713999358; cv=none; b=rR+pc5t8EDmq8xTZmBPk8yqfFLGy3Yp2LowhnqW1cFQggdOcAn9BfcA0dlDti/L2JBNsk3bXDQbHa0pDG5+mbVKpDse4iT1DS5rf22nmKKjZE3d98sSFQWrof1oLNwtKtw8nC93BB3SzjzQGDk0918YXGl6s8PZIQFrOHD1Ipyk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713999358; c=relaxed/simple; bh=NuyleERn9RTaJ6vM0GogmLDMo9hWEnQBetMIdltGBQc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=L7gXrD1tuUlE56ODxnfQ8K7nYdTimhuQu7ul+tGEBgzu7aqlSTCZFGwUz5930GxjTCi73kSKRYMErfGWwFetaHYbYI5RFo+ncTRaDXnxd7ie0MeQr7UvZ6T7I3tkXp/1MaXP6fOUblY3KL0aqeA933UFLyKWAbk6NWjCucyvHq4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=aUxgXy7O; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1e86d56b3bcso3414485ad.1 for ; Wed, 24 Apr 2024 15:55:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1713999356; x=1714604156; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GmG+fEHBP8gIP1ZYSdwFfbBD/WbACGMT2ciJ+XzN0e0=; b=aUxgXy7OTjS07+Mpfyl+3y4VwkOmWc9BK1OLpeOsXqTgBpcFE1qblTPRRtb3Q5j08H uUhMrGHSYAl/Qnp9yGEj/LTFj9JImc0yjTanDZsH4FSHJ24zaTyqoeflu+ktvsZtSo0q KCzfeZ3s7EPqomcKS/onsO8dYTtxx8zboh1tg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713999356; x=1714604156; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GmG+fEHBP8gIP1ZYSdwFfbBD/WbACGMT2ciJ+XzN0e0=; b=PvBwsDX5aKExL/0A1k1X7LFKamtEh3EU+0bNnwlPlJNTvA6pI0fiVmIvY+NPXnoI86 JdSHlo17jdeHANc8RVFJXhoEJJacs4rjGyyeixjASqg3juOg4kRO6VDD1YFXMsRfSu+Z s07uc/Dj9m+JTesttF3UqpII57bUUnS6+SlTIjJ4tEnNpOpq1a5qmi90KBVAb1AFp00y IPfwKLNGu197eS5+0U5DYKzRqb+njoMSzNmaAvNv2FEAGArztzmoA7YxzRTyHMmz4IfP 6A6EkBA7aBwJJtAvYhAOZt86lXQ8MPiYuBzQheRrFW5i1vejlfDrjl20cCLfLTZqo9lP xvfg== X-Gm-Message-State: AOJu0YyIbmQKSPz1HFGIduFTP2oRq/dUIwI22G85MzBfeFnPp5+V39un QqyyjKRR87UTRJdEUlEiJWS+us+caymdl/8mjXifa2TCxy/1P8LyPrx4Cwxrqw== X-Received: by 2002:a17:903:32c1:b0:1e5:5041:b18a with SMTP id i1-20020a17090332c100b001e55041b18amr5506877plr.40.1713999356407; Wed, 24 Apr 2024 15:55:56 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id o4-20020a1709026b0400b001e81c778784sm12396820plk.67.2024.04.24.15.55.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 15:55:55 -0700 (PDT) From: Kees Cook To: linux-kernel@vger.kernel.org, Max Filippov Cc: Kees Cook , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Eric Biederman , Alexander Viro , Christian Brauner , Jan Kara Subject: Re: [PATCH] binfmt_elf_fdpic: fix /proc//auxv Date: Wed, 24 Apr 2024 15:55:49 -0700 Message-Id: <171399934703.3282693.5984373700910072392.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240322195418.2160164-1-jcmvbkbc@gmail.com> References: <20240322195418.2160164-1-jcmvbkbc@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Fri, 22 Mar 2024 12:54:18 -0700, Max Filippov wrote: > Althought FDPIC linux kernel provides /proc//auxv files they are > empty because there's no code that initializes mm->saved_auxv in the > FDPIC ELF loader. > > Synchronize FDPIC ELF aux vector setup with ELF. Replace entry-by-entry > aux vector copying to userspace with initialization of mm->saved_auxv > first and then copying it to userspace as a whole. > > [...] Applied to for-next/execve, thanks! [1/1] binfmt_elf_fdpic: fix /proc//auxv https://git.kernel.org/kees/c/10e29251be0e Take care, -- Kees Cook