Received-SPF: pass (google.com: domain of linux-kernel+bounces-157854-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 24 Apr 2024 16:43:12 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: Joe Damato <jdamato@fastly.com>
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
 davem@davemloft.net, shuah@kernel.org
Subject: Re: ynl: maybe minor bug?
Message-ID: <20240424164312.50c4ed2b@kernel.org>
In-Reply-To: <ZimTlf_ISC2n8snQ@LQ3V64L9R2>
References: <ZimTlf_ISC2n8snQ@LQ3V64L9R2>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 24 Apr 2024 16:19:49 -0700 Joe Damato wrote:
> I'm not sure whether:
> 
> 1. tools/net/ynl/lib/ynl.py should be raising NlError when there is an
>    extack in this case (I think this is probably the way to go?), or
> 
> 2. the tests should be changed so that they don't expect an exception to be
>    raised but (ideally?) hide the warning report from tools/net/ynl/lib/ynl.py
>    when the warning is expected.
> 
> I don't know python at all so this is definitely wrong, but here's a small
> change I made to fix the test (a similar change was made for the test which
> follows).

Sorry about this, we pushed the related fix to the net tree, to get it
to Linus sooner:
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=a44f2eb106a46f2275a79de54ce0ea63e4f3d8c8

You can cherry-pick that locally, perhaps. net will get merged into
net-next tomorrow, I should have waited before extending the test :(