Received: by 2002:a89:48b:0:b0:1f5:f2ab:c469 with SMTP id a11csp789781lqd; Wed, 24 Apr 2024 17:58:06 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVFuIu3dHywP8eDeROMuWpY+maBLfhxmm7MZRObcHq1KFl/d8VjvZmcrVEUEVMOEAAuI0NafNqrjHkdQv/LlEdgKaYTfhViZXWlrjU5rw== X-Google-Smtp-Source: AGHT+IHVpbg6KHxavvz9If5qDnQ9KG3Kg/qI8uSj26Rp1Cy0cPQdG03JeqnY+5Fw3VDM4GkegBBc X-Received: by 2002:a2e:8388:0:b0:2d3:4b73:7b40 with SMTP id x8-20020a2e8388000000b002d34b737b40mr2409567ljg.17.1714006686454; Wed, 24 Apr 2024 17:58:06 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714006686; cv=pass; d=google.com; s=arc-20160816; b=z8iZ935zTUTitcfF39oO4T+qE4n/O2dpaN73ZqYrW1CnYHGY4TPI6CG2hmxdAWAlUO 6Mw1kD17jiw1XywTZSbjhVXZI2SciIz7NB5MQJM7Fobn4zwIu6PnX2rrfkjCvzK5UrAD QiIqUdF2R0dUoF4Ci9kc+eh7fzkzmxUKmMeOOce7nUsj/VQJAFSQcq1575QQ8A4JCZrC Q0jH8FJI7/UUnbbU2xaiDVyhCglhtYr3HAklEUzYd4sLbooTarmcXWvBf/yC+42FRaga 2ooqyEjXIhBAePZMFpFU6TBwvbtvZeCtaFzEKzbncmeS2qgW6LSYHvgn74/UoeO/iZ16 X3jw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature :dkim-filter; bh=hs/RZj5lsMbnG9+JZAQhqO/qGFihPkInPVFOlxvoHxQ=; fh=Pt2aVoeW1yUAckrcBWZa8KT1Dl3q9ipXQKE6+Oj7UHU=; b=hGXGT/PucgqH0B8zjkb0l8dMgiwYIwKJyWHYBc9TuqsaLieVBN1u4EXMAmEGaLzfU7 gxC8OLcXb5nwiocWU4UMv7C4WgABh3GGef4ZBWVpryZV/v1jRWwVwug1Ip9DJJKB1gzm rNz93ikdyalwNuglDfUaCPxgbfdNlD+PF0IuqcNlIJH8+hei4JIpW5TgvSX0K+eI/KHl ZlVjf+/9eTkZr1wNyMP3/hvek5KrsL2lqDA9SlCDFsk86Do7k5xxUieGwOaOAKUDBNUt r+x7F67QDtGedT3WVuVeVFFvxdNN+devWKBtI63tBYvgfgJpBrFsv/ijCsZ3A+9Q/1ka v8jw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@classfun.cn header.s=default header.b=ZQHPPUN9; arc=pass (i=1 spf=pass spfdomain=classfun.cn dkim=pass dkdomain=classfun.cn dmarc=pass fromdomain=classfun.cn); spf=pass (google.com: domain of linux-kernel+bounces-157892-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-157892-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=classfun.cn Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id c6-20020a50f606000000b005701ea8de8asi9170826edn.367.2024.04.24.17.58.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 17:58:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-157892-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@classfun.cn header.s=default header.b=ZQHPPUN9; arc=pass (i=1 spf=pass spfdomain=classfun.cn dkim=pass dkdomain=classfun.cn dmarc=pass fromdomain=classfun.cn); spf=pass (google.com: domain of linux-kernel+bounces-157892-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-157892-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=classfun.cn Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 1B4601F2502E for ; Thu, 25 Apr 2024 00:58:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 42AB57483; Thu, 25 Apr 2024 00:57:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=classfun.cn header.i=@classfun.cn header.b="ZQHPPUN9" Received: from classfun.cn (unknown [129.204.178.38]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5848F2582; Thu, 25 Apr 2024 00:57:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=129.204.178.38 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714006675; cv=none; b=WjtOIBsqOo+6Zh44RR5DKnJZadL/8nbE6RAlc41kEMdowdNjgY79j41RwucQtRO+eTx7zDEA5sIBjMWYVpiP9t3k6zIFkcGUbRtyC5DeiuKWo021uPel1Jqds//096Yn5yPD3Bam+prWAV3GMm3wQcyCMtYvAy3WNMlBPRjAuw0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714006675; c=relaxed/simple; bh=jJlA4qW0WfV3qbaZvbRCTVVym3gR466ShwgEbBIkoK8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YceyTm86PRTFviOTu1RFASdlbmpRGEx42wVHdp0+sfnXv5NHHGbmul99BdCBAigFrSeLcbYFT2IEeJmgxW7cqeJGsNRE0w64Hz99VdHEZR5VYSG9rOD8vhInYJAtgPndrbfUZDLdBW2xOnsQqPeMfWuTi8lFINeII4858AYQ6wM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=classfun.cn; spf=pass smtp.mailfrom=classfun.cn; dkim=pass (1024-bit key) header.d=classfun.cn header.i=@classfun.cn header.b=ZQHPPUN9; arc=none smtp.client-ip=129.204.178.38 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=classfun.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=classfun.cn Received: from [192.168.0.160] (unknown [220.162.71.180]) (Authenticated sender: bigfoot) by classfun.cn (Postfix) with ESMTPSA id 98B5D7870F; Thu, 25 Apr 2024 08:57:41 +0800 (CST) DKIM-Filter: OpenDKIM Filter v2.11.0 classfun.cn 98B5D7870F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=classfun.cn; s=default; t=1714006667; bh=hs/RZj5lsMbnG9+JZAQhqO/qGFihPkInPVFOlxvoHxQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ZQHPPUN9ksQCpiKXMkNkPEBhLgiJp84hXip1H8YS4+GRIvikmPULvbqe92LpStBlk LgcZepbk2WDIuzfVanjEuSsFAmRnriCydDCxazv/skIjRgp85iKYb35xkn4vyGykGD lL/cMUezXevZs7YXjmQXzoJb/epMKGR79gabHK9Q= Message-ID: <361fc6a0-f0d0-49b2-b885-3b197294ec9f@classfun.cn> Date: Thu, 25 Apr 2024 08:57:21 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/10] pwm: Add SI-EN SN3112 PWM support To: Konrad Dybcio , wuxilin123@gmail.com, =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Jessica Zhang , Sam Ravnborg , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Bjorn Andersson , Tengfei Fan , Molly Sophia Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org References: <20240424-ayn-odin2-initial-v1-0-e0aa05c991fd@gmail.com> <20240424-ayn-odin2-initial-v1-2-e0aa05c991fd@gmail.com> Content-Language: en-US From: Junhao Xie In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 2024/4/25 03:37, Konrad Dybcio wrote: > On 4/24/24 17:29, Xilin Wu via B4 Relay wrote: >> From: Junhao Xie >> >> Add a new driver for the SI-EN SN3112 12-channel 8-bit PWM LED controller. >> >> Signed-off-by: Junhao Xie >> --- >[...] >> +    return sn3112_write_reg(priv, SN3112_REG_PWM_EN + reg, >> +                priv->pwm_en_reg[reg]); > > This looks like a weird reimplementation of regmap_update_bits > We cannot use regmap_update_bits because this chip does not support read command. It will discard all read command. >> +} >> + [...] > > devm_pwmchip_add? > > Konrad Thank you for your reply, I will fix them.