Received-SPF: pass (google.com: domain of linux-kernel+bounces-157897-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Zi Yan <ziy@nvidia.com>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org, fstests@vger.kernel.org,
 linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, willy@infradead.org,
 hare@suse.de, john.g.garry@oracle.com, p.raghav@samsung.com,
 da.gomez@samsung.com
Subject: Re: [PATCH] mm/huge_memory: move writeback and truncation checks
 early
Date: Wed, 24 Apr 2024 21:07:16 -0400
Message-ID: <0273A5B5-0BAB-4A11-A760-5337927B0264@nvidia.com>
In-Reply-To: <20240424225736.1501030-1-mcgrof@kernel.org>
References: <20240424225736.1501030-1-mcgrof@kernel.org>
Content-Type: multipart/signed;
 boundary="=_MailMate_EFD33508-11D7-4F57-BBB2-72B845D772E5_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?qq2RUNpTjUF9zluJsdWZQzGjR9MQL8V4KaKkbNam6bbxVz2mXvboUAqCGq0x?=
 =?us-ascii?Q?CDNBnfYmURIgh6DWT9j7mx0WOOZCfDEMqEfthSOnwdXvLqNM2zP0p3fBEEPv?=
 =?us-ascii?Q?j0rosbgn4EgCiK3dnU6mM+YbOoYrL9wA9fiTjhwCyzgyzdJ+xQVcL90FFCqo?=
 =?us-ascii?Q?GDoC/UDyVN7lZ1IdNscf/g9fpBL6LPTkbWkhk5Oh/f9jWACv5YABnEiC/gso?=
 =?us-ascii?Q?7g43rr2JWyaic4c0lISPfTbmzWGlH+VP/K1r0KclnqNoTZQA6DiJ4GWm+Kgv?=
 =?us-ascii?Q?Hd3GolUAJ95wo1TvrnG/cnAW25LQEXSj2jULCsjY229zP7M2Oj9zQg622LRt?=
 =?us-ascii?Q?LnnYmCCimF3oBbOc2FB8LrcjsE7DMzIYQKtO6cPsED55zgjBJKzLhoed5HEm?=
 =?us-ascii?Q?f5Ztn+HXkbuLn02kZUwJgTlGnOTnMds/8F32n8VXsEVB2Joppw3dN81vpLzs?=
 =?us-ascii?Q?ZoVStso2ufUQDss5hFMEbwciw2vf9MzvmzyGc22DZmxBO4fK9V7C85hgBVpu?=
 =?us-ascii?Q?+Q/CTFzUt+wLbpkX8lRfzXJ626Z3oeSU5NiY57l86yetCViYpmzKJFyCH4wr?=
 =?us-ascii?Q?ARKrRkxaKajuAMHjVKYtdaDLAeUVpeqZHNOkzuQc/gtLR+ivSw21Xh1B2IGw?=
 =?us-ascii?Q?e6jFPUj4rtyssaNWW60aezZhwsa/AP55SoHN1AocqBFx5MkJ73YTvBBcAIxN?=
 =?us-ascii?Q?vcMuhjsMcIegFQxxZL5o673eu8U0f0AM+y/+A/Q8R3QuXx1kLEi+5KGtUOKS?=
 =?us-ascii?Q?vWnqbGRxpAk9yZUzM1v8JR4hdulBAPhg6Ah9I5Z0ar7tXVRBzqmPS8EbVeEs?=
 =?us-ascii?Q?AQkYR05tJ5i1hhI4gZGyH0TjzGAFSU53n+mH1fDMTJOJHrNygy25WANbOmaj?=
 =?us-ascii?Q?ciQKTlFK1Z+kc1bIoX1chARyOvol9/tH5zpoPVG+MxGKFKq1Hx69XtmfuaVn?=
 =?us-ascii?Q?DwY53gG82Muur5Z95HhX5rFS5FbD9NQnhcG3ELWddJjEp/1RU0Ro3v6Pec8x?=
 =?us-ascii?Q?ijt7mNsP5Ae0MMr15ZosSRp6JNpK1xuHkIk7qTjuFvebXKU//+vUCSIxcP/1?=
 =?us-ascii?Q?OvwBh+LMqAY/pPIpP/NDE6UALpcqO3X2wbdygBt+CiMKR6hF6Mq8hCC7Ip5z?=
 =?us-ascii?Q?MMtORqk2my9S29sH1gVzCttHmHlg+m8k9C7UKv8Ue1nhnDpcpUwX9PyCCwFt?=
 =?us-ascii?Q?K+2FSjZo1WJ2KaerHx5Pah/a73Oy75wrC5hZxlu3m1Tyu8CUfmaTqyS2jFuB?=
 =?us-ascii?Q?9qkpsJEgi91v1HSJjeeQy/4hRM8lCcMozeYexv76ddMnH5QRkof1l8mA8hwW?=
 =?us-ascii?Q?E/qegtEF1Qr3+NZQgK6zcNTlII6yd94PMm1ajehdcBhcxaFrn2GqMwi8aX2z?=
 =?us-ascii?Q?h8cyT1JqWt3IOVos+Hmc4cM5ast8UhSVOOx8nDh9PQiV8T/LSN5SsYcw9bLl?=
 =?us-ascii?Q?1pdOvwju23gzWuTYWVeLhTyE6C+MTgwyxdRevAAOCD21HyGe/7OWFACNHKhA?=
 =?us-ascii?Q?ElSTOOLyDGqne/pXqFAt62ivbKIPvqFyUwX2FWdu8ARiWkWsR3Br/XnZOrU8?=
 =?us-ascii?Q?JrnmhD2BWPfzoBMkdmeMSD+nvLJA1qxMjfgQnWYZ?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d051aed6-6331-4ed0-f002-08dc64c40d6b
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2024 01:07:18.2351
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8N7YK+gKqThakAV/BeD62c2/zTsCXOx0+Y3oGG9NtEFP/vgQtwPCMWNfHsCTrdiA
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7198

--=_MailMate_EFD33508-11D7-4F57-BBB2-72B845D772E5_=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On 24 Apr 2024, at 18:57, Luis Chamberlain wrote:

> We should check as early as possible if we should bail due to writeback=

> or truncation. This will allow us to add further sanity checks earlier
> as well.
>
> This introduces no functional changes.
>
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> ---
>  mm/huge_memory.c | 23 +++++++++++------------
>  1 file changed, 11 insertions(+), 12 deletions(-)
>
> While working on min order support for LBS this came up as an improveme=
nt
> as we can check for the min order early earlier, so this sets the stage=

> up for that.
>
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index 86a8c7b3b8dc..32c701821e0d 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -3055,8 +3055,17 @@ int split_huge_page_to_list_to_order(struct page=
 *page, struct list_head *list,
>  	if (new_order >=3D folio_order(folio))
>  		return -EINVAL;
>
> -	/* Cannot split anonymous THP to order-1 */
> -	if (new_order =3D=3D 1 && folio_test_anon(folio)) {
> +	if (folio_test_writeback(folio))
> +		return -EBUSY;
> +
> +	if (!folio_test_anon(folio)) {
> +		/* Truncated ? */
> +		if (!folio->mapping) {
> +			ret =3D -EBUSY;
> +			goto out;
> +		}
> +	} else if (new_order =3D=3D 1) {
> +		/* Cannot split anonymous THP to order-1 */
>  		VM_WARN_ONCE(1, "Cannot split to order-1 folio");
>  		return -EINVAL;
>  	}
> @@ -3079,16 +3088,12 @@ int split_huge_page_to_list_to_order(struct pag=
e *page, struct list_head *list,
>  		}
>  	}
>
> -
>  	is_hzp =3D is_huge_zero_page(&folio->page);
>  	if (is_hzp) {
>  		pr_warn_ratelimited("Called split_huge_page for huge zero page\n");
>  		return -EBUSY;
>  	}
>
> -	if (folio_test_writeback(folio))
> -		return -EBUSY;
> -
>  	if (folio_test_anon(folio)) {
>  		/*
>  		 * The caller does not necessarily hold an mmap_lock that would
> @@ -3111,12 +3116,6 @@ int split_huge_page_to_list_to_order(struct page=
 *page, struct list_head *list,
>
>  		mapping =3D folio->mapping;
>
> -		/* Truncated ? */
> -		if (!mapping) {
> -			ret =3D -EBUSY;
> -			goto out;
> -		}
> -
>  		/*
>  		 * Do not split if mapping has minimum folio order
>  		 * requirement.
> -- =

> 2.43.0
LGTM. Reviewed-by: Zi Yan <ziy@nvidia.com>

--
Best Regards,
Yan, Zi

--=_MailMate_EFD33508-11D7-4F57-BBB2-72B845D772E5_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmYprMQPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhU3UUP/0lNC4zViOjzsR4/JRXCw7+NflMLLzetGzJ6
hGLAY2bmIi49AGPsmB7h8BgPifP5SFLW5AH5W3RMGW9LTh+3I7sDc+uSNnBtO5Gs
e/1CvxYv/go+Eo8yvC63NvKpVY1Rk4Wqj/ZAJAl3uq7Wm/qFyuAw1/XWFc+Cquid
prqnKv+q7M4aqlXd6SidR8iuHvVX9iePZsjT/OsgEJlzFXGXOWLFBcPS84+eQvk6
gTbp+uYzXxU0w1GsFaH6/kcFeK3hTihDTpcQTbySYGynvVE5IzjFxovLOhweBgkO
bziUF6oNjeS4K4kvpU03wSsIUR3cnYbPyrITswKo5TzCaXuzu3Qg7/EDoUKKQu6I
7VzZelcgyGziVMFeAkJNrY5KPAxpfo5xtokcwfqOUa0bJbaoPv06CzmjHEEc2jHR
rEow9LbKjsWG62Lw4tasc7N1xnDodmqAm9CFgPrm3s8J6jr7Uw6hYLVUXOY65Xw0
nP78kk/3WULZ1Ou/6Sfr4WLRmFinzWw2IOR5zm6pFjsfeVMWM8v73wxdXIky+wr1
7hAh7B7MhUHzY4ZyFiEx0z7zs4UX1M2p57b7Vcd3/KRbMMyDxXoimf4atIpv92vM
yU3E4uHiKGJ9dRZ07kITfghbNPdkU5tFNygYiz3THmQvoPwKTxbUbrfUDN6D92QO
7HcKAMN6
=zpZR
-----END PGP SIGNATURE-----

--=_MailMate_EFD33508-11D7-4F57-BBB2-72B845D772E5_=--