Received-SPF: pass (google.com: domain of linux-kernel+bounces-157916-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: "Huang, Ying" <ying.huang@intel.com>
To: David Hildenbrand <david@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,  linux-mm@kvack.org,
  linux-kernel@vger.kernel.org,  Hugh Dickins <hughd@google.com>,  Alistair
 Popple <apopple@nvidia.com>,  Anshuman Khandual
 <anshuman.khandual@arm.com>,  Mel Gorman <mgorman@techsingularity.net>,
  Miaohe Lin <linmiaohe@huawei.com>,  Minchan Kim <minchan@kernel.org>,
  Ryan Roberts <ryan.roberts@arm.com>,  Yang Shi <shy828301@gmail.com>,  Yu
 Zhao <yuzhao@google.com>,  Kairui Song <kasong@tencent.com>,  Barry Song
 <v-songbaohua@oppo.com>,  Chris Li <chrisl@kernel.org>,  Yosry Ahmed
 <yosryahmed@google.com>
Subject: Re: [PATCH] mm,swap: cleanup VMA based swap readahead window
 calculation
In-Reply-To: <49d85e19-feac-417b-9640-ff8059bc8b0b@redhat.com> (David
	Hildenbrand's message of "Wed, 24 Apr 2024 11:23:10 +0200")
References: <20240424063042.665018-1-ying.huang@intel.com>
	<49d85e19-feac-417b-9640-ff8059bc8b0b@redhat.com>
Date: Thu, 25 Apr 2024 09:45:53 +0800
Message-ID: <877cgmrz8u.fsf@yhuang6-desk2.ccr.corp.intel.com>
User-Agent: Gnus/5.13 (Gnus v5.13)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=ascii

David Hildenbrand <david@redhat.com> writes:

> On 24.04.24 08:30, Huang Ying wrote:
>> When VMA based swap readahead is introduced in commit
>> ec560175c0b6 ("mm, swap: VMA based swap readahead"), "struct
>> vma_swap_readahead" is defined to describe the readahead window.
>> Because we wanted to save the PTE entries in the struct at that time.
>> But after commit 4f8fcf4ced0b ("mm/swap: swap_vma_readahead() do the
>> pte_offset_map()"), we no longer save PTE entries in the struct.  The
>> size of the struct becomes so small, that it's better to use the
>> fields of the struct directly.  This can simplify the code to improve
>> the code readability.  The line number of source code reduces too.
>> No functionality change is expected in this patch.
>
> From a quick scan, you perform quite some unrelated changes that make
> the code harder to review than it should be. Consider separating any
> cleanups from the core change of removing the struct.

Sure.  Will separate it.

--
Best Regards,
Huang, Ying