Received-SPF: pass (google.com: domain of linux-kernel+bounces-157919-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
To: Kees Cook <keescook@chromium.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
        Charles Bertsch
 <cbertsch@cox.net>,
        Justin Stitt <justinstitt@google.com>,
        Bart Van
 Assche <bvanassche@acm.org>,
        Andy Shevchenko <andy@kernel.org>,
        Sathya
 Prakash <sathya.prakash@broadcom.com>,
        Sreekanth Reddy
 <sreekanth.reddy@broadcom.com>,
        Suganath Prabu Subramani
 <suganath-prabu.subramani@broadcom.com>,
        "James E.J. Bottomley"
 <jejb@linux.ibm.com>,
        Kashyap Desai <kashyap.desai@broadcom.com>,
        Sumit
 Saxena <sumit.saxena@broadcom.com>,
        Nilesh Javali <njavali@marvell.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Himanshu Madhani
 <himanshu.madhani@oracle.com>,
        linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
        MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
        mpi3mr-linuxdrv.pdl@broadcom.com,
        GR-QLogic-Storage-Upstream@marvell.com
Subject: Re: [PATCH 0/5] scsi: Avoid possible run-time warning with long
 manufacturer strings
From: "Martin K. Petersen" <martin.petersen@oracle.com>
In-Reply-To: <20240410021833.work.750-kees@kernel.org> (Kees Cook's message of
	"Tue, 9 Apr 2024 19:31:49 -0700")
Organization: Oracle Corporation
Message-ID: <yq134ra6wui.fsf@ca-mkp.ca.oracle.com>
References: <20240410021833.work.750-kees@kernel.org>
Date: Wed, 24 Apr 2024 21:55:02 -0400
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?xO26881TwKKpQ5vh+zVOYiMP0+4h50eXSr+zc/T2Ntcm8o4oW4VQ2pRHepPZ?=
 =?us-ascii?Q?nda1KO3yPBkxE1a7C1098f1DoNjlLenZJP0K6lmwj60TgXDfiy/WCFwTN4bY?=
 =?us-ascii?Q?30eHaLS2lMO5D1W0xnbiP2aGbg9OJOXnqEDdhzsAAGj07ay7nDtH/HDBmXh2?=
 =?us-ascii?Q?gIuHZEYKpjfXYimq58sDGmZ1Zt2UPI80u16SM1gRGkSvzoxtZLdVoaFpzouT?=
 =?us-ascii?Q?//lodzuI3+sHjXloChuUQfK/pJHstknF++KUI8ZI4aAQq0DMr+nH31F8MyF6?=
 =?us-ascii?Q?FnFawIJOg6UYStvF504TxaaOXC8RTE2pxnIgLkjBx1k9CP+gW8cIAijA/+s9?=
 =?us-ascii?Q?yUnZqREuH9Ba/0bPzbMnIFGkBazsJRVG5tRHNsn4zwyBhWNVIN1ONPyXTgf7?=
 =?us-ascii?Q?gDYmmakdMw29l9XbmtS9nWNELMgfa6XYqb9zaiZG1U6Mt2cQWfJBYe1to5J3?=
 =?us-ascii?Q?tzMHGPeyOMfrsEeD+h1WRl67wqiJ1Y07nQRj0f3Q0VasqIhEJSchpp5jq5jl?=
 =?us-ascii?Q?ZORVlby16Wk1r1a4P+iAyx+rqW2Eocl/wy1YlOCr14CEyKwvYgNX9jR1/z/4?=
 =?us-ascii?Q?2Dr3LYTzUG+v7phfytRTUvCkt7Lf3Cbzj+2K/siP92I2ME+4IkJe7tdJr6tD?=
 =?us-ascii?Q?BkQKejDo+fP81+yGLkbpp4ljXxEy13wgaVcLujnYd26IaQM625LDeDmNesGI?=
 =?us-ascii?Q?leI2/TfC90qA0gAhFvmwpj9BOuhx7kWFXjDQHZ89B0SLX08GMNgEV3+NNRHi?=
 =?us-ascii?Q?fquJ1QBVRyKg/6Jq/y9gEEop+QE+FWBJN2SEygT81CHaoDYDmW13QUBRNtVJ?=
 =?us-ascii?Q?c+miO7gDmTJ02GO+Gk2BwQ4ekjIsxpwijqhPmqqGHnG7CrKhrq301sYTYuuz?=
 =?us-ascii?Q?itG5dAqMgpxmFfv/qBUQ+FbQPN9TWVyNnuRQLrp/sflSUHUtREkmY7br7YZ1?=
 =?us-ascii?Q?xhY7c3Rich7Gs9cvApoks/R7etmMDO77nOof1vu1bDeyJLfVMAoT3sgAioRm?=
 =?us-ascii?Q?dn1C/LzqbunQm+lz3O10QuW++cOg5H5RrDzXUA10N/8E8/CqA2RXqlmvrZ7l?=
 =?us-ascii?Q?Xgu9lmYkmBTW5OCtzLTas3m+Yw0MrK+Lu8cjHLggrHZVtZT7bxKWwnIvSqXf?=
 =?us-ascii?Q?eViASEsD/pcZhAFTeI467hs4RlS1QuqTuXH1wGxS5KGYHM6iC07jXj0LXq85?=
 =?us-ascii?Q?Obzr/ejpHBq1UpTMc9wbV8ykCGKSnyIC5fscLnvDnDbgJiH88jyGdId5PZI9?=
 =?us-ascii?Q?TKgLX651sOtyFIwTo8G23yASjRW706PWkToLksldOHBEgUbHQhu0C45Nw1r6?=
 =?us-ascii?Q?NfFyUnq9aWeVeQLFK5hnbl/mCiYdlhgmMZbiUhzGnMUe7Ys1cxHeYrCO+2my?=
 =?us-ascii?Q?BhpaTnIFJdFtm18vgEkRp4Z6YWJB+d6bSWf3z1u+5R2yNEX1BppowWIU8Vu/?=
 =?us-ascii?Q?O5W3BCaq1871CLjYke7+zzNxGWa1ywn4ccV3cWySsg+Aw8TrFbiAJ7fx98MG?=
 =?us-ascii?Q?1mrRVCA8zwoBneczZdiT8OdsgphvPqace4fFWdV2MfzeyBOWitFKcVJgEUzy?=
 =?us-ascii?Q?yPzH1s6D1cNxfJNMpQGW48+/Kt2v/b1WGwU7dDrU4scoewh3w6hasfFR4JoD?=
 =?us-ascii?Q?Rw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	rbv5cCIQ9KW1sbMN4YNP/jcHpRB5kO/hBFq09PwfbKJrgu4gKp0VDc9ZXCYv9M7z6bls2RJ8aQMsaOmLPkQ0f36NVQSerpqe9dvu0w7Snh8eF731ez9dPsfO9QiT7npFivBfN5wlhW8RadoucA/wHpxh5tJS6gO/xRi66nY6ENX4GMpsXBkkBIkCYYVmolDf+1tCyTrTu7GMrvo/jgI1DaJWozVB/66pdcf6lToFu2oh2NJSYMOxgGi+h/MZiwQ24hZR/4CbGY3aeFod0gosc9RDqCSu71kRze7vrKjR5Ju6dJI7Eb4HgXpxecHknqzcVG3Gpl3IPyIgRBNwGn14xeqoB0Pm/5gR2ch0k6sUogK4mA4hvweR3rmjXf6Bfd0dsnDXP8n+839tZiJv4by1JkRX1y/fvVre2r16lPXSkXxoF9CExF+6asZLMb0i5EmD9g16m35igtFLLrdJ+++rKmC65e0bCuI+vfhDplFXWIzLTCZuOCNUwfdnlYc1wG4/GQkF/T8V8qNrRGpIqLqB0doARAR0EMgkAdvhcByA5afKBsWtDwt6bijiDkvktUPTJS2PuZbmjqVburyOjV7hwfbPTcX5ehpStulrG+id6ws=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 271f98f1-b581-4559-a0f8-08dc64cab9f4
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2024 01:55:04.8185
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: srDw638wtjUF//3l6Xwy6GQyhYSdDMzJyyXV/vgil+LZWWT3cPiLp8DaeJTAgLbccNln1eHPwkFc1iA5JQFvLh9oav5WzTlDGi8ommBJl7o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6675
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-04-25_01,2024-04-24_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 mlxscore=0
 mlxlogscore=999 bulkscore=0 malwarescore=0 spamscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000
 definitions=main-2404250012
X-Proofpoint-GUID: uzuW8DMwkG-0qo7nxBZElM5TZemk8c5v
X-Proofpoint-ORIG-GUID: uzuW8DMwkG-0qo7nxBZElM5TZemk8c5v


Kees,

> This series fixes all 4 of the instances I could find in the SCSI
> subsystem.

Looks OK to me.

Minor nit: I do find it a bit odd to think of a string as "memory".
Maybe that's just because I am so used to always having to distinguish
between fixed length strings and NUL-terminated strings in the storage
protocols and hardware programming interfaces. But both types are
definitely referred to as "strings" colloquially and not so much
"memory".

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering