Received: by 2002:a89:48b:0:b0:1f5:f2ab:c469 with SMTP id a11csp841112lqd; Wed, 24 Apr 2024 20:27:15 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVdCezfBuN4Xi1vCia1O792yeERuiZtOmyo/OSMNzF2BLjxg+lS452/X5iuiciKzdl0ulIwdR1NRoyaw3gbokmKWUqEvliIgShEHjcM4Q== X-Google-Smtp-Source: AGHT+IHWuAFCrmzkeY7ONwbzayBns3YXhPlmZAoKthp00LQtmMDC6t5OocYrUQ3pIefVZIxI9sEs X-Received: by 2002:aca:1816:0:b0:3c7:41ba:102f with SMTP id h22-20020aca1816000000b003c741ba102fmr4360179oih.34.1714015635443; Wed, 24 Apr 2024 20:27:15 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714015635; cv=pass; d=google.com; s=arc-20160816; b=wBOY7+aa7raJuhe/kgEGvHJkcHCJHhVR2GwgRjsOU5I8LhOHWa2AE0c6XKtjijtZXl VrTdkmbOCdtAh1YTEYc0Cw0mUCO8jYviEz9creQ9rN2vqElTKtW3c6hUj0ZIxQy2hhsR vr36IrUl1vy8GuwV8CPHI4YnM/Y5SlKmJOQUcliJ7DaGR3AtsrDust7Krp5lK4rjkftm cam5fw0zst9/nRRuXk8NbAiHCMx0F3VyD7c4ydDmndSn8YDLDHIsmmIpmgmTc0xPm0I9 JK6qS8WRy6DJlVSoJI7I7KtVguuw54PLqunkGi1yC2dWdyuapUIpWNKkAdyj1wYuzLmu SzqA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=My5MFhg/Ti3D+MPt/VmtN9NQVsT2BKm8TXTOezs6Y4k=; fh=uljNe7QXZQv2+VQPY6nttnBmur7ADO0prkFeoD+OPJg=; b=crcf0cMp1SYwvp3e4A+TT6faCs10rk9wIRWpGBXIHxchAZP4qhIoMCnPy3mBvyowOv rGt2dU837M67pDYVhn26//9hCyeqvTf4WhFfxXpnYacBU8GR+AZ3Du/3kftDNJGjQ7fY t6669fivCyS/hJarsUvjXHnAG627x+PVY93Mi3lnhavQZ8mBW6Yr+jhaVoHWAdut+/OQ qgUY/yQD6nb+gTaGoKanXqE2L6FHr0mDZ9YQiaUJsOHgtRHdMXg4Vofnhexpj8tEM2xl T4QIP7HlD+OY2PC5ej4XNgmTS/iTDqPb0LHMhe3WppLbXBz27XaSFXxAYm+ppGouVN4A CJBA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LmjBzoOm; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-157968-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-157968-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id k12-20020a63d10c000000b00602a85927c1si4665380pgg.539.2024.04.24.20.27.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 20:27:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-157968-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LmjBzoOm; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-157968-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-157968-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id EC152282793 for ; Thu, 25 Apr 2024 03:27:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 91CE424B2A; Thu, 25 Apr 2024 03:27:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LmjBzoOm" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3B772110F; Thu, 25 Apr 2024 03:27:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714015625; cv=none; b=cxkAZQmqvePMIA/eLFD5/HWHXwxCU+WCGvcq16yIAJoWoMaJ6SDV5z+d0hVMcfS55drivpErXrQFD5VdLylJbU+EUbh8P+rikVTyWwMclXjUPx6vNla7zvLD0JNIb8usARltrV/F5ttYpqt1/O8GfnfGcALmr4ZiButxRVW+Zm4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714015625; c=relaxed/simple; bh=My5MFhg/Ti3D+MPt/VmtN9NQVsT2BKm8TXTOezs6Y4k=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Vs1tCr6o+XEZ+2oicUjASWhqg8Ni9Ygq48Tha7pAhoE3MYZCHV4GlJkhr5vLT4e8jb36EVRmkMxSkxnB94F3R6J9T2+vsEM7wQ5OPBwF3QgH0RsN0F83TQz31L/te1vza+nLTd2zu590QTxgkpN+rViUJh9Ap2xwQAjnIaDF2xQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LmjBzoOm; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7FB85C113CC; Thu, 25 Apr 2024 03:27:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714015625; bh=My5MFhg/Ti3D+MPt/VmtN9NQVsT2BKm8TXTOezs6Y4k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LmjBzoOmzmB104dVQfa8NJPB2d6PEG8tidOzXPlYVOCXAG6JZmbm3Fg0Z2qi7Cq/D rQ+5LLt5b9NTo7Ahrmxg6LUxuJeTw3igz4OWgDTEx1ScbGfCa7+0eN8iq2r7EM0JF4 wTLEFmlqlF6e8axwzr1iZcBeYsrfNrK7qNJ4aCtthsXA/gqcpLfmdN1rgkzYGMfTDi aWLI/n/EAH0ByPXpLkW7svrHtaFxgM7+UXdcXI0Ypkv1HoJAa7gmyoAtPlDbVBfuds qfox/053+0paESXy1hHl493DCj919CJFySRcCBE0REB3M1aZHlpbF9FPivtZS2/Dez CDlw/cIrzuz7A== Date: Wed, 24 Apr 2024 20:27:03 -0700 From: Jakub Kicinski To: Shradha Gupta Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Bjorn Helgaas , Jonathan Corbet , Randy Dunlap , Johannes Berg , Breno Leitao , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Souradeep Chakrabarti , Konstantin Taranov , Yury Norov , linux-hyperv@vger.kernel.org, shradhagupta@microsoft.com Subject: Re: [PATCH net-next v2 1/2] net: Add sysfs atttributes for max_mtu min_mtu Message-ID: <20240424202703.29f1b59a@kernel.org> In-Reply-To: <1713954817-30133-1-git-send-email-shradhagupta@linux.microsoft.com> References: <1713954774-29953-1-git-send-email-shradhagupta@linux.microsoft.com> <1713954817-30133-1-git-send-email-shradhagupta@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 24 Apr 2024 03:33:37 -0700 Shradha Gupta wrote: > Add sysfs attributes to read max_mtu and min_mtu value for > network devices Absolutely pointless. You posted v1, dumping this as a driver specific value, even tho it's already reported by the core... And you can't even produce a meaningful commit message longer than one sentence. This is not meeting the bar. Please get your patches reviewed internally at Microsoft by someone with good understanding of Linux networking before you post.