Received-SPF: pass (google.com: domain of linux-kernel+bounces-157969-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <CAO7dBbVNv5NWRN6hXeo5rNEixn-ctmTLLn2KAKhEBYvvR+Du2w@mail.gmail.com>
 <5d81d6d0-5afc-4d0e-8d2b-445d48921511@linux.dev> <CAO7dBbXLU5teiYm8VvES7e7m7dUzJQYV9HHLOFKperjwq-NJeA@mail.gmail.com>
 <b6c0bd81-3b8d-465d-a0eb-faa5323a6b05@amazon.com> <20240326153223.GF8419@ziepe.ca>
 <0e7dddff-d7f3-4617-83e6-f255449a282b@amazon.com> <20240403154414.GD1363414@ziepe.ca>
In-Reply-To: <20240403154414.GD1363414@ziepe.ca>
From: Tao Liu <ltao@redhat.com>
Date: Thu, 25 Apr 2024 11:27:03 +0800
Message-ID: <CAO7dBbX0ZBwSzvi=ftNHe73hPP6Ji2WWTsKKYmD2tZENMjH_bw@mail.gmail.com>
Subject: Re: Implementing .shutdown method for efa module
To: Jason Gunthorpe <jgg@ziepe.ca>, "Margolin, Michael" <mrgolin@amazon.com>
Cc: Gal Pressman <gal.pressman@linux.dev>, sleybo@amazon.com, leon@kernel.org, 
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org, 
	linux-rdma@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Jason & Michael,

Kindly ping... Any progress for the efa .shutdown implementing? Thanks
in advance!

Thanks,
Tao Liu


On Wed, Apr 3, 2024 at 11:44=E2=80=AFPM Jason Gunthorpe <jgg@ziepe.ca> wrot=
e:
>
> On Mon, Apr 01, 2024 at 04:23:32PM +0300, Margolin, Michael wrote:
> > Jason
> >
> > Thanks for your response, efa_remove() is performing reset to the devic=
e
> > which should stop all DMA from the device.
> >
> > Except skipping cleanups that are unnecessary for shutdown flow are the=
re
> > any other reasons to prefer a separate function for shutdown?
>
> Yes you should skip "cleanups" like removing the IB device and
> otherwise as there is a risk of system hang/deadlock in a shutdown
> handler context.
>
> Jason
>